Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 332633 (keepdir-var-run_lock) - [tracker] packages that keepdir /var/{run,lock}
Summary: [tracker] packages that keepdir /var/{run,lock}
Status: CONFIRMED
Alias: keepdir-var-run_lock
Product: Quality Assurance
Classification: Unclassified
Component: Trackers (show other bugs)
Hardware: All Linux
: High QA
Assignee: Gentoo Quality Assurance Team
URL: http://archives.gentoo.org/gentoo-dev...
Whiteboard:
Keywords: Tracker
: 523772 (view as bug list)
Depends on: 453438 runtime-paths 333783 333821 333893 334245 334437 334535 342049 387887 387889 387893 387895 387897 387901 387903 400899 401019 401023 401027 401029 402399 414307 432458 432462 436642 442002 442372 442852 442974 444167 444912 444936 445182 445398 445686 445694 445882 445944 446206 446446 448464 448498 448512 448738 448834 449242 449360 449392 449664 449858 449876 449878 449880 449966 449968 449986 449988 449990 450204 450222 450224 450472 450538 450830 450836 450838 450872 450882 450996 451014 451068 451418 451420 451430 451432 451756 451764 451774 451794 451798 451800 451808 451966 452218 452222 452230 452740 452786 452982 452990 452992 453042 453140 453442 453598 453668 453700 454078 454182 454674 454676 454840 454994 455002 455014 455542 455598 457164 458026 458040 458158 458162 459316 461548 466234 467506 468340 472066 472742 474858 475412 476242 476672 478550 479400 479632 479714 480438 480502 480534 482034 482590 483510 483590 490564 501400 503300 504528 511710 514452 515562 517560 519358 529506 529886 531840 538102 538848 539400 676046 685328 691902
Blocks: 648880
  Show dependency tree
 
Reported: 2010-08-13 16:06 UTC by Jeroen Roovers (RETIRED)
Modified: 2023-05-04 19:05 UTC (History)
15 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fgrep -H "keepdir /var/run" */*/*.ebuild eclass/*.eclass (keepdir_var_run,20.93 KB, text/plain)
2010-08-13 16:17 UTC, Jeroen Roovers (RETIRED)
Details
var-run-PN (var-run-PN.txt,1.70 KB, text/plain)
2011-10-20 21:56 UTC, Alexey Shvetsov
Details
packages for which no bug has been filed yet (keepdir-var-run-no-bug-yet.pkglist,1.30 KB, text/plain)
2012-12-25 23:17 UTC, Jeroen Roovers (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeroen Roovers (RETIRED) gentoo-dev 2010-08-13 16:06:40 UTC
As discussed on the gentoo-dev mailing list, some ebuilds choose to create a /var/run/${PN} directory at installation time instead of at runtime. Our init.d scripts should check whether a subdirectory is present and create it if need be, instead of using keepdir in the ebuilds.

This bug report is a tracker for the specific flaws in affected packages - DO NOT COMMENT on this bug report, and file blocking bug reports for each affected package.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2010-08-13 16:17:00 UTC
Created attachment 242797 [details]
fgrep -H "keepdir /var/run" */*/*.ebuild eclass/*.eclass
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2010-08-13 16:26:18 UTC
Comment on attachment 242797 [details]
fgrep -H "keepdir /var/run" */*/*.ebuild eclass/*.eclass

Not included here are packages that install subdirectories in /var/run without using keepdir, such as sys-libs/pam.
Comment 3 Alexey Sarychev 2010-08-13 21:08:48 UTC
I believe this one will be a little better:

perl -ne 'while(/\\$/){chomp;$_.=<>;}; /keepdir/ and m#/var/run# and print "$ARGV: $_"' */*/*.ebuild eclass/*.eclass(In reply to comment #1)

Comment 4 Alexey Shvetsov archtester gentoo-dev 2011-10-20 21:56:08 UTC
Created attachment 290391 [details]
var-run-PN

List of packages that installs something in /var/run
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2012-05-03 04:56:17 UTC
*** Bug 414439 has been marked as a duplicate of this bug. ***
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2012-05-03 04:57:36 UTC
(In reply to comment #5)
> *** Bug 414439 has been marked as a duplicate of this bug. ***

Arg. Sorry about above. Mistakenly assumed from a log file this bug was for media-video/motion package, instead of a Tracker. Move along ...
Comment 7 Pavel Goran 2012-11-27 08:40:45 UTC
How come /var/run was moved to a temporary filesystem without fixing all these bugs *beforehand*? For now, when a stable system gets updated with stable openrc-0.11.5, the latter moves /var/run to tmpfs and the affected daemons suddenly stop working after reboot.

A partial solution for the problem would be making the affected ebuilds block the new openrc. (Though this wouldn't save users of the new stage3 that reportedly also have /var/run on tmpfs.) The actual solution would be to correct those ebuilds a year ago. :)
Comment 8 Coacher 2012-11-27 13:24:20 UTC
(In reply to comment #7)
> How come /var/run was moved to a temporary filesystem without fixing all
> these bugs *beforehand*? For now, when a stable system gets updated with
> stable openrc-0.11.5, the latter moves /var/run to tmpfs and the affected
> daemons suddenly stop working after reboot.
+1 for this rant. Not even single warning was given.
Comment 9 Jeroen Roovers (RETIRED) gentoo-dev 2012-11-27 15:15:46 UTC
(In reply to comment #0)
> This bug report is a tracker for the specific flaws in affected packages -
> DO NOT COMMENT on this bug report, and file blocking bug reports for each
> affected package.

...
Comment 10 Thomas Capricelli 2012-12-06 19:10:08 UTC
i add myself to the rant list... lot of daemons are broken on several servers here now, most of them stable
I have to manually edit/fix init.d files. What a mess...
Comment 11 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2012-12-13 19:22:30 UTC
If I find the time for I gonna start fixing all remaining bugs next weekend.
Comment 12 Jeroen Roovers (RETIRED) gentoo-dev 2012-12-25 23:17:20 UTC
Created attachment 333358 [details]
packages for which no bug has been filed yet
Comment 13 Jeroen Roovers (RETIRED) gentoo-dev 2014-09-26 10:06:48 UTC
*** Bug 523772 has been marked as a duplicate of this bug. ***
Comment 14 Dries Kimpe 2015-02-04 21:58:44 UTC
Depends on: 538848
Comment 15 Patrice Clement gentoo-dev 2016-10-15 14:53:04 UTC
commit 2bfe6e3f45c9c3a26b44bdceaff67839504a19de (HEAD -> master, origin/master, origin/HEAD)
Author:     Bertrand Jacquin <bertrand@jacquin.bzh>
AuthorDate: Wed Oct 5 22:10:17 2016 +0100
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: Sat Oct 15 16:52:33 2016 +0200

net-proxy/haproxy: major improvements.

* Move to /run.
* Remove commented USE_LINUX_SPLICE since declaration is implicit.
* Remove commented USE_LINUX_TPROXY since declaration is implicit.
* Keep lua for live ebuild.

Gentoo-Bug: https://bugs.gentoo.org/332633

Package-Manager: portage-2.3.0
Closes: https://github.com/gentoo/gentoo/pull/2486
Signed-off-by: Patrice Clement <monsieurp@gentoo.org>

net-proxy/haproxy/files/haproxy.confd    |  4 ++--
net-proxy/haproxy/files/haproxy.initd-r2 |  4 ++--
net-proxy/haproxy/files/haproxy.initd-r3 |  4 ++--
net-proxy/haproxy/haproxy-1.6.9.ebuild   | 11 +----------
net-proxy/haproxy/haproxy-9999.ebuild    |  4 ----
5 files changed, 7 insertions(+), 20 deletions(-)

Merged, thanks!
Comment 16 Andreas K. Hüttel archtester gentoo-dev 2016-12-28 15:09:44 UTC
(In reply to Patrice Clement from comment #15)
> commit 2bfe6e3f45c9c3a26b44bdceaff67839504a19de (HEAD -> master,
> origin/master, origin/HEAD)

Reopening the tracker.
Comment 17 Mike Gilbert gentoo-dev 2019-05-08 03:10:31 UTC
Removing blockers that are have nothing to do with installing things in /var/run at install time.
Comment 18 Mike Gilbert gentoo-dev 2021-12-30 16:14:52 UTC
Adjusting the summary to reduce confusion.

This bug was created to track improper usage of keepdir. Other scenarios should be tracked separately.