Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 445694 - app-admin/sagan incorrectly handles /var/run removal
Summary: app-admin/sagan incorrectly handles /var/run removal
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Andreis Vinogradovs ( slepnoga )
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: keepdir-var-run_lock
  Show dependency tree
 
Reported: 2012-12-02 20:00 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2012-12-28 09:01 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2012-12-02 20:00:54 UTC
Let's see:

 * the ebuild has a keepdir to /run (replaced from /var/run); this is more than just broken, it's also stupid to do; a keepdir to /var/run at least works with the old setup, but keepdir on /run (which is designed to be tmpfs-mounted) is simply a stupid way to handle it;
 * the ebuild creates a fifo in /run — that'll never work!
 * the init script still uses /var/run/sagan (despite what the ebuild does);
 * there is no checkpath for /var/run/sagan at all.
Comment 1 Alexander Vershilov (RETIRED) gentoo-dev 2012-12-25 19:11:24 UTC
Will using tmpfilesd files sufficient for handling fifos creation?
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2012-12-25 19:15:27 UTC
I don't think OpenRC implements it.

`man runscript` and see for checkpath, and get the init script to take care of it.
Comment 3 Alexander Vershilov (RETIRED) gentoo-dev 2012-12-25 20:03:56 UTC
AFAIK openrc implements tmpfilesd. Anyway I've fixed init script and revbumped sagan.

Should I add same fixes to older versions? It seems that they will work out of the box as init script is common for all ebuilds.
Comment 4 Andreis Vinogradovs ( slepnoga ) 2012-12-28 09:01:41 UTC
Fix in CVS