Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 59671 - mozilla-firefox removes searchplugins
Summary: mozilla-firefox removes searchplugins
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
: 82784 96733 142656 149214 (view as bug list)
Depends on: 52138
Blocks:
  Show dependency tree
 
Reported: 2004-08-07 00:52 UTC by Benjamin Hanzelmann
Modified: 2006-11-04 03:43 UTC (History)
10 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for nsplugins.eclass (nsplugin.patch,1.41 KB, patch)
2004-08-07 06:24 UTC, Mårten Svantesson
Details | Diff
Example patch for mozilla-firefox-bin-0.9.3.ebuild (firefox.patch,793 bytes, patch)
2004-08-07 06:26 UTC, Mårten Svantesson
Details | Diff
patch rejection (nsInternetSearchService.cpp.rej,3.35 KB, text/plain)
2005-07-24 02:15 UTC, Jory A. Pratt
Details
After all patches from -r3 (nsInternetSearchService.cpp,188.51 KB, text/plain)
2005-07-24 02:19 UTC, Jory A. Pratt
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Hanzelmann 2004-08-07 00:52:58 UTC
Hi,

the ebuild should not just remove the searchplugins-folder. That is very annoying when you write some of them yourself... ;)



Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Mårten Svantesson 2004-08-07 06:24:30 UTC
Created attachment 36945 [details, diff]
Patch for nsplugins.eclass

The reasonable way should be to handle search plug-ins in the same way as
plug-ins. That is adding functions to nsplugins.eclass and then use them in
all mozilla and firefox ebuilds.
Comment 2 Mårten Svantesson 2004-08-07 06:26:18 UTC
Created attachment 36946 [details, diff]
Example patch for mozilla-firefox-bin-0.9.3.ebuild

Example patch for mozilla-firefox-bin-0.9.3.ebuild using my patch
nsplugins.eclass
Comment 3 SpanKY gentoo-dev 2004-09-16 19:52:01 UTC
this seems pretty trivial and like the original reporter said, this is pretty frickin annoying especially after you've written some custom engines and spent time downloading all the ones you want ...
Comment 4 Lars Weiler (RETIRED) gentoo-dev 2005-04-18 16:28:13 UTC
*** Bug 82784 has been marked as a duplicate of this bug. ***
Comment 5 SpanKY gentoo-dev 2005-04-18 17:04:16 UTC
for anyone else who cares, the workaround i use locally is `chattr +i <search plugins i dont want deleted>` and it works nicely
Comment 6 Lars Weiler (RETIRED) gentoo-dev 2005-04-19 17:20:34 UTC
As you said, it's a workaround.  That's good for experienced users, but usually the ebuild should take care of it.

Does somebody of the mozilla team know, if there is any work on integrating the searchplugins into the user's homedirectory, like with extensions or plugins?
Comment 7 SpanKY gentoo-dev 2005-06-21 15:15:33 UTC
*** Bug 96733 has been marked as a duplicate of this bug. ***
Comment 8 TGL 2005-06-21 15:52:31 UTC
Sorry for the dup, i made my query on normal and above. 

Btw, why is this at enhancement level? This issue is about blindly deleting some
shared config & data files that are not owned by the package, that's obviously a
real bug, and a pretty bad one imo.
Comment 9 Jakub Moc (RETIRED) gentoo-dev 2005-06-21 19:31:48 UTC
(In reply to comment #8)
> Btw, why is this at enhancement level? This issue is about blindly deleting some
> shared config & data files that are not owned by the package, that's obviously a
> real bug, and a pretty bad one imo.

Yeah, this is definitely not enhancement... 
Comment 10 TGL 2005-06-21 23:43:35 UTC
(In reply to comment #6)

> Does somebody of the mozilla team know, if there is any work on 
> integrating the searchplugins into the user's homedirectory, like
> with extensions or plugins?

Yup, here it is:
https://bugzilla.mozilla.org/show_bug.cgi?id=123315
There's a patch to test, and from what i understood it's planned for 1.1
(although more features like having an UI to manage plugins is more for 2.0).
Comment 11 Andreas Kotowicz 2005-07-24 01:48:27 UTC
Is there any chance to get the final mozilla.org patch on this issue applied
against firefox 1.0.6? (see comment #10 for link)
Comment 12 Jory A. Pratt 2005-07-24 02:00:15 UTC
I will check on this sometime later today I have already commited -r3 for
epiphany compilation against firefox.
Comment 13 Jory A. Pratt 2005-07-24 02:08:33 UTC
alright if someone would like to take the time to rediff the patch from upstream
I will be more then happy to add it. I do not have time to rediff it myself sorry.
Comment 14 Jory A. Pratt 2005-07-24 02:15:16 UTC
Created attachment 64180 [details]
patch rejection

This is the rejection of the patch.
Comment 15 Jory A. Pratt 2005-07-24 02:19:10 UTC
Created attachment 64181 [details]
After all patches from -r3

This is what we are working with for patching breakage. Once the rediff is
corrected so to apply clean against this file we will be ready to add to
ebuild.
Comment 17 Leonid Podolny 2005-10-01 22:52:41 UTC
Still happens, i.e. just happened during upgrade from mozilla-firefox-bin-1.0.6
to mozilla-firefox-bin-1.0.7.
Comment 18 Leonid Podolny 2005-10-01 22:53:18 UTC
Still happens, i.e. just happened during upgrade from mozilla-firefox-bin-1.0.6
to mozilla-firefox-bin-1.0.7.
Comment 19 Christian Marie (RETIRED) gentoo-dev 2006-08-01 05:39:03 UTC
This has been fixed upstream, starting from 1.5 search plugins get stored in thier home. It definately works with current (www-client/mozilla-firefox-1.5.0.5).
Comment 20 Jakub Moc (RETIRED) gentoo-dev 2006-08-03 11:49:36 UTC
*** Bug 142656 has been marked as a duplicate of this bug. ***
Comment 21 SpanKY gentoo-dev 2006-08-04 08:56:55 UTC
that should cover most of this ... but then the opposite is true: firefox installs a bunch of shitty defaults that i dont ever want to see once i've removed them ...
Comment 22 Carsten Lohrke (RETIRED) gentoo-dev 2006-09-09 16:28:52 UTC
(In reply to comment #19)
> This has been fixed upstream, starting from 1.5 search plugins get stored in
> thier home. It definately works with current
> (www-client/mozilla-firefox-1.5.0.5).

This does not help a bit when your custom files you've explicitly placed in /usr/lib/mozilla-firefox/searchplugins/ still get deleted. Not a /that/ big issue, but the superfluous "update, restore plugins" job should not last forever.
Comment 23 Jakub Moc (RETIRED) gentoo-dev 2006-09-26 13:08:48 UTC
*** Bug 149214 has been marked as a duplicate of this bug. ***
Comment 24 SpanKY gentoo-dev 2006-11-04 03:43:53 UTC
firefox-2.0 handles this properly