Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bugzilla DB migration completed. Please report issues to Infra team via email via infra@gentoo.org or IRC
Bug 198901 - [TRACKER] Nuking logrotate use flag
Summary: [TRACKER] Nuking logrotate use flag
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Quality Assurance Team
URL:
Whiteboard:
Keywords: Tracker
Depends on: 258173 258174 258176 258178 258180 258181 258182 258186 258187 258188 344175 344181 344187
Blocks: 134491
  Show dependency tree
 
Reported: 2007-11-12 09:47 UTC by Jakub Moc (RETIRED)
Modified: 2015-12-04 11:42 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub Moc (RETIRED) gentoo-dev 2007-11-12 09:47:52 UTC
Basically same reasons as in Bug 158114 Comment #0 apply here... Having a use flag for installing one plaintext file doesn't make sense.

- ebuilds don't handle this consistently (some just use this flag for doins/newins a script to /etc/logrotate.d, some add app-admin/logrotate dependency, some install the scripts unconditionally)

- users can use INSTALL_MASK if diskspace is an issue for them (extremely unlikely), plus the installed scripts have no effect until you install logrotate anyway, so if you don't want this functionality, just don't install it, if you do, emerge alogrotate and you don't have to care about anything else and no need to re-emerge anything).

(BTW, the usage of this flag in net-proxy/squid really is special, don't quite understand why not just use the rotate functionality squid itself has.)

So, please nuke the use flag and install the stuff unconditionally. Thanks 

app-antivirus/clamav-0.91
app-antivirus/clamav-0.91.1
app-antivirus/clamav-0.91.2
app-antivirus/clamav-0.92_rc2

app-backup/bacula-2.0.3
app-backup/bacula-2.2.4
app-backup/bacula-2.2.5
app-backup/bacula-2.2.5-r1

mail-filter/dspam-3.8.0-r6

mail-filter/spamassassin-fuzzyocr-3.5.1
mail-filter/spamassassin-fuzzyocr-3.5.1-r1

net-ftp/vsftpd-2.0.5-r3

net-mail/mailgraph-1.13
net-mail/mailgraph-1.14

net-proxy/squid-2.6.16
net-proxy/squid-3.0_rc1

sys-apps/qingy-0.9.6-r1

sys-cluster/vzctl-3.0.14
sys-cluster/vzctl-3.0.16
sys-cluster/vzctl-3.0.18
sys-cluster/vzctl-3.0.18-r1

sys-power/acpid-1.0.4-r5

sys-power/hibernate-script-1.95-r2
sys-power/hibernate-script-1.95-r3
sys-power/hibernate-script-1.96
sys-power/hibernate-script-1.96-r1
sys-power/hibernate-script-1.97-r1

www-servers/ocsigen-0.99.2
www-servers/ocsigen-0.99.3
Comment 1 Alin Năstac (RETIRED) gentoo-dev 2007-11-12 10:13:51 UTC
Let me reiterate my position on squid's logrotate flag. This flag selects the mode in which log rotation is performed: 
  1) native log rotation support (a cron script that calls squid -k rotate)
  2) through logrotate program
I don't see how this could be done in any other way than having a USE flag for it.

mail-filter/dspam-3.8.0-r6 has been removed (-r7 no longer has logrotate USE flag).
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2007-11-12 10:25:54 UTC
(In reply to comment #1)

Thanks for clarifying. This bug is about nuking the flag in ebuilds where it does nothing else but installing a logrotate script (and adding a optional dependency). The squid usage looks perfectly valid.
Comment 3 Alon Bar-Lev gentoo-dev 2007-11-12 10:42:14 UTC
hibernate-script done.
Comment 4 Alexis Ballier gentoo-dev 2007-11-12 12:58:20 UTC
ocsigen done
Comment 5 Andrej Kacian (RETIRED) gentoo-dev 2007-11-14 19:35:12 UTC
clamav and mailgraph done.

The flag usage in spamassassin-fuzzyocr is a bit less trivial, as it also decides on whether to enable logging, so I will leave it to maintainers (tomk + chutzpah) to modify this package.
Comment 6 Łukasz Damentko (RETIRED) gentoo-dev 2008-10-30 16:46:43 UTC
Reassigning since Jakub has left Gentoo.
Comment 7 Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2009-02-08 18:23:12 UTC
reworking this into a TRACKER bug. individual bugs are being filed. removing everybody from CC - please re-add yourself if you want to.

thanks
Comment 8 Samuli Suominen gentoo-dev 2010-05-07 12:00:56 UTC
All the bugs are here closed, bug the issue is not solved:

local use flags (searching: logrotate)
************************************************************
[-    ] logrotate (app-backup/bacula):
Install support files for logrotate

[-    ] logrotate (mail-filter/spamassassin-fuzzyocr):
Install support files for app-admin/logrotate

[-    ] logrotate (net-misc/iaxmodem):
Install support files for app-admin/logrotate

[-    ] logrotate (net-proxy/squid):
Use app-admin/logrotate for rotating logs

[-    ] logrotate (sys-process/acct):
Install a logrotate script to rotate /var/account/*
Comment 9 Jeroen Roovers gentoo-dev 2010-11-04 19:08:51 UTC
(In reply to comment #8)
> [-    ] logrotate (sys-process/acct):
> Install a logrotate script to rotate /var/account/*
> 

  10 Jun 2010; Jeroen Roovers <jer@gentoo.org> acct-6.5.4-r1.ebuild,
  metadata.xml:
  Remove IUSE=logrotate (bug #198901).

Comment 10 Jeroen Roovers gentoo-dev 2010-11-04 19:13:48 UTC
(In reply to comment #8)
> [-    ] logrotate (net-misc/iaxmodem):
> Install support files for app-admin/logrotate

  07 May 2010; Stefan Briesenick <sbriesen@gentoo.org>
  iaxmodem-1.2.0.ebuild:
  installing logrotate stuff unconditionally, solving bug #258178.

> [-    ] logrotate (net-proxy/squid):
> Use app-admin/logrotate for rotating logs

Genuine use, see other comments on this bug report.
Comment 11 Sergiy Borodych 2015-12-04 11:42:38 UTC
Is it still a proper way for ebuilds?
To remove the flag from all places.