Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 344187 - mail-filter/spamassassin-fuzzyocr - Invalid IUSE=logrotate
Summary: mail-filter/spamassassin-fuzzyocr - Invalid IUSE=logrotate
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: Patrick McLean
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 198901
  Show dependency tree
 
Reported: 2010-11-04 19:45 UTC by Jeroen Roovers (RETIRED)
Modified: 2014-11-29 00:20 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeroen Roovers (RETIRED) gentoo-dev 2010-11-04 19:45:52 UTC
* This should not be needed unless the software actually uses logrotate, which
  isn't common at all:

    logrotate?  ( app-admin/logrotate )


* This looks tricky:

    # create fuzzyocr group for logging and hashing
    if use dbm || use logrotate ; then
        use amavis || enewgroup fuzzyocr
    fi

  Why don't you simply always support logging? The user would need to re-
  emerge the package simply to get logging working? Precisely what bug #198901
  is about!


* So you're not going to support logging stuff unless logrotate is installed?

        # Enable logfile if logrotate
        if use logrotate ; then

  Why don't you simply let the user decide, regardless of USE flags?


* Can't you use `chmod g+s' on the directory? Doesn't the software create the
  file when it needs it?

            if [ ! -e /var/log/FuzzyOcr.log ]; then
                insinto /var/log
                newins /dev/null FuzzyOcr.log
                if use amavis ;  then
                    fperms 600 /var/log/FuzzyOcr.log
                    fowners amavis:amavis /var/log/FuzzyOcr.log
                else
                    fperms 660 /var/log/FuzzyOcr.log
                    fowners root:fuzzyocr /var/log/FuzzyOcr.log
                fi
            fi

* Install this unconditionally:

            dodir /etc/logrotate.d
            insopts -m0644
            insinto /etc/logrotate.d
            newins "${FILESDIR}"/fuzzyocr.logrotate FuzzyOcr
Comment 1 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2014-05-10 12:42:33 UTC
Maintainers, can you please (re)consider to fix this bug? Or can QA team fix it?
Comment 2 Andreas K. Hüttel gentoo-dev 2014-10-27 22:27:36 UTC
Masked for removal
Comment 3 Andreas K. Hüttel gentoo-dev 2014-11-29 00:20:41 UTC
Package removed