Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 839405 - app-editors/emacs: Scrutinise CFLAGS manipulation
Summary: app-editors/emacs: Scrutinise CFLAGS manipulation
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: GNU Emacs project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-19 10:33 UTC by Ulrich Müller
Modified: 2022-06-26 07:07 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2022-04-19 10:33:47 UTC
strip-flags was added for bug 64362 in 2004, replace-flags and filter-flags later.

Suggested plan: Drop flag-o-matic.eclass from live ebuilds and port to other ebuilds later.
Comment 1 Larry the Git Cow gentoo-dev 2022-04-20 12:25:28 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c4c1e3895b04e46c97682d74653d75f9110346af

commit c4c1e3895b04e46c97682d74653d75f9110346af
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2022-04-20 12:24:24 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2022-04-20 12:24:24 +0000

    app-editors/emacs: Leave CFLAGS alone in live ebuilds
    
    Bug: https://bugs.gentoo.org/839405
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 app-editors/emacs/emacs-28.1.9999.ebuild | 11 +----------
 app-editors/emacs/emacs-29.0.9999.ebuild | 11 +----------
 2 files changed, 2 insertions(+), 20 deletions(-)
Comment 2 Ulrich Müller gentoo-dev 2022-04-21 08:31:42 UTC
Either someone needs to go through all linked bugs and check if they are still an issue, or we simply drop all flag handling (I'd go for all versions using the portable dumper, i.e. 27 onwards) and keep fingers crossed.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-04-21 12:01:44 UTC
My preference as an Odd Platform person is to just do this for 27+ or even 28+ and not worry about older versions. It's not like bug reports for older versions will be easy to fix or handle anyway.
Comment 4 Maciej Barć gentoo-dev 2022-04-21 15:17:19 UTC
(In reply to Sam James from comment #3)
> My preference as an Odd Platform person is to just do this for 27+ or even
> 28+ and not worry about older versions. It's not like bug reports for older
> versions will be easy to fix or handle anyway.

I think Sam is right.
In my opinion we should do it for 27+.
Comment 5 Ulrich Müller gentoo-dev 2022-04-21 17:51:16 UTC
Still, the question is if those bugs will resurface in the newer version. I wouldn't touch versions older than 27 in any case.
Comment 6 Larry the Git Cow gentoo-dev 2022-06-07 06:44:45 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4ca8019087aab182e0f3f1211f235f128d537b8a

commit 4ca8019087aab182e0f3f1211f235f128d537b8a
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2022-06-07 06:42:26 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2022-06-07 06:44:33 +0000

    app-editors/emacs: Leave CFLAGS alone in Emacs 27 and newer
    
    Closes: https://bugs.gentoo.org/839405
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 app-editors/emacs/emacs-27.2-r5.ebuild | 11 +----------
 app-editors/emacs/emacs-28.1.ebuild    | 11 +----------
 2 files changed, 2 insertions(+), 20 deletions(-)
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-06-07 06:48:49 UTC
(In reply to Ulrich Müller from comment #5)
> Still, the question is if those bugs will resurface in the newer version. I
> wouldn't touch versions older than 27 in any case.

I think we've just to got to see & find out what happens. If they do, we may want to handle them quite differently anyway.