strip-flags was added for bug 64362 in 2004, replace-flags and filter-flags later. Suggested plan: Drop flag-o-matic.eclass from live ebuilds and port to other ebuilds later.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c4c1e3895b04e46c97682d74653d75f9110346af commit c4c1e3895b04e46c97682d74653d75f9110346af Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2022-04-20 12:24:24 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2022-04-20 12:24:24 +0000 app-editors/emacs: Leave CFLAGS alone in live ebuilds Bug: https://bugs.gentoo.org/839405 Signed-off-by: Ulrich Müller <ulm@gentoo.org> app-editors/emacs/emacs-28.1.9999.ebuild | 11 +---------- app-editors/emacs/emacs-29.0.9999.ebuild | 11 +---------- 2 files changed, 2 insertions(+), 20 deletions(-)
Either someone needs to go through all linked bugs and check if they are still an issue, or we simply drop all flag handling (I'd go for all versions using the portable dumper, i.e. 27 onwards) and keep fingers crossed.
My preference as an Odd Platform person is to just do this for 27+ or even 28+ and not worry about older versions. It's not like bug reports for older versions will be easy to fix or handle anyway.
(In reply to Sam James from comment #3) > My preference as an Odd Platform person is to just do this for 27+ or even > 28+ and not worry about older versions. It's not like bug reports for older > versions will be easy to fix or handle anyway. I think Sam is right. In my opinion we should do it for 27+.
Still, the question is if those bugs will resurface in the newer version. I wouldn't touch versions older than 27 in any case.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4ca8019087aab182e0f3f1211f235f128d537b8a commit 4ca8019087aab182e0f3f1211f235f128d537b8a Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2022-06-07 06:42:26 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2022-06-07 06:44:33 +0000 app-editors/emacs: Leave CFLAGS alone in Emacs 27 and newer Closes: https://bugs.gentoo.org/839405 Signed-off-by: Ulrich Müller <ulm@gentoo.org> app-editors/emacs/emacs-27.2-r5.ebuild | 11 +---------- app-editors/emacs/emacs-28.1.ebuild | 11 +---------- 2 files changed, 2 insertions(+), 20 deletions(-)
(In reply to Ulrich Müller from comment #5) > Still, the question is if those bugs will resurface in the newer version. I > wouldn't touch versions older than 27 in any case. I think we've just to got to see & find out what happens. If they do, we may want to handle them quite differently anyway.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=897831538c5699aa4dcfe53e85f01fb6a913430d commit 897831538c5699aa4dcfe53e85f01fb6a913430d Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2024-10-10 17:31:51 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2024-10-24 09:34:24 +0000 app-editors/emacs: Restore replacing -O[3-9] by -O2 in CFLAGS This partially reverts commit 4ca8019087aab182e0f3f1211f235f128d537b8a. Bug: https://bugs.gentoo.org/839405 Closes: https://bugs.gentoo.org/941225 Signed-off-by: Ulrich Müller <ulm@gentoo.org> app-editors/emacs/emacs-26.3-r19.ebuild | 3 ++- app-editors/emacs/emacs-27.2-r17.ebuild | 4 +++- app-editors/emacs/emacs-28.2-r13.ebuild | 4 +++- app-editors/emacs/emacs-29.4.ebuild | 4 +++- app-editors/emacs/emacs-30.0.91.ebuild | 4 +++- app-editors/emacs/emacs-30.0.9999-r1.ebuild | 4 +++- app-editors/emacs/emacs-31.0.9999.ebuild | 4 +++- 7 files changed, 20 insertions(+), 7 deletions(-)
