Created attachment 286949 [details] garble-png.patch CXX abiword-garble-png.o abiword-garble-png.cpp: In member function ‘bool abiword_document::garble_png(void*&, size_t&)’: abiword-garble-png.cpp:82:22: error: invalid use of incomplete type ‘struct png_info’ /usr/include/libpng15/png.h:696:16: error: forward declaration of ‘struct png_info’ make[4]: *** [abiword-garble-png.lo] Error 1 make[3]: *** [all-recursive] Error 1 make[2]: *** [all-recursive] Error 1 make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2 From png.h: /* The complete definition of png_info has, as of libpng-1.5.0, * been moved into a separate header file that is not accessible to * applications. Read libpng-manual.txt or libpng.3 for more info. */
Patch attached.
Created attachment 286951 [details, diff] garble-png.patch
Looks like the patch for bug 356287 wasn't enough then ... I guess this can be triggered by some USE flag combination I didn't test.
(In reply to comment #3) > Looks like the patch for bug 356287 wasn't enough then ... I guess this can be > triggered by some USE flag combination I didn't test. I have the same problem and my useflags are: [ebuild R ] app-office/abiword-2.8.6-r1 USE="cups grammar latex math openxml ots plugins readline spell thesaurus wmf wordperfect -collab -debug -gnome"
(In reply to comment #2) > Created attachment 286951 [details, diff] > garble-png.patch Where did you find this patch? Did you contact upstream about that?
My error is similar enough to be related: CXX abiword-garble-png.o abiword-garble.cpp: In destructor ‘abiword_document::~abiword_document()’: abiword-garble.cpp:90:54: warning: format ‘%u’ expects type ‘unsigned int’, but argument 3 has type ‘size_t’ abiword-garble.cpp:92:53: warning: format ‘%u’ expects type ‘unsigned int’, but argument 3 has type ‘size_t’ abiword-garble-png.cpp: In member function ‘bool abiword_document::garble_png(void*&, size_t&)’: abiword-garble-png.cpp:82:22: error: invalid use of incomplete type ‘struct png_info’ /usr/include/libpng15/png.h:696:16: error: forward declaration of ‘struct png_info’ make[4]: *** [abiword-garble-png.lo] Error 1 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [all-recursive] Error 1 make[2]: *** [all-recursive] Error 1 make[1]: *** [all-recursive] Error 1 make: *** [all] Error 2 emake failed Use flags are: USE="collab cups plugins readline spell thesaurus -debug -gnome -grammar -latex -math -openxml -ots -wmf -wordperfect"
(In reply to comment #5) > (In reply to comment #2) > > Created attachment 286951 [details, diff] > > garble-png.patch > Where did you find this patch? Did you contact upstream about that? Wrote it myself. Haven't got round to upstreaming it yet;I'll do that when I'm back at a proper computer:)
Created attachment 287245 [details] build.log The proposed patch does not seem to work
I think we are missing the following patches from netbsd to work with libpng-1.5... but I am still using png-1.4 and, then, cannot test if they fix all issues. http://cvsweb.se.netbsd.org/cgi-bin/bsdweb.cgi/pkgsrc/editors/abiword/patches/patch-plugins_bmp_xp_ie__impGraphic__BMP.cpp?rev=1.1;content-type=text%2Fplain http://cvsweb.se.netbsd.org/cgi-bin/bsdweb.cgi/pkgsrc/editors/abiword/patches/patch-plugins_garble_xp_abiword-garble-png.cpp?rev=1.1;content-type=text%2Fplain
(In reply to comment #9) > I think we are missing the following patches from netbsd to work with > libpng-1.5... but I am still using png-1.4 and, then, cannot test if they fix > all issues. > > http://cvsweb.se.netbsd.org/cgi-bin/bsdweb.cgi/pkgsrc/editors/abiword/patches/patch-plugins_bmp_xp_ie__impGraphic__BMP.cpp?rev=1.1;content-type=text%2Fplain > http://cvsweb.se.netbsd.org/cgi-bin/bsdweb.cgi/pkgsrc/editors/abiword/patches/patch-plugins_garble_xp_abiword-garble-png.cpp?rev=1.1;content-type=text%2Fplain I get the exact same build failure when using the netbsd patches.
Created attachment 287339 [details, diff] correct patch Could someone please test this patch? I can't test it because I hit bug #367865. If someone manages to compile it let me know and I will commit it. Maybe it is time to close both bugs at once though
(In reply to comment #11) > Created attachment 287339 [details, diff] > correct patch > > Could someone please test this patch? I can't test it because I hit bug > #367865. If someone manages to compile it let me know and I will commit it. > Maybe it is time to close both bugs at once though It solved the problem for me.
(In reply to comment #11) > Created attachment 287339 [details, diff] > correct patch > > Could someone please test this patch? I can't test it because I hit bug > #367865. If someone manages to compile it let me know and I will commit it. > Maybe it is time to close both bugs at once though Markos, feel free to commit and fix both (I am trying upstream to release a fixed 2.8.x version for weeks without success :( )
+ 23 Sep 2011; Lars Wendler <polynomial-c@gentoo.org> + files/abiword-2.8.6-libpng15.patch: + non-maintainer commit: Added fixed patch to build with libpng15 (bug + #383567). +
Still failing for me with: Making all in xp CXX AiksaurusABI.o LINK libxp.la LINK aiksaurus.la /usr/lib/gcc/x86_64-pc-linux-gnu/4.5.3/../../../../x86_64-pc-linux-gnu/bin/ld: cannot find -lpng14 collect2: ld returned 1 exit status make[4]: *** [aiksaurus.la] Error 1 make[3]: *** [all-recursive] Error 1 make[2]: *** [all-recursive] Error 1 make[1]: *** [all-recursive] Error 1
(In reply to comment #15) > Still failing for me with: > > Making all in xp > CXX AiksaurusABI.o > LINK libxp.la > LINK aiksaurus.la > /usr/lib/gcc/x86_64-pc-linux-gnu/4.5.3/../../../../x86_64-pc-linux-gnu/bin/ld: > cannot find -lpng14 > collect2: ld returned 1 exit status > make[4]: *** [aiksaurus.la] Error 1 > make[3]: *** [all-recursive] Error 1 > make[2]: *** [all-recursive] Error 1 > make[1]: *** [all-recursive] Error 1 This is a different sort of problem. emerge lafilefixer and run lafilefixer --justfixit. Consult bug #319101
(In reply to comment #16) > (In reply to comment #15) > > Still failing for me with: > > > > Making all in xp > > CXX AiksaurusABI.o > > LINK libxp.la > > LINK aiksaurus.la > > /usr/lib/gcc/x86_64-pc-linux-gnu/4.5.3/../../../../x86_64-pc-linux-gnu/bin/ld: > > cannot find -lpng14 > > collect2: ld returned 1 exit status > > make[4]: *** [aiksaurus.la] Error 1 > > make[3]: *** [all-recursive] Error 1 > > make[2]: *** [all-recursive] Error 1 > > make[1]: *** [all-recursive] Error 1 > > This is a different sort of problem. emerge lafilefixer and run lafilefixer > --justfixit. Consult bug #319101 Thank you! lafilefixer --justfixit did NOT do anything but the script from bug #319101 rebuilt those 2 packages : app-text/aiksaurus-1.2.1 media-libs/libexif-gtk-0.3.5-r2 and after that abiword emerged just fine :) the actual script: emerge -a1 --keep-going $(find /usr/lib* /lib* -name '*.la' -print0 \ | xargs -0 grep -l png14 | while read f; do qfile -C -v "$f" \ | awk '{print $1}'; done | sort -u | sed 's:^:=:')
(In reply to comment #17) [...] > the actual script: > > emerge -a1 --keep-going $(find /usr/lib* /lib* -name '*.la' -print0 \ > | xargs -0 grep -l png14 | while read f; do qfile -C -v "$f" \ | awk '{print > $1}'; done | sort -u | sed 's:^:=:') Samuli, could this script be suggested in some way (elog message or news item) when updating to libpng-1.5? Looks like it's not obvious to manually check for broken .la files as I can see from similar bug reports that need this to be run Thanks
