Bug 367865 – app-office/abiword fails to build with gcc 4.6

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Diego Elio Pettenò (RETIRED) 2011-05-18 01:18:45 UTC]

Created attachment 273769 [details]
Build log

Portage 2.1.9.49 (default/linux/x86/10.0, gcc-4.6.0-asneeded, glibc-2.13-r2, 2.6.38.6 i686)
=================================================================
System uname: Linux-2.6.38.6-i686-Quad-Core_AMD_Opteron-tm-_Processor_2350-with-gentoo-2.0.2
Timestamp of tree: Sat, 14 May 2011 21:00:01 +0000
app-shells/bash:          4.2_p10
dev-java/java-config:     2.1.11-r3
dev-lang/python:          2.7.1-r1, 3.1.3-r1
dev-util/cmake:           2.8.4-r1
sys-apps/baselayout:      2.0.2
sys-apps/openrc:          0.8.2-r1
sys-apps/sandbox:         2.5
sys-devel/autoconf:       2.68
sys-devel/automake:       1.9.6-r3, 1.10.3, 1.11.1-r1
sys-devel/binutils:       2.21.51.0.9
sys-devel/gcc:            4.6.0
sys-devel/gcc-config:     1.4.1-r1
sys-devel/libtool:        2.4-r1
sys-devel/make:           3.82
sys-kernel/linux-headers: 2.6.38 (virtual/os-headers)
sys-libs/glibc:           2.13-r2
ACCEPT_KEYWORDS="x86 ~x86"
ACCEPT_LICENSE="*"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib/tomoyo/conf /usr/share/bufrtables /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/maven-bin-3.0/conf /usr/share/openvpn/easy-rsa /usr/share/qpsmtpd/plugins /var/lib/hsqldb /var/phxd /var/qmail/alias /var/qmail/control /var/yp/Makefile"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/games/angband/edit/ /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.3/ext-active/ /etc/php/apache2-php5.4/ext-active/ /etc/php/cgi-php5.3/ext-active/ /etc/php/cgi-php5.4/ext-active/ /etc/php/cli-php5.3/ext-active/ /etc/php/cli-php5.4/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe"
DISTDIR="/var/cache/portage/distfiles"
FEATURES="assume-digests binpkg-logs distlocks fixlafiles fixpackages news parallel-fetch protect-owned sandbox sfperms split-log strict test test-fail-continue unknown-features-warn unmerge-orphans userfetch userpriv usersandbox"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://gentoo.wheel.sk/"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu"
MAKEOPTS="-j14"
PKGDIR="/var/spool/portage/packages"
PORTAGE_COMPRESS=""
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/var/cache/portage/tree"
PORTDIR_OVERLAY=""
SYNC="rsync://yamato.home.flameeyes.eu/gentoo-portage"
USE="acl berkdb bzip2 cli cracklib crypt cups cxx dri fortran gdbm gpm iconv ipv6 java5 java6 modules mudflap mysql ncurses nls nostatic nptl nptlonly openmp pam pcre pcsc-lite perl postgres pppd python qt3support readline ruby session ssl sysfs tcpd unicode vhosts x86 xorg zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias auth_digest cgi" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" PHP_TARGETS="php5-3" RUBY_TARGETS="ruby18 jruby ruby19 ree18" USERLAND="GNU" VIDEO_CARDS="intel radeon nouveau vmware" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

[Comment 1 Andrew John Hughes 2011-05-20 01:17:29 UTC]

Created attachment 274037 [details, diff]
Patch

Patch which allows gcc 4.6 to compile abiword.

[Comment 2 Luis Medinas 2011-06-26 00:41:02 UTC]

(In reply to comment #1)
> Created attachment 274037 [details, diff]
> Patch
> 
> Patch which allows gcc 4.6 to compile abiword.

Submit upstream please ?

[Comment 3 Rafał Mużyło 2011-07-18 16:00:45 UTC]

(In reply to comment #1)
> Created attachment 274037 [details, diff]
> Patch
> 
> Patch which allows gcc 4.6 to compile abiword.

Upstream will never take such patch, as it's obviously invalid.
It seems the correct patch would just change '--no-undefined' to '-no-undefined'.

[Comment 4 Pacho Ramos 2011-07-18 16:25:25 UTC]

Looks like using -Wl is the way to go per:
http://bugzilla.abisource.com/show_bug.cgi?id=13066
http://www.mail-archive.com/[e-mail]/msg12641.html

[Comment 5 Rafał Mużyło 2011-07-18 18:47:48 UTC]

(In reply to comment #4)
> Looks like using -Wl is the way to go per:
> http://bugzilla.abisource.com/show_bug.cgi?id=13066
> http://www.mail-archive.com/[e-mail]/msg12641.html

The upstream patch is wrong (in a way) and the mailing list thread is off-topic, unless you count either first reply in the thread or immediate reply to that post.

See the relevant libtool info page section.

[Comment 6 Pacho Ramos 2011-09-14 10:38:32 UTC]

gcc-porting team, what patch looks ok for you?

[Comment 7 Diego Elio Pettenò (RETIRED) 2011-09-14 10:43:08 UTC]

Andrew's is (mostly) correct, if you don't count the mangling of Makefile.in and the fact that both -export-dynamic and -avoid-version look wrong for this..

[Comment 8 Pacho Ramos 2011-09-14 10:54:42 UTC]

opensuse patch is a bit different:
diff -ur abiword-2.8.6/src/Makefile.am abiword-2.8.6.patched//src/Makefile.am
--- abiword-2.8.6/src/Makefile.am       2009-09-09 15:11:01.000000000 +0200
+++ abiword-2.8.6.patched//src/Makefile.am      2011-05-16 10:12:55.378621418 +0200
@@ -44,7 +44,7 @@
 
 libabiword_2_8_la_LDFLAGS = \
        $(DEPS_LIBS) \
-       --no-undefined \
+       -Wl,--no-undefined \
        -avoid-version \
        -export-dynamic
 
@@ -107,7 +107,7 @@
 
 AbiWord_LDFLAGS = \
        $(DEPS_LIBS) \
-       --no-undefined \
+       -Wl,--no-undefined \
        -avoid-version \
        -export-dynamic \
        -headerpad_max_install_names 
@@ -129,7 +129,7 @@
 
 abiword_LDFLAGS = \
        $(platform_ldflags) \
-       --no-undefined      \
+       -Wl,--no-undefined      \
        -avoid-version      \
        -export-dynamic
 
(I have dropped its Makefile.in part as we would only patch Makefile.am and run eautoreconf...)

[Comment 9 Diego Elio Pettenò (RETIRED) 2011-09-14 11:03:53 UTC]

That works as well

[Comment 10 Ryan Hill (RETIRED) 2011-09-16 03:21:22 UTC]

That looks fine, but Diego knows more about this than I.  Thanks for looking at this.

[Comment 11 Pacho Ramos 2011-09-23 12:24:53 UTC]

Created attachment 287503 [details]
build.log

It still fails with attached patch :S

[Comment 12 Pacho Ramos 2011-09-23 12:25:19 UTC]

Created attachment 287505 [details, diff]
abiword-2.8.6-gcc46.patch

[Comment 13 Pacho Ramos 2011-09-23 12:46:36 UTC]

Arch patch works

+  23 Sep 2011; Pacho Ramos <[e-mail]> abiword-2.8.6-r1.ebuild,
+  +files/abiword-2.8.6-gcc46.patch:
+  Use Arch patch to fix compilation with gcc-4.6 (bug #367865).
+