Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 272303 - media-gfx/gtkimageview: useless gnome-base/gnome-common DEPEND
Summary: media-gfx/gtkimageview: useless gnome-base/gnome-common DEPEND
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: Gentoo Graphics Project
URL:
Whiteboard:
Keywords: QAbaddep
Depends on:
Blocks: 272308
  Show dependency tree
 
Reported: 2009-06-02 17:47 UTC by Mounir Lamouri (volkmar) (RETIRED)
Modified: 2009-06-12 19:33 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mounir Lamouri (volkmar) (RETIRED) gentoo-dev 2009-06-02 17:47:38 UTC
I was able to build media-gfx/gtkimageview without gnome-base/gnome-common.
Ebuild from bug 192239 doesn't depend on gnome-base/gnome-common.
Comment 1 MT 2009-06-02 19:13:33 UTC
ebuild lacks also gnome2 eclass and eauto* calls as reported by repoman, see my ebuilds from 192239
Comment 2 Markus Meier gentoo-dev 2009-06-02 21:58:13 UTC
(In reply to comment #0)
well, the gnome-common dep is listed in the README of the package as required - I assumed that this is accurate... =/


(In reply to comment #1)
> ebuild lacks also gnome2 eclass and eauto* calls as reported by repoman, see my
> ebuilds from 192239

why is the gnome2 eclass needed here? (and eautoreconf call?)
Comment 3 Ian Stakenvicius (RETIRED) gentoo-dev 2009-06-04 14:12:43 UTC
The eautoreconf call is needed because he patches the autotools files so that the docs can be stripped via USE="-doc".  This was a requirement for sunrise, but since other packages in the tree install these docs regardless it's not necessary (imo) -- especially since it requires an eautoreconf to implement.

Assuming the deps in the README are correct tho probably isn't accurate; we should only depend on whatever minimum dependencies there actually are, instead of a blanket depend on gnome-common.
Comment 4 MT 2009-06-04 14:38:16 UTC
(In reply to comment #2)
> well, the gnome-common dep is listed in the README of the package as required 
> I assumed that this is accurate... =/

yes, you are right (see bug 254704), that missing depend was a mine error.


> why is the gnome2 eclass needed here? (and eautoreconf call?)

because tha package make use of the gtk framework and using gnome2 eclass the ebuild will be more optimized and short.

Comment 5 MT 2009-06-04 14:50:29 UTC
(In reply to comment #3)
> The eautoreconf call is needed because he patches the autotools files so that
> the docs can be stripped via USE="-doc".  This was a requirement for sunrise,
> but since other packages in the tree install these docs regardless it's not
> necessary (imo) -- especially since it requires an eautoreconf to implement.

nope, the eauto* calls are required because the original autotools scripts provides two configure options (other than enable-gtk-doc):
- enable-gtk-html-doc
- enable-gtk-html-pdf
which are not working, indeed the html docs is always builds and installed regardless the configure options supplied; a quick fix is to use the eauto* calls, but the autools scripts are broken and not working at all (also forcing WANT_AUTOCONF="2.62") making compilation/installation fails; indeed i have just reported that problems upstream and i was waiting for a quick fix (see my previous bug 192239)
Comment 6 Ian Stakenvicius (RETIRED) gentoo-dev 2009-06-04 15:57:54 UTC
(In reply to comment #5)
> the eauto* calls are required because the original autotools scripts
> provides two configure options (other than enable-gtk-doc):
> - enable-gtk-html-doc
> - enable-gtk-html-pdf
> which are not working, indeed the html docs is always builds and installed
> regardless the configure options supplied.

..right..  which, since most (if not all) other gtk-based libs and such in portage also already do, means it's not so much of a concern for our ebuild.  

Back to the original reason for filing the bug -- gnome-common is only a dependency if we need to re-run autotools on the package.  So, with the ebuild as it is now, it's not a dep.  
Comment 7 Markus Meier gentoo-dev 2009-06-12 19:33:00 UTC
fixed in cvs, thanks for the report.

  12 Jun 2009; Markus Meier <maekke@gentoo.org> gtkimageview-1.6.4.ebuild:
  do not use -Werror during build wrt bug #272301
  use gnome eclass and add USE=doc wrt bug #272303
  add USE=examples and update mirror wrt bug #272620