Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 255490 - net-p2p/sancho-bin-0.9.4.59 version bump
Summary: net-p2p/sancho-bin-0.9.4.59 version bump
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo net-p2p team
URL:
Whiteboard:
Keywords: PMASKED
Depends on:
Blocks: 298731 421971
  Show dependency tree
 
Reported: 2009-01-19 10:24 UTC by yegle
Modified: 2012-11-18 14:34 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
sancho-bin-0.9.4.59.ebuild (file_255490.txt,1.28 KB, text/plain)
2012-09-22 17:47 UTC, Navid Zamani
Details
0.9.4.59-sancho.sh (file_255490.txt,46 bytes, text/plain)
2012-09-22 17:50 UTC, Navid Zamani
Details
sancho-bin-0.9.4.59.ebuild (file_255490.txt,1.54 KB, text/plain)
2012-09-22 18:40 UTC, Navid Zamani
Details
0.9.4.59-sancho.sh (file_255490.txt,272 bytes, text/plain)
2012-09-22 18:41 UTC, Navid Zamani
Details

Note You need to log in before you can comment on or make changes to this bug.
Description yegle 2009-01-19 10:24:49 UTC
The newest version of sancho-bin is 0.9.4-59, and the one in portage is 0.9.4-58.Although the number change is small,but after I tried the new version,I had to say that this is needed to bump the version.
It's a pity that I cannot found the official download link for sancho-bin 0.9.4-59,but I downloaded one from here:
http://repository.slacky.eu/slackware-12.1/network/sancho/0.9.4-59/src/sancho-0.9.4-59-linux-gtk.sh
Hope this would help.

Reproducible: Always
Comment 1 Navid Zamani 2012-09-22 17:47:14 UTC
Created attachment 324644 [details]
sancho-bin-0.9.4.59.ebuild

Here’s the updated ebuild.

I had to remove the native binary versions (the “java” USE flag is gone), because those binaries had relative rpaths. (Not a problem, if always executed through the “/opt/bin/sancho” script, which changes into the correct dir, before running the executable. But a problem when executed directly. Which never happens in normal usage. But apparently, it’s a gigantic security problem. [Don’t ask me why].) Anyway, the native version couldn’t even render in the correct widget theme because it couldn’t find the theme engine in GTK’s module path.

I also had to remove PPC support, since the binary can’t actually be downloaded anywhere. The links are dead.

The binary was also unnecessarily copied twice, with the small script calling the second one. I removed that too and changed the script (see: next attachment). It’s just “sancho” now.

Then I don’t know the exact rules for the ebuild header comments yet. So I removed them all. Feel free do add them the way they’re supposed to be, if that is required for portage inclusion.

And finally, I fixed the changed homepage.

It installs and runs find on my amd64 box.

The question now is, who puts the install files into the mirrors? (I definitely have no access.) Since fetching from the original homepage is not an option. (Doesn’t work with wget.)
Comment 2 Navid Zamani 2012-09-22 17:50:02 UTC
Created attachment 324646 [details]
0.9.4.59-sancho.sh

Updated version of the small run script.

(Ditto with the headers.)
Comment 3 Navid Zamani 2012-09-22 17:52:19 UTC
The official download links are on the homepage (see inside the new ebuild) by the way.
Comment 4 SpanKY gentoo-dev 2012-09-22 18:03:34 UTC
Comment on attachment 324646 [details]
0.9.4.59-sancho.sh

>#!/bin/bash
>cd /opt/sancho
>./sancho ${*}

very simple, yet very broken.  this needs to be:
#!/bin/bash
cd /opt/sancho && exec ./sancho "$@"
Comment 5 SpanKY gentoo-dev 2012-09-22 18:05:54 UTC
Comment on attachment 324644 [details]
sancho-bin-0.9.4.59.ebuild

style is bad in this.  you should also post diffs, not entire new files.

- missing proper header block (read the skel.ebuild in the tree)
- indentation is with tabs, not spaces
- missing IUSE
- update to EAPI=4 as there's no reason to stick to 1
- you need to quote "${FILESDIR}" and "${D}"
- `cd "${S}"` at the start of src_install is pointless
Comment 6 Navid Zamani 2012-09-22 18:21:11 UTC
(In reply to comment #5)
> style is bad in this.
So was the old ebuild.

> you should also post diffs, not entire new files.
Thanks for the info. You should have told me earlier…

> - missing proper header block (read the skel.ebuild in the tree)
Did you even read my comment? :( Please read it fully, before replying. Thanks.

> - indentation is with tabs, not spaces
That was deliberate. Tabs create a mess, because tab width can’t be relied upon. Spaces is cleaner.

> - missing IUSE
Ah, okay, I assumed an non-defined IUSE means the same as IUSE="".

> - update to EAPI=4 as there's no reason to stick to 1
Yes, the reason is that I don’t pointlessly waste time, to learn how to, and make a change that has no real-world advantage.

> - you need to quote "${FILESDIR}" and "${D}"
I did not change that. It’s exactly how it was.

> - `cd "${S}"` at the start of src_install is pointless
Ditto.

What was the point of making this a tirade? It would have been friendly, to write it as positive suggestions, instead of criticisms.
Comment 7 Navid Zamani 2012-09-22 18:29:06 UTC
(In reply to comment #4)
> very simple, yet very broken.
And very exactly the same code as before. (Minus the character string “-bin”.)
Comment 8 Navid Zamani 2012-09-22 18:40:48 UTC
Created attachment 324650 [details]
sancho-bin-0.9.4.59.ebuild

Here. Now with all the ugliness you like so much.
I even included the header line with the “Copyright”, even though usage of that concept supports organized crime and spreads the very mindset they build their criminal acts on, and harms everyone else… the open-source community doubly so.
And I changed the EAPI line to EAPI="4". If things blow up because of that, you can blame yourself.
Comment 9 Navid Zamani 2012-09-22 18:41:53 UTC
Created attachment 324652 [details]
0.9.4.59-sancho.sh

“Fixed”.
Comment 10 SpanKY gentoo-dev 2012-09-22 18:57:45 UTC
(In reply to comment #6)

your opinion on style doesn't really matter.  we have a guide for ebuilds that all Gentoo devs follow which means all ebuilds most follow.

also, your paranoid rants on copyright should be posted elsewhere.  this is not the place for them.
Comment 11 Pacho Ramos gentoo-dev 2012-11-18 14:34:34 UTC
dropped