Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 217341 - games-engines/qtads-1.9.ebuild: version bump
Summary: games-engines/qtads-1.9.ebuild: version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High enhancement with 1 vote (vote)
Assignee: Gentoo Games
URL: http://qtads.sf.net
Whiteboard:
Keywords:
: 245156 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-04-11 22:53 UTC by Nikos Chantziaras
Modified: 2009-10-13 16:35 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
qtads-1.7.ebuild (qtads-1.7.ebuild,1.01 KB, text/plain)
2008-04-11 22:54 UTC, Nikos Chantziaras
Details
qtads-1.7.ebuild (qtads-1.7.ebuild,1.40 KB, text/plain)
2009-05-15 20:23 UTC, Nikos Chantziaras
Details
qtads-1.7.ebuild.patch (qtads-1.7.ebuild.patch,297 bytes, patch)
2009-05-15 21:58 UTC, Nikos Chantziaras
Details | Diff
qtads-1.8.ebuild (qtads-1.8.ebuild,1.40 KB, text/plain)
2009-05-26 18:04 UTC, Nikos Chantziaras
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nikos Chantziaras 2008-04-11 22:53:35 UTC
Attached is qtads-1.7.ebuild. This is a version-bump to QTads 1.7 which is the latest upstream version (a bug-fix release).

QTads is a GUI interpreter for Tads games, running under Unix-based systems (it has been tested in Linux, Mac OS X and FreeBSD, but it should compile and run in many more, like Solaris and Irix). Tads is a programming language for implementing Interactive Fiction (text-adventures). QTads supports both Tads2 and Tads3 games.

The current version (1.6c) that is in portage is broken for new Tads 3 games, since 1.6c is based on a very old beta-version of the Tads virtual machine; it is virtually useless for newer Tads 3 games. It is also broken on 64-bit archs; 1.7 fixes this.

I added ~amd64 to the ebuild (my main system is a Gentoo on AMD64). Furthermore, the "-fno-strict-aliasing" flag is only added to CXXFLAGS (it is not needed in CFLAGS).

Also, DEPEND has been changed from "$(qt_min_version 3)" to "=x11-libs/qt-3*" since the package uses Qt3 only and won't build with Qt4 (see bug 144173).
Comment 1 Nikos Chantziaras 2008-04-11 22:54:58 UTC
Created attachment 149442 [details]
qtads-1.7.ebuild
Comment 2 Nikos Chantziaras 2008-09-05 19:38:28 UTC
QTads, along with many other IF tools, is now in the "interactive-fiction" overlay. It can be easily accessed with the "layman" utility.  Thanks to David Leverton for the overlay.
Comment 3 Stephen E. Baker 2009-01-06 13:21:05 UTC
Should we CC Michael about this?
Comment 4 Nikos Chantziaras 2009-01-07 10:57:40 UTC
Depends on who Michael is :P
Comment 5 Stephen E. Baker 2009-01-07 11:23:10 UTC
Michael Sterrett aka Mr. Bones.  He seems to have done the initial commit and most of the maintenance thus far.
Comment 6 Tomáš Chvátal (RETIRED) gentoo-dev 2009-01-07 11:30:51 UTC
Mr. Bones is member of games herd. Thus he gets every change added to games@gentoo.org alias.

Read as: he already see this stuff on his mail :] no need to cc him additionaly. With that he only gets double mails :]
Comment 7 Nikos Chantziaras 2009-05-15 20:23:07 UTC
Created attachment 191422 [details]
qtads-1.7.ebuild

Here's a new ebuild, this time doing it "the right way" (I hope).

* Uses EAPI version 2.
* DEPEND uses slotted Qt.
* Uses append-cxxflags instead of CXXFLAGS directly.
* Installs using emake instead of by hand with doins (except for the docs and translations.)
* Supports LINGUAS to determine whether translations should be installed.
* Removes src_compile() and introduces src_configure() where eqmake3 should be.
* Adds a desktop entry.

It's written from scratch again so a patch would be longer than the original ebuild.

The ebuild results in a "QA Notice: Pre-stripped files found" message, but instead of fixing this in the ebuild, I decided to fix it portage-wide for all qmake projects and therefore submitted bug 269942. It's just a matter of passing "QMAKE_STRIP=" to qmake but this should go in qt3.eclass instead of in every ebuild that makes use of eqmake3.
Comment 8 David Leverton 2009-05-15 21:03:54 UTC
(In reply to comment #7)
> Created an attachment (id=191422) [edit]
> qtads-1.7.ebuild
> 
> Here's a new ebuild, this time doing it "the right way" (I hope).

Updated in the overlay.  The only thing that I noticed that's slightly wrong is ${A} being quoted.  It doesn't really hurt here because there's only one source file (if there were more, they'd be passed as a single argument to unpack containing spaces), but it's better to leave it unquoted.
Comment 9 Nikos Chantziaras 2009-05-15 21:15:01 UTC
(In reply to comment #8)
> Updated in the overlay.  The only thing that I noticed that's slightly wrong is
> ${A} being quoted.  It doesn't really hurt here because there's only one source
> file (if there were more, they'd be passed as a single argument to unpack
> containing spaces), but it's better to leave it unquoted.

Oops, thanks for catching this.  I suppose you changed it before committing it.
Comment 10 David Leverton 2009-05-15 21:30:52 UTC
(In reply to comment #9)
> Oops, thanks for catching this.  I suppose you changed it before committing it.

Well, I've been trying not to introduce needless differences between the overlay and the ebuild here, especially over something that doesn't make a practical difference, since it would probably lead to confusion (my own, if no-one else's).  But I'll update it now.
Comment 11 Nikos Chantziaras 2009-05-15 21:58:10 UTC
Created attachment 191427 [details, diff]
qtads-1.7.ebuild.patch

I asked since I'm now attaching a patch for the ebuild in case this gets into Portage ;)
Comment 12 Nikos Chantziaras 2009-05-26 18:04:52 UTC
Created attachment 192521 [details]
qtads-1.8.ebuild

New upstream release: 1.8

This ebuild incorporates the previous patch and also fixes the call to make_desktop_entry.
Comment 13 Nikos Chantziaras 2009-06-24 13:24:27 UTC
New upstream release: version 1.9.

Renaming the 1.8 ebuild works.

If possible, please either bump the version in Portage to this version or completely remove the (now ancient) version 1.6c from Portage since it doesn't even work anymore for TADS3 games released after 2005.
Comment 14 Mr. Bones. (RETIRED) gentoo-dev 2009-06-30 05:38:47 UTC
qtads-1.9 is in portage.
Comment 15 Nikos Chantziaras 2009-06-30 17:35:40 UTC
(In reply to comment #14)
> qtads-1.9 is in portage.

I'm reopening because it seems you used the wrong ebuild :P  The correct ebuild is the last one posted here (qtads-1.8.ebuild, must be renamed to qtads-1.9.ebuild).
Comment 16 Mr. Bones. (RETIRED) gentoo-dev 2009-06-30 17:39:59 UTC
this bug was about the version bump.  If there's patches necessary against the one in portage please open a new bug.
Comment 17 Mr. Bones. (RETIRED) gentoo-dev 2009-10-13 16:35:35 UTC
*** Bug 245156 has been marked as a duplicate of this bug. ***