Bug 190242 – media-fonts/font-misc-ethiopic-1.0.0 is angry

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description SpanKY 2007-08-25 22:17:12 UTC]

first there's a QA notice about nls not in IUSE ... then there's the configure flags not being quoted properly

>>> Compiling source in /var/tmp/portage/media-fonts/font-misc-ethiopic-1.0.0/work/font-misc-ethiopic-1.0.0 ...
 * QA Notice: USE Flag 'nls' not in IUSE for media-fonts/font-misc-ethiopic-1.0.0
./configure --prefix=/usr --host=sh4-unknown-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --prefix=/usr --datadir=/usr/share --with-fontdir="/usr/share/fonts/TTF OTF" --with-mapfiles=/usr/share/fonts/util --with-ttf-fontdir=/usr/share/fonts/TTF --with-otf-fontdir=/usr/share/fonts/OTF --build=sh4-unknown-linux-gnu
configure: WARNING: you should use --build, --host, --target
configure: WARNING: invalid host type: OTF"

checking for a BSD-compatible install... /usr/bin/install -c

[Comment 1 Donnie Berkholz (RETIRED) 2007-09-04 08:15:19 UTC]

QA notice is retarded because portage doesn't check the eclass.

Will look into the fontdirs bit, probably some dumb eclass bug where I didn't account for FONT_DIR having multiple words.

[Comment 2 Ryan Hill (RETIRED) 2009-08-18 06:28:17 UTC]

Created attachment 201578 [details, diff]
x-modular.eclass.diff

The ebuild sets FONT_DIR="TTF OTF", and the eclass does

     # Set up configure option
     FONT_OPTIONS="--with-fontdir=\"/usr/share/fonts/${FONT_DIR}\""

Even if it did make sense to pass --with-fontdir to configure twice, this font doesn't have a --with-fontdir option, just --with-ttf-fontdir and --with-otf-fontdir.

This patch makes it possible for ebuilds to set FONT_OPTIONS themselves.

While digging, I also found that setup_fonts calls fix_font_permissions and then create_font_cache.  create_font_cache calls the pkg_postinst from font.eclass, which already fixes the permissions of everything in /usr/share/fonts, so the fix_font_permisions call is redundant (and because it only matches on files starting with "font.", and we don't install any, it doesn't actually do anything at all :P).

[Comment 3 Ryan Hill (RETIRED) 2009-08-18 06:33:41 UTC]

Created attachment 201580 [details, diff]
font-misc-ethiopic-1.0.0.ebuild.diff

[Comment 4 Tomáš Chvátal (RETIRED) 2009-08-22 14:38:29 UTC]

Oky, the patch for eclass is sane, and same for the ebuild, since you are dev too proceed and commit it :]

[Comment 5 Ryan Hill (RETIRED) 2009-09-19 20:12:17 UTC]

Applied a while ago, will close when stabilized.

[Comment 6 Samuli Suominen (RETIRED) 2010-02-03 11:42:07 UTC]

KEYWORDS="alpha amd64 arm hppa ia64 m68k ~mips ppc ppc64 s390 sh sparc x86

It's stable now, closing.