Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 178501 - Version bumps for libmilter/dk-milter/sid-milter, also with IPv6 support
Summary: Version bumps for libmilter/dk-milter/sid-milter, also with IPv6 support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Alin Năstac (RETIRED)
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2007-05-14 11:52 UTC by Jan Oravec
Modified: 2007-10-12 22:17 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
New ebuild for libmilter (libmilter-8.14.1.ebuild,1.37 KB, text/plain)
2007-05-14 11:53 UTC, Jan Oravec
Details
libmilter/files/site.config.m4 (site.config.m4,78 bytes, text/plain)
2007-05-14 11:54 UTC, Jan Oravec
Details
New ebuild for dk-milter (dk-milter-0.5.0.ebuild,1.71 KB, text/plain)
2007-05-14 11:54 UTC, Jan Oravec
Details
dk-milter/files/site.config.m4 (site.config.m4,129 bytes, text/plain)
2007-05-14 11:55 UTC, Jan Oravec
Details
dk-milter/files/postfix-queueID.patch (postfix-queueID.patch,547 bytes, text/plain)
2007-05-14 11:56 UTC, Jan Oravec
Details
New ebuild for sid-milter (sid-milter-0.2.14.ebuild,1.50 KB, text/plain)
2007-05-14 11:56 UTC, Jan Oravec
Details
sid-milter/files/site.config.m4 (site.config.m4,129 bytes, text/plain)
2007-05-14 11:56 UTC, Jan Oravec
Details
sid-milter/files/postfix-queueID.patch (postfix-queueID.patch,652 bytes, text/plain)
2007-05-14 11:57 UTC, Jan Oravec
Details
Updated ebuild for dk-milter (dk-milter-0.6.0.ebuild,1.79 KB, text/plain)
2007-10-11 17:31 UTC, Jan Oravec
Details
dk-milter/files/gentoo.config.m4 (gentoo.config.m4,72 bytes, text/plain)
2007-10-11 17:31 UTC, Jan Oravec
Details
dk-milter/files/dk-milter-0.6.0-postfix-queueID.patch (dk-milter-0.6.0-postfix-queueID.patch,547 bytes, patch)
2007-10-11 17:32 UTC, Jan Oravec
Details | Diff
Updated ebuild for dk-milter (dk-milter-0.6.0.ebuild,1.72 KB, text/plain)
2007-10-11 18:32 UTC, Jan Oravec
Details
Updated ebuild for sid-milter (sid-milter-0.2.14.ebuild,1.54 KB, text/plain)
2007-10-11 18:33 UTC, Jan Oravec
Details
sid-milter/files/gentoo.config.m4 (gentoo.config.m4,72 bytes, text/plain)
2007-10-11 18:33 UTC, Jan Oravec
Details
sid-milter/files/sid-milter-0.2.14-postfix-queueID.patch (sid-milter-0.2.14-postfix-queueID.patch,652 bytes, patch)
2007-10-11 18:34 UTC, Jan Oravec
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Oravec 2007-05-14 11:52:48 UTC
Current ebuilds for packages:

mail-filter/libmilter
mail-filter/dk-milter
mail-filter/sid-milter

are a bit old. I cleaned these ebuilds, enabled IPv6 functionality with ipv6 USE flag, tried it on x86/amd64 and also bumped versions.

Also, this sid-milter can be safely package.unmasked.


Reproducible: Always
Comment 1 Jan Oravec 2007-05-14 11:53:52 UTC
Created attachment 119209 [details]
New ebuild for libmilter
Comment 2 Jan Oravec 2007-05-14 11:54:27 UTC
Created attachment 119210 [details]
libmilter/files/site.config.m4
Comment 3 Jan Oravec 2007-05-14 11:54:58 UTC
Created attachment 119211 [details]
New ebuild for dk-milter
Comment 4 Jan Oravec 2007-05-14 11:55:29 UTC
Created attachment 119215 [details]
dk-milter/files/site.config.m4
Comment 5 Jan Oravec 2007-05-14 11:56:04 UTC
Created attachment 119219 [details]
dk-milter/files/postfix-queueID.patch
Comment 6 Jan Oravec 2007-05-14 11:56:23 UTC
Created attachment 119220 [details]
New ebuild for sid-milter
Comment 7 Jan Oravec 2007-05-14 11:56:44 UTC
Created attachment 119221 [details]
sid-milter/files/site.config.m4
Comment 8 Jan Oravec 2007-05-14 11:57:11 UTC
Created attachment 119222 [details]
sid-milter/files/postfix-queueID.patch
Comment 9 Eray Aslan gentoo-dev 2007-06-10 16:01:35 UTC
(In reply to comment #1)
> Created an attachment (id=119209) [edit]
> New ebuild for libmilter

Consider adding poll USE flag building libmilter with poll() instead of select() if poll() is available on your system.  During high loads, this can become important.  Perhaps something like:

--- libmilter-8.14.1.ebuild.orig        2007-06-10 15:52:26.000000000 +0000
+++ libmilter-8.14.1.ebuild     2007-06-10 15:53:00.000000000 +0000
@@ -13,7 +13,7 @@
 LICENSE="Sendmail"
 SLOT="0"
 KEYWORDS="~x86 ~amd64"
-IUSE="ipv6"
+IUSE="ipv6 poll"

 DEPEND=""
 RDEPEND="${DEPEND}"
@@ -28,6 +28,7 @@
        confCCOPTS="${CFLAGS}"
        confENVDEF=""
        use ipv6 && confENVDEF="${confENVDEF} -DNETINET6"
+       use poll && confENVDEF="${confENVDEF} -DSM_CONF_POLL=1"
        sed -e "s:@@confCCOPTS@@:${confCCOPTS}:" \
                -e "s/@@confENVDEF@@/${confENVDEF}/" \
                "${FILESDIR}"/site.config.m4 > ${S}/devtools/Site/site.config.m4
Comment 10 Alin Năstac (RETIRED) gentoo-dev 2007-10-11 14:34:24 UTC
I've already fixed the libmilter (needed for dkim-milter).

Could you please bump attach bumped dk-milter and sid-milter ebuilds?
Please make the new ebuilds look like the current dkim-milter version.
Comment 11 Jan Oravec 2007-10-11 14:58:59 UTC
I am going to look at it now. Could you please add ipv6 and poll USE flags to libmilter? It should be trivial (see my ebuild).
Comment 12 Alin Năstac (RETIRED) gentoo-dev 2007-10-11 15:08:26 UTC
Already done it in version 8.14.1-r1.
Comment 13 Jan Oravec 2007-10-11 17:29:29 UTC
Thanks for ipv6 and poll IUSE!

Going to attach dk-milter. I have used same approach with site config as with libmilter as it is more elegant when adding IPv6 support. sid-milter will follow soon.
Comment 14 Jan Oravec 2007-10-11 17:31:05 UTC
Created attachment 133164 [details]
Updated ebuild for dk-milter
Comment 15 Jan Oravec 2007-10-11 17:31:57 UTC
Created attachment 133166 [details]
dk-milter/files/gentoo.config.m4
Comment 16 Jan Oravec 2007-10-11 17:32:47 UTC
Created attachment 133167 [details, diff]
dk-milter/files/dk-milter-0.6.0-postfix-queueID.patch
Comment 17 Jan Oravec 2007-10-11 18:32:28 UTC
Created attachment 133192 [details]
Updated ebuild for dk-milter

I have removed test phase as "make OPTIONS=check" does nothing, just bubble through SUBDIRs. Also, I have fixed "make install" to install only dk-milter stuff. This makes no difference for dk-milter, but sid-milter installs some static library into /usr/lib, replacing symlink on 64-bit and breaking system.
Comment 18 Jan Oravec 2007-10-11 18:33:05 UTC
Created attachment 133194 [details]
Updated ebuild for sid-milter
Comment 19 Jan Oravec 2007-10-11 18:33:42 UTC
Created attachment 133195 [details]
sid-milter/files/gentoo.config.m4
Comment 20 Jan Oravec 2007-10-11 18:34:30 UTC
Created attachment 133197 [details, diff]
sid-milter/files/sid-milter-0.2.14-postfix-queueID.patch
Comment 21 Jan Oravec 2007-10-11 18:37:08 UTC
Ebuilds should be complete now. Please review and commit if everything is OK :).
Comment 22 Alin Năstac (RETIRED) gentoo-dev 2007-10-12 08:10:04 UTC
I've looked over your dk-milter and it isn't good enough. The patch is not needed anymore and -DNETUNIX -DNETINET -DNETINET6 are useless for this package (see the source).

Except src_test (which is pointless for this package) and configuration file (not supported), please do exactly what dkim-milter does (e.g. generate site.config.m4 based on .dist file, implement pkg_config, have similar pkg_postinst, ...). We've worked hard to come up with this kind of ebuild, so please reuse it.

The correct lib dir can be forced. See current libmilter ebuild.
Comment 23 Jan Oravec 2007-10-12 12:38:59 UTC
-DNETINET6 is important. dk-milter/sid-milter will otherwise fail when processing mail from postfix which was received by postfix over IPv6. I agree about not using -DNETUNIX and -DNETINET.

pkg_postinst is similar (except 'elog' lines). I am not sure how exactly dk-milter works when signing mails - I am using it currently only to check signatures. I guess copying pkg_config and fixing key paths will work.
Comment 24 Alin Năstac (RETIRED) gentoo-dev 2007-10-12 13:45:31 UTC
(In reply to comment #23)
> -DNETINET6 is important. dk-milter/sid-milter will otherwise fail when
> processing mail from postfix which was received by postfix over IPv6.

Yeah, I found where it's used. ipv6 useflag will make it through IUSE.

> pkg_postinst is similar (except 'elog' lines). I am not sure how exactly
> dk-milter works when signing mails - I am using it currently only to check
> signatures. I guess copying pkg_config and fixing key paths will work.

You have a point here. DomainKeys is obsolete so I don't know if there is anyone (besides yahoo obviously) still interested in signing his/her mail with it. I'll assume no one wants that and go your way.

Comment 25 Alin Năstac (RETIRED) gentoo-dev 2007-10-12 20:43:38 UTC
I've commited dk-milter-0.6.0. I've added all the bells and whistles from dkim-milter because it was easier for me to do this than correcting that crappy key generator script.

I've changed the conf.d file and init.d file quite a bit. 
Since DK RFC is obsoleted by DKIM, the new default configuration is set on verify-only.
Comment 26 Alin Năstac (RETIRED) gentoo-dev 2007-10-12 22:17:24 UTC
sid-milter-0.2.14 is now in the tree, mostly as you posted here. You were right about libar, it is useless (no header file is installed and all milters I've committed so far had that library in their source tree).
Changes from your version:
 - install man page by hand (the build process breaks its format)
 - removed ipv6 flag (doesn't use -DNETINET6 at all)

I didn't added myself as maintainer because I don't intend to spend my time on packages that are perfect candidates for removal. IMO Sender ID died the moment MARID ceased to exist.