Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 148390 - cryptsetup-luks incorrectly uses linux-info eclass
Summary: cryptsetup-luks incorrectly uses linux-info eclass
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Benjamin Smee (strerror) (RETIRED)
URL:
Whiteboard:
Keywords: InVCS
Depends on: 192556
Blocks: 189924
  Show dependency tree
 
Reported: 2006-09-20 09:02 UTC by Paul Bredbury
Modified: 2008-01-25 18:47 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
cryptsetup-luks-1.0.3-r2.patch (cryptsetup-luks-1.0.3-r2.patch,1.28 KB, patch)
2006-09-20 09:04 UTC, Paul Bredbury
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Bredbury 2006-09-20 09:02:35 UTC
Hi, the usage of linux_chkconfig_present in the sys-fs/cryptsetup-luks ebuilds will always fail, because linux-info_pkg_setup is not called first, so KV_OUT_DIR in linux-info will not have been defined.

Here is a patch to fix it, whilst hopefully still satisfying bug #141182 via usage of the global "build" USE flag. It also uses the "check_extra_config" routine for checking and reporting the problem, rather than pointing the user at a kernel option whose location keeps changing, depending on the kernel version (it's changed again in kernel 2.6.18).

The sys-fs/cryptsetup ebuilds should be changed similarly.
Comment 1 Paul Bredbury 2006-09-20 09:04:17 UTC
Created attachment 97550 [details, diff]
cryptsetup-luks-1.0.3-r2.patch
Comment 2 Lars Weiler (RETIRED) gentoo-dev 2006-09-22 07:24:52 UTC
The problem is, we don't use the 'build' nor the 'livecd' USE-flag during our GRP-set building.
Comment 3 Paul Bredbury 2006-09-22 07:50:28 UTC
Then ignore the ewarn, or add a "grp" USE flag ;)
Comment 4 Benjamin Smee (strerror) (RETIRED) gentoo-dev 2006-10-12 04:06:14 UTC
fixed in cvs, try -r3
Comment 5 Chris Gianelloni (RETIRED) gentoo-dev 2007-08-23 17:24:09 UTC
OK.  This is still incorrect.

Running the linux-info_pkg_setup on a system with an unconfigured kernel will *always* fail.  This means building GRP, LiveCD, or using the Installer.

Packages that are not kernel modules should *never* fail on an unconfigured kernel.  We never use the "build" USE flag outside of building a stage1 tarball, so the suggestion to use it was completely incorrect.  Instead, the build check should be removed, and it should be replaced with proper checking.  Warnings are fine.  Failures are not.

Basically, you have no need to run linux-info_pkg_setup, at all.  Remove the USE=build check, run the dm-crypt_check, crypto_check, and cbc_check unconditionally, and remove linux-info_pkg_setup completely, as it doesn't do anything this package needs to build.  It will complain about the missing kernel, but it won't fail.
Comment 6 Chris Gianelloni (RETIRED) gentoo-dev 2007-09-13 00:15:40 UTC
If nobody has any objections, I can go ahead and add this.  This is pretty much what we did for the 2006.1/2007.0 releases, so we know it works.
Comment 7 Benjamin Smee (strerror) (RETIRED) gentoo-dev 2007-09-13 02:35:38 UTC
go for it.
Comment 8 Chris Gianelloni (RETIRED) gentoo-dev 2007-09-14 21:32:18 UTC
Ugh... I think linux-info has changed recently.

OK.  I've gone ahead and made the changes to cryptsetup/cryptsetup-luks, but some code needs to change in linux-info.  As such, I am leaving this bug open in an attempt to keep you from getting dupes.  I'll close it once the other bug is resolved and this bug will magically be "fixed" along with linux-info.
Comment 9 Chris Gianelloni (RETIRED) gentoo-dev 2008-01-25 18:47:15 UTC
Yay!