Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 928951 - app-portage/gentoolkit-0.6.5 eclean-dist produces garbled file names
Summary: app-portage/gentoolkit-0.6.5 eclean-dist produces garbled file names
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2024-04-08 18:49 UTC by Frank Limpert
Modified: 2024-06-13 05:08 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
output of eclean-dist -C -d -p -q (eclean-dist.broken,9.92 KB, text/plain)
2024-04-08 18:49 UTC, Frank Limpert
Details
output of eclean-dist -C -d -p (eclean-dist.broken-long,9.91 KB, text/plain)
2024-04-08 18:51 UTC, Frank Limpert
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Limpert 2024-04-08 18:49:52 UTC
Created attachment 889939 [details]
output of eclean-dist -C -d -p -q

app-portage/gentoolkit-0.6.5 compiles fine — both on my x86 and x86_64 boxes.

But it's output on both achitectures contains garbled file names in the beginning.

- for "eclean-dist -C -d -p -q" every second character of these file names is a newline

- for "eclean-dist -C -d -p" these file names are absolute instead of relative

- without -p switch eclean-dist complains, perhaps rightly, about *.ebuild files containing EAPI=6, which are not supported any more, apparently. None of those broken ebuilds are installed.
Comment 1 Frank Limpert 2024-04-08 18:51:06 UTC
Created attachment 889940 [details]
output of eclean-dist -C -d -p
Comment 2 Manuel Mommertz 2024-04-11 07:25:18 UTC
I can confirm. More precisely: The new handling of VCS sources is affected, when using -p/--pretend.
* They are printed absolute, not relative
* With -q, each character of VCS sources is printed on a separate line

Workaround: Append the parameter --skip-vcs to eclean, and you get the behavior of the older versions back. (E.g. in case you need the output inside a script, which breaks with this new version.)
Comment 3 Frank Limpert 2024-04-22 08:08:23 UTC
Thanks for the workaround. It works for me, too.
Comment 4 Larry the Git Cow gentoo-dev 2024-05-03 05:40:33 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/gentoolkit.git/commit/?id=bb6faf478f7e64d75224e55c3b81deb843dc9749

commit bb6faf478f7e64d75224e55c3b81deb843dc9749
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-05-03 05:40:05 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-05-03 05:40:05 +0000

    eclean: dist: fix printing VCS clean items with --quiet
    
    Bug: https://bugs.gentoo.org/928951
    Signed-off-by: Sam James <sam@gentoo.org>

 pym/gentoolkit/eclean/output.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
Comment 5 Larry the Git Cow gentoo-dev 2024-05-08 21:44:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7d957d77c80b4296b8b3bdcc04bee1e4a953f9b1

commit 7d957d77c80b4296b8b3bdcc04bee1e4a953f9b1
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-05-08 21:44:38 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-05-08 21:44:38 +0000

    app-portage/gentoolkit: add 0.6.7
    
    Closes: https://bugs.gentoo.org/877491
    Closes: https://bugs.gentoo.org/923369
    Closes: https://bugs.gentoo.org/915055
    Closes: https://bugs.gentoo.org/928951
    Closes: https://bugs.gentoo.org/928138
    Signed-off-by: Sam James <sam@gentoo.org>

 app-portage/gentoolkit/Manifest                |   1 +
 app-portage/gentoolkit/gentoolkit-0.6.7.ebuild | 127 +++++++++++++++++++++++++
 2 files changed, 128 insertions(+)
Comment 6 Manuel Mommertz 2024-06-06 05:41:07 UTC
Sorry, I tested it just now. Seems, like eclean-dist does again not print any VCS items. Compare:

# eclean-dist --version
eclean (0.6.7) - A cleaning tool for Gentoo distfiles and binaries.
[..]

# eclean-dist -p
 * Building file list for distfiles cleaning...
 * Here are the distfiles that would be deleted:
 [  380.8 K ] Mako-1.3.3.tar.gz
 [   17.1 K ] gpep517-15.gh.tar.gz
 [  268.3 K ] jinja-3.1.3.gh.tar.gz
 [   19.9 K ] platformdirs-4.2.1.tar.gz
 [   15.7 K ] trove-classifiers-2024.4.10.tar.gz
 ===========
 [  701.8 K ] Total space from 5 files would be freed in the distfiles directory


And:

# eclean-dist --version
eclean (0.6.5) - A cleaning tool for Gentoo distfiles and binaries.
[..]

# eclean-dist -p
 * Building file list for distfiles cleaning...
 * Here are the distfiles that would be deleted:
 [   34.6 M ] /usr/local/distfiles/git3-src/mesonbuild_meson.git
[.. several institute internal git repos ..]
 [  380.8 K ] Mako-1.3.3.tar.gz
 [   17.1 K ] gpep517-15.gh.tar.gz
 [  268.3 K ] jinja-3.1.3.gh.tar.gz
 [   19.9 K ] platformdirs-4.2.1.tar.gz
 [   15.7 K ] trove-classifiers-2024.4.10.tar.gz
 ===========
 [  580.4 M ] Total space from 44 files would be freed in the distfiles directory
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-06-06 06:02:18 UTC
It now needs --deep to avoid being destructive (for another bug).
Comment 8 Manuel Mommertz 2024-06-07 15:22:03 UTC
(In reply to Sam James from comment #7)
> It now needs --deep to avoid being destructive (for another bug).

Ok, I see. The output with -
Comment 9 Manuel Mommertz 2024-06-07 15:24:39 UTC
Sorry, send the last message to early.

(In reply to Sam James from comment #7)
> It now needs --deep to avoid being destructive (for another bug).

Ok, I see. The output with -q looks correct, now. Without -q the VCS stuff is still shown as full path while for normal distfiles only the basename is printed.
Comment 10 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-06-12 02:11:38 UTC
(In reply to Manuel Mommertz from comment #9)
> Sorry, send the last message to early.
> 
> (In reply to Sam James from comment #7)
> > It now needs --deep to avoid being destructive (for another bug).
> 
> Ok, I see. The output with -q looks correct, now. Without -q the VCS stuff
> is still shown as full path while for normal distfiles only the basename is
> printed.

Would you mind filing another bug for that? I can't get to it just yet. Thank you.
Comment 11 Manuel Mommertz 2024-06-13 05:08:55 UTC
(In reply to Sam James from comment #10)
> Would you mind filing another bug for that? I can't get to it just yet.
> Thank you.

Done. See: https://bugs.gentoo.org/934179