Hello, With the new gentoolkit, I now receive this error when running "eclean-dist --deep" : * Building file list for distfiles cleaning... Traceback (most recent call last): File "/usr/lib/python-exec/python3.11/eclean-dist", line 41, in <module> main() File "/usr/lib/python3.11/site-packages/gentoolkit/eclean/cli.py", line 737, in main doAction(action, options, exclude=exclude, output=output) File "/usr/lib/python3.11/site-packages/gentoolkit/eclean/cli.py", line 582, in doAction clean_me, saved, deprecated, vcs = engine.findDistfiles( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ValueError: not enough values to unpack (expected 4, got 3) Thanks. Reproducible: Always
Looks to be introduced by: commit 87912b460c533f8b010617018fdad42246db85f0 Author: Siddhanth Rathod <xsiddhanthrathod@gmail.com> Date: Fri Sep 22 01:50:15 2023 +0530 Enhancement: eclean-dist handle git checkouts A new feature for eclean-dist to clean git3-src. Optionally, cleaning the vcs-src can be skipped with --skip-vcs. Bug: https://bugs.gentoo.org/622938 Signed-off-by: Siddhanth Rathod <xsiddhanthrathod@gmail.com> Closes: https://github.com/gentoo/gentoolkit/pull/33 Signed-off-by: Sam James <sam@gentoo.org>
In my case above error occurs *only* when directory /var/cache/distfiles is empty entirely - for example, when command "ls -la /var/cache/distfiles/" shows no file in that directory (so even hidden metafiles ".mirror-cache.json" and ".layout.conf.MIRROR_NAME" are not there). Otherwise no error is triggered.
The fileDistfiles return value needs to be updated on line 117 of pym/gentoolkit/eclean/search.py: https://github.com/gentoo/gentoolkit/pull/33/files#r1587941642
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/gentoolkit.git/commit/?id=7405fdccd73364662089f1001231bf8c24916ca3 commit 7405fdccd73364662089f1001231bf8c24916ca3 Author: Sam James <sam@gentoo.org> AuthorDate: 2024-05-03 05:10:41 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-05-03 05:10:41 +0000 eclean: dist: fix operating on an empty directory Zac pointed out that not all return paths had been updated. Bug: https://bugs.gentoo.org/928138 Fixes: 87912b460c533f8b010617018fdad42246db85f0 Signed-off-by: Sam James <sam@gentoo.org> pym/gentoolkit/eclean/search.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7d957d77c80b4296b8b3bdcc04bee1e4a953f9b1 commit 7d957d77c80b4296b8b3bdcc04bee1e4a953f9b1 Author: Sam James <sam@gentoo.org> AuthorDate: 2024-05-08 21:44:38 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-05-08 21:44:38 +0000 app-portage/gentoolkit: add 0.6.7 Closes: https://bugs.gentoo.org/877491 Closes: https://bugs.gentoo.org/923369 Closes: https://bugs.gentoo.org/915055 Closes: https://bugs.gentoo.org/928951 Closes: https://bugs.gentoo.org/928138 Signed-off-by: Sam James <sam@gentoo.org> app-portage/gentoolkit/Manifest | 1 + app-portage/gentoolkit/gentoolkit-0.6.7.ebuild | 127 +++++++++++++++++++++++++ 2 files changed, 128 insertions(+)
