I export $DISTDIR over NFS to several machines and rely on eclean-dist (*without* --deep) to leave those files intact. Today I ran it and instantly lost several gigabytes of distfiles I was actively using. As I'm behind a slow ISP connection, recovering from the data loss will take the better part of a day. This is a severe bug and/or surprising new behaviour that directly contradicts the eclean(1) manpage.
You can run eclean-dist --skip-vcs to avoid it.
Yeah, two bugs here, really: 1) Not documenting --skip-vcs; 2) Incorrect description of behaviour / --skip-vcs contradicting --deep I'll fix both now.
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/gentoolkit.git/commit/?id=d6fa2944ed84266acbaef59cb6d3adbd35d372b1 commit d6fa2944ed84266acbaef59cb6d3adbd35d372b1 Author: Sam James <sam@gentoo.org> AuthorDate: 2024-05-03 05:46:10 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-05-03 05:46:10 +0000 man: document eclean-dist's --skip-vcs Bug: https://bugs.gentoo.org/923369 Signed-off-by: Sam James <sam@gentoo.org> man/eclean.1 | 2 ++ 1 file changed, 2 insertions(+)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/gentoolkit.git/commit/?id=ada43fcd4306b1dac26606058ef97399beaa360a commit ada43fcd4306b1dac26606058ef97399beaa360a Author: Sam James <sam@gentoo.org> AuthorDate: 2024-05-03 06:06:22 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-05-03 06:18:10 +0000 eclean: dist: make VCS cleaning dependent on --deep The man page clearly says that without --deep, users can expect eclean-dist to be conservative in cleaning up, and not consider the VDB, just the repo state. Honour that promise by making VCS cleaning dependent on --deep, given it involves VDB inspection to see what's installed. Bug: https://bugs.gentoo.org/923369 Signed-off-by: Sam James <sam@gentoo.org> man/eclean.1 | 1 + pym/gentoolkit/eclean/cli.py | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7d957d77c80b4296b8b3bdcc04bee1e4a953f9b1 commit 7d957d77c80b4296b8b3bdcc04bee1e4a953f9b1 Author: Sam James <sam@gentoo.org> AuthorDate: 2024-05-08 21:44:38 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-05-08 21:44:38 +0000 app-portage/gentoolkit: add 0.6.7 Closes: https://bugs.gentoo.org/877491 Closes: https://bugs.gentoo.org/923369 Closes: https://bugs.gentoo.org/915055 Closes: https://bugs.gentoo.org/928951 Closes: https://bugs.gentoo.org/928138 Signed-off-by: Sam James <sam@gentoo.org> app-portage/gentoolkit/Manifest | 1 + app-portage/gentoolkit/gentoolkit-0.6.7.ebuild | 127 +++++++++++++++++++++++++ 2 files changed, 128 insertions(+)
