Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 924585 - sys-apps/portage: add PROPERTIES="test_privileged"
Summary: sys-apps/portage: add PROPERTIES="test_privileged"
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Ebuild Support (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS, PullRequest
Depends on: 921380
Blocks:
  Show dependency tree
 
Reported: 2024-02-14 17:15 UTC by Michał Górny
Modified: 2024-03-03 17:30 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-02-14 17:15:35 UTC
I'm looking at dev-python/reflink right now.  I think it would be useful to have a friendly way of disabling userpriv just for the test phase, similarly to how we do it for test_network.
Comment 1 Larry the Git Cow gentoo-dev 2024-02-21 02:14:00 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=997058a825a340813532bef77a34425cf4a88eb2

commit 997058a825a340813532bef77a34425cf4a88eb2
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2024-02-15 15:33:03 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-02-21 02:13:45 +0000

    Support PROPERTIES=test_userpriv not to drop perms for tests
    
    Support PROPERTIES=test_userpriv and a corresponding ALLOW_TEST=userpriv
    to disable FEATURES=userpriv when running the test phase.  This can be
    used e.g. in dev-python/reflink that needs to be able to mount
    filesystem on a loopback device for testing.
    
    Bug: https://bugs.gentoo.org/924585
    Signed-off-by: Michał Górny <mgorny@gentoo.org>
    Closes: https://github.com/gentoo/portage/pull/1274
    Signed-off-by: Sam James <sam@gentoo.org>

 bin/phase-functions.sh                 | 3 ++-
 lib/portage/package/ebuild/config.py   | 3 +++
 lib/portage/package/ebuild/doebuild.py | 3 +++
 man/ebuild.5                           | 5 +++++
 man/make.conf.5                        | 4 ++++
 5 files changed, 17 insertions(+), 1 deletion(-)
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-02-21 13:17:52 UTC
Oops, I didn't update the commit message.
Comment 3 Larry the Git Cow gentoo-dev 2024-02-22 07:24:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=77c44c46194922509bc4f2b5cfc099412a560a69

commit 77c44c46194922509bc4f2b5cfc099412a560a69
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-02-22 07:23:40 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-02-22 07:23:50 +0000

    sys-apps/portage: add 3.0.62
    
    Closes: https://bugs.gentoo.org/663324
    Closes: https://bugs.gentoo.org/728046
    Closes: https://bugs.gentoo.org/891137
    Closes: https://bugs.gentoo.org/906368
    Closes: https://bugs.gentoo.org/916566
    Closes: https://bugs.gentoo.org/921170
    Closes: https://bugs.gentoo.org/921208
    Closes: https://bugs.gentoo.org/921400
    Closes: https://bugs.gentoo.org/922038
    Closes: https://bugs.gentoo.org/922142
    Closes: https://bugs.gentoo.org/923368
    Closes: https://bugs.gentoo.org/923750
    Closes: https://bugs.gentoo.org/923841
    Closes: https://bugs.gentoo.org/923852
    Closes: https://bugs.gentoo.org/923854
    Closes: https://bugs.gentoo.org/924192
    Closes: https://bugs.gentoo.org/924273
    Closes: https://bugs.gentoo.org/924585
    Closes: https://bugs.gentoo.org/921380
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/portage/Manifest              |   1 +
 sys-apps/portage/portage-3.0.62.ebuild | 246 +++++++++++++++++++++++++++++++++
 2 files changed, 247 insertions(+)
Comment 4 Larry the Git Cow gentoo-dev 2024-02-24 10:26:16 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=36b784c051ff4acfea0abf0e0dd7a6035dedcf97

commit 36b784c051ff4acfea0abf0e0dd7a6035dedcf97
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2024-02-22 10:42:38 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2024-02-24 10:26:12 +0000

    metadata/layout.conf: Recognize PROPERTIES=test_privileged
    
    Bug: https://bugs.gentoo.org/924585
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 metadata/layout.conf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 5 Larry the Git Cow gentoo-dev 2024-03-03 17:30:45 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/pms.git/commit/?id=1a669f3ce2ac6b6cf4c96be16dfea0b5621a938d

commit 1a669f3ce2ac6b6cf4c96be16dfea0b5621a938d
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2024-02-21 15:45:01 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2024-03-03 17:29:40 +0000

    ebuild-vars.tex: Add "test_privileged" to valid "PROPERTIES"
    
    Add "test_privileged" to the values of "PROPERTIES", as introduced
    in Portage commit 997058a825a340813532bef77a34425cf4a88eb2 (to be
    included in 3.0.62).  This is akin to "test_network", used to indicate
    that the test suite needs superuser privileges.
    
    Bug: https://bugs.gentoo.org/924585
    Signed-off-by: Michał Górny <mgorny@gentoo.org>
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 ebuild-vars.tex | 2 ++
 1 file changed, 2 insertions(+)