Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 905928 - Migration to more descriptive "keyring" USE flag
Summary: Migration to more descriptive "keyring" USE flag
Status: RESOLVED FIXED
Alias: None
Product: Quality Assurance
Classification: Unclassified
Component: Trackers (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Quality Assurance Team
URL:
Whiteboard:
Keywords: PullRequest
Depends on: 829730
Blocks:
  Show dependency tree
 
Reported: 2023-05-08 08:52 UTC by Pacho Ramos
Modified: 2023-05-22 12:49 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2023-05-08 08:52:21 UTC
Recently I needed to manually enable a "secret" USE flag for a package and I remembered that finally this issue was still pending since:
https://archives.gentoo.org/gentoo-dev/message/5c127aed355ee19d15ac38e114097f74 (2014)
https://archives.gentoo.org/gentoo-dev/message/6005bcbec69709b02f1ed0f678e2ae46 (2021)

In summary I think the most consensous was on migrating to more general "keyring" USE flag and only rely on specific "gnome-keyring", "kwallet" when more options are available for the same package 

I open then the bug for trying to "push" a bit the migration... but I guess a first step would be to add "keyring" to profiles/use.desc:
keyring - Enable support for storing passwords
Comment 1 Andreas Sturmlechner gentoo-dev 2023-05-14 12:32:12 UTC
What about these packages:

mate-extra/mate-power-manager:
libsecret - Support locking of keyring via app-crypt/libsecret

net-p2p/retroshare:
autologin - Enables potentially insecure autologin capability via app-crypt/libsecret

Otherwise there are app-crypt/zulucrypt and x11-plugins/wmudmount with "libsecret" having the exact same meaning as gnome-keyring/keyring.

To incorporate all these uses, we could choose a more broad description such as

"Enable support for freedesktop.org Secret Service API password store"

instead of

"Enable support for storing passwords via freedesktop.org Secret Service API"
Comment 2 Larry the Git Cow gentoo-dev 2023-05-18 12:17:27 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=68cc8c2252fbcd2e0de23e5d01ecb73fbaf2c3b8

commit 68cc8c2252fbcd2e0de23e5d01ecb73fbaf2c3b8
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-05-14 12:41:00 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-05-18 12:09:11 +0000

    net-p2p/retroshare: Rename USE=autologin -> keyring
    
    Bug: https://bugs.gentoo.org/905928
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 net-p2p/retroshare/metadata.xml               | 1 -
 net-p2p/retroshare/retroshare-0.6.6-r1.ebuild | 8 ++++----
 2 files changed, 4 insertions(+), 5 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d00707d49a9182d7005288c23ba2baea5c621dcc

commit d00707d49a9182d7005288c23ba2baea5c621dcc
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-05-14 11:50:49 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-05-18 12:09:04 +0000

    profiles: hppa,m68k,s390: Mask keyring where gnome-keyring was masked
    
    Bug: https://bugs.gentoo.org/905928
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 profiles/arch/hppa/use.mask | 1 +
 profiles/arch/m68k/use.mask | 2 +-
 profiles/arch/s390/use.mask | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=51b7ec3efbb96b5673e49f0c6741319b1ba04784

commit 51b7ec3efbb96b5673e49f0c6741319b1ba04784
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-05-14 12:24:31 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-05-18 12:09:03 +0000

    profiles: targets/desktop/gnome: Set USE=keyring in make.defaults
    
    Drop USE=libsecret while at it.
    
    Bug: https://bugs.gentoo.org/905928
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 profiles/targets/desktop/gnome/make.defaults | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a5aee4d5834c06fae1a20453a62acedceabd6d3f

commit a5aee4d5834c06fae1a20453a62acedceabd6d3f
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-05-14 11:10:20 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-05-18 12:07:42 +0000

    profiles: use.desc: Add USE=keyring
    
    Enable support for freedesktop.org Secret Service API password store
    
    Previous discussions:
    https://archives.gentoo.org/gentoo-dev/message/5c127aed355ee19d15ac38e114097f74
    https://archives.gentoo.org/gentoo-dev/message/6005bcbec69709b02f1ed0f678e2ae46
    
    Closes: https://github.com/gentoo/gentoo/pull/31035
    Bug: https://bugs.gentoo.org/829730
    Bug: https://bugs.gentoo.org/905928
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 profiles/use.desc | 1 +
 1 file changed, 1 insertion(+)
Comment 3 Pacho Ramos gentoo-dev 2023-05-18 14:06:05 UTC
Thanks a lot!