Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 829730 - dev-libs/qtkeychain-0.13.2: Misleading USE-flag: gnome-keyring
Summary: dev-libs/qtkeychain-0.13.2: Misleading USE-flag: gnome-keyring
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-21 02:01 UTC by tastytea
Modified: 2021-12-23 08:24 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tastytea 2021-12-21 02:01:32 UTC
The gnome-keyring flag toggles libsecret support and pulls in app-crypt/libsecret which pulls in virtual/secret-service which depends on gnome-base/gnome-keyring or app-admin/keepassxc. It will probably support kwallet in the future too.

The flag should be renamed IMO. mate-extra/mate-power-manager uses "libsecret" and x11-plugins/wmudmount uses "secret" for this purpose.
Comment 1 Andreas Sturmlechner gentoo-dev 2021-12-21 10:04:10 UTC
At the time of adding it, that was the standard. Imo this is a call to find a proper global IUSE. See also the fact that wmudmount and mate-power-manager couldn't even settle for a common flag around libsecret.

There is also app-containers/docker-credential-helpers with gnome-keyring and the following description: "Build secretservice helper which works with gnome-keyring or kwallet using D-Bus."

Library names as IUSE should be avoided so a name describing the function should be found.
Comment 2 Bernard Cafarelli gentoo-dev 2021-12-23 08:23:17 UTC
+1 on a proper global name, I think at the time I renamed USE flag for wmudmount when upstream switched from gnome-keyring to gcr+libsecret (for same functionality) so I just picked "secret". But this can be renamed to a proper one no problem