Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 829730 - dev-libs/qtkeychain-0.13.2: Misleading USE-flag: gnome-keyring
Summary: dev-libs/qtkeychain-0.13.2: Misleading USE-flag: gnome-keyring
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 905928
  Show dependency tree
 
Reported: 2021-12-21 02:01 UTC by tastytea
Modified: 2023-05-18 13:56 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tastytea 2021-12-21 02:01:32 UTC
The gnome-keyring flag toggles libsecret support and pulls in app-crypt/libsecret which pulls in virtual/secret-service which depends on gnome-base/gnome-keyring or app-admin/keepassxc. It will probably support kwallet in the future too.

The flag should be renamed IMO. mate-extra/mate-power-manager uses "libsecret" and x11-plugins/wmudmount uses "secret" for this purpose.
Comment 1 Andreas Sturmlechner gentoo-dev 2021-12-21 10:04:10 UTC
At the time of adding it, that was the standard. Imo this is a call to find a proper global IUSE. See also the fact that wmudmount and mate-power-manager couldn't even settle for a common flag around libsecret.

There is also app-containers/docker-credential-helpers with gnome-keyring and the following description: "Build secretservice helper which works with gnome-keyring or kwallet using D-Bus."

Library names as IUSE should be avoided so a name describing the function should be found.
Comment 2 Bernard Cafarelli gentoo-dev 2021-12-23 08:23:17 UTC
+1 on a proper global name, I think at the time I renamed USE flag for wmudmount when upstream switched from gnome-keyring to gcr+libsecret (for same functionality) so I just picked "secret". But this can be renamed to a proper one no problem
Comment 3 Larry the Git Cow gentoo-dev 2023-05-18 12:17:28 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1b3c726dfe714824d3a5af713e3290749b2cb2ec

commit 1b3c726dfe714824d3a5af713e3290749b2cb2ec
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-05-14 12:09:23 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-05-18 12:09:04 +0000

    net-misc/owncloud-client: Rename USE=gnome-keyring -> keyring
    
    USEdep fixup follow-up after dev-libs/qtkeychain change.
    
    Bug: https://bugs.gentoo.org/829730
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 net-misc/owncloud-client/owncloud-client-3.1.0.9872.ebuild  | 4 ++--
 net-misc/owncloud-client/owncloud-client-3.2.0.10193.ebuild | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5c3ae0f33b4639fa4ed8f2183ffedf9510901c12

commit 5c3ae0f33b4639fa4ed8f2183ffedf9510901c12
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-05-14 11:08:05 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-05-18 12:09:04 +0000

    dev-libs/qtkeychain: add 0.14.0
    
    Bug: https://bugs.gentoo.org/829730
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-libs/qtkeychain/Manifest                 |  1 +
 dev-libs/qtkeychain/qtkeychain-0.14.0.ebuild | 45 ++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=95811d5b5d1d46289f05c53a2299fe0a4f99a152

commit 95811d5b5d1d46289f05c53a2299fe0a4f99a152
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-05-14 12:05:14 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-05-18 12:09:04 +0000

    dev-libs/qtkeychain: Rename USE=gnome-keyring -> keyring
    
    Bug: https://bugs.gentoo.org/829730
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-libs/qtkeychain/qtkeychain-0.13.2.ebuild | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a5aee4d5834c06fae1a20453a62acedceabd6d3f

commit a5aee4d5834c06fae1a20453a62acedceabd6d3f
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-05-14 11:10:20 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-05-18 12:07:42 +0000

    profiles: use.desc: Add USE=keyring
    
    Enable support for freedesktop.org Secret Service API password store
    
    Previous discussions:
    https://archives.gentoo.org/gentoo-dev/message/5c127aed355ee19d15ac38e114097f74
    https://archives.gentoo.org/gentoo-dev/message/6005bcbec69709b02f1ed0f678e2ae46
    
    Closes: https://github.com/gentoo/gentoo/pull/31035
    Bug: https://bugs.gentoo.org/829730
    Bug: https://bugs.gentoo.org/905928
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 profiles/use.desc | 1 +
 1 file changed, 1 insertion(+)