Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 891585 - kde-apps/k3b: untangle from media-video/transcode
Summary: kde-apps/k3b: untangle from media-video/transcode
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard: fixed in 22.12.2
Keywords: InOverlay
Depends on: kde-gear-22.12.3-stable
Blocks: 831482 861311
  Show dependency tree
 
Reported: 2023-01-21 09:34 UTC by Michał Górny
Modified: 2023-08-08 21:57 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
k3b.patch (k3b.patch,1.94 KB, patch)
2023-04-02 21:13 UTC, Konstantin Münning
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-01-21 09:34:36 UTC
media-video/transcode is dead and buried, and needs to go.  However, k3b depends on it over dvd+encode flags, and both flags seem to be used for something else as well, so no clue how hard it is to untangle it actually.
Comment 1 Larry the Git Cow gentoo-dev 2023-01-30 21:01:37 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=922fbdd8be012b4d8c9c936a0fdcfa8cd48058b8

commit 922fbdd8be012b4d8c9c936a0fdcfa8cd48058b8
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-01-30 20:59:06 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-01-30 20:59:06 +0000

    kde-apps/k3b: Drop IUSE transcode, mp3, sox
    
    Bug: https://bugs.gentoo.org/891585
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 kde-apps/k3b/k3b-22.12.49.9999.ebuild | 21 ++++++---------------
 kde-apps/k3b/k3b-9999.ebuild          | 21 ++++++---------------
 2 files changed, 12 insertions(+), 30 deletions(-)
Comment 2 Konstantin Münning 2023-04-02 21:12:42 UTC
This commit removes all encoding capabilities (mp3, sox), which is somewhat overshooting the task as they don't actually depend on media-video/transcode. Maybe the ebuild maintainer found it meaningful to have encode use flag connected to all encoding features but transcode actually is only needed for DVD. Removing all encoding capabilities of k3b disables one of the main features of that tool so please return mp3 and sox back.

By the way, just removing the media-video/transcode dependency would also do the trick as k3b dynamically detects existing tools on startup, so a missing transcode will not hurt anything which does not depend on it.
Comment 3 Konstantin Münning 2023-04-02 21:13:58 UTC
Created attachment 859452 [details, diff]
k3b.patch

This patch removes only media-video/transcode without removing other encoding capabilities.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-04-06 01:59:28 UTC
(In reply to Konstantin Münning from comment #3)
> Created attachment 859452 [details, diff] [details, diff]
> k3b.patch
> 
> This patch removes only media-video/transcode without removing other
> encoding capabilities.

Please file a new bug with this patch & your request.
Comment 5 Larry the Git Cow gentoo-dev 2023-07-06 12:00:27 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=a108fdfe12ad87b18b63991d86009ac01b41bf2d

commit a108fdfe12ad87b18b63991d86009ac01b41bf2d
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-07-06 11:56:10 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-07-06 11:57:40 +0000

    kde-apps/k3b: Re-enable external encoder plugin
    
    Hard-disable transcode in code by reverting upstream commit
    f7d385a40cc062fa4db46c165f82f437dea82c58.
    
    Bug: https://bugs.gentoo.org/891585
    Bug: https://bugs.gentoo.org/906526
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../k3b/files/k3b-23.04.2-disable-transcode.patch  | 38 ++++++++++++++++++++++
 kde-apps/k3b/k3b-23.04.49.9999.ebuild              |  4 ++-
 kde-apps/k3b/k3b-9999.ebuild                       |  4 ++-
 3 files changed, 44 insertions(+), 2 deletions(-)
Comment 6 Larry the Git Cow gentoo-dev 2023-07-06 12:13:07 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c65bd23152d13d499b085a6854efac9ad3eb4cc2

commit c65bd23152d13d499b085a6854efac9ad3eb4cc2
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-07-06 11:56:10 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-07-06 12:12:51 +0000

    kde-apps/k3b: Re-enable external encoder plugin
    
    Hard-disable transcode in code by reverting upstream commit
    f7d385a40cc062fa4db46c165f82f437dea82c58.
    
    Bug: https://bugs.gentoo.org/891585
    Closes: https://bugs.gentoo.org/906526
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../k3b/files/k3b-23.04.2-disable-transcode.patch  | 38 ++++++++++++++++++++++
 .../{k3b-23.04.2.ebuild => k3b-23.04.2-r1.ebuild}  |  4 ++-
 2 files changed, 41 insertions(+), 1 deletion(-)