Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 906526 - kde-apps/k3b-23.04.01 has no way to enable flac encoder
Summary: kde-apps/k3b-23.04.01 has no way to enable flac encoder
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Gentoo KDE team
URL: https://forums.gentoo.org/viewtopic-t...
Whiteboard:
Keywords:
Depends on:
Blocks: kde-gear-23.04.2-stable
  Show dependency tree
 
Reported: 2023-05-16 07:04 UTC by Stephen Bosch
Modified: 2023-07-06 12:13 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen Bosch 2023-05-16 07:04:41 UTC
After the transcode USE flag was removed (see bug 891585), all the encoders except ogg-vorbis also vanished (see bug 904010). Unfortunately, that commit did not restore the external encoder plugin, which k3b needs to encode to flac.

> Ripping to flac/mp3 both require the build option:
> -DK3B_BUILD_EXTERNAL_ENCODER_PLUGIN=ON

This could be resolved one of two ways that I can see:

1. Make -DK3B_BUILD_EXTERNAL_ENCODER_PLUGIN=ON also be set by the existing flac USE flag, or

2. Create a new local USE flag, say 'encoder' or 'external' that builds the external encoder plugin.
Comment 1 Larry the Git Cow gentoo-dev 2023-07-06 12:00:26 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=a108fdfe12ad87b18b63991d86009ac01b41bf2d

commit a108fdfe12ad87b18b63991d86009ac01b41bf2d
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-07-06 11:56:10 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-07-06 11:57:40 +0000

    kde-apps/k3b: Re-enable external encoder plugin
    
    Hard-disable transcode in code by reverting upstream commit
    f7d385a40cc062fa4db46c165f82f437dea82c58.
    
    Bug: https://bugs.gentoo.org/891585
    Bug: https://bugs.gentoo.org/906526
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../k3b/files/k3b-23.04.2-disable-transcode.patch  | 38 ++++++++++++++++++++++
 kde-apps/k3b/k3b-23.04.49.9999.ebuild              |  4 ++-
 kde-apps/k3b/k3b-9999.ebuild                       |  4 ++-
 3 files changed, 44 insertions(+), 2 deletions(-)
Comment 2 Larry the Git Cow gentoo-dev 2023-07-06 12:13:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c65bd23152d13d499b085a6854efac9ad3eb4cc2

commit c65bd23152d13d499b085a6854efac9ad3eb4cc2
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2023-07-06 11:56:10 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2023-07-06 12:12:51 +0000

    kde-apps/k3b: Re-enable external encoder plugin
    
    Hard-disable transcode in code by reverting upstream commit
    f7d385a40cc062fa4db46c165f82f437dea82c58.
    
    Bug: https://bugs.gentoo.org/891585
    Closes: https://bugs.gentoo.org/906526
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../k3b/files/k3b-23.04.2-disable-transcode.patch  | 38 ++++++++++++++++++++++
 .../{k3b-23.04.2.ebuild => k3b-23.04.2-r1.ebuild}  |  4 ++-
 2 files changed, 41 insertions(+), 1 deletion(-)