Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 886161 - app-shells/fish-3.5.1 fails tests (DASH-SYSTEM): 93 - check-completions.fish / 166 - redirect.fish
Summary: app-shells/fish-3.5.1 fails tests (DASH-SYSTEM): 93 - check-completions.fish ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: idealseal
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-15 19:18 UTC by Agostino Sarubbo
Modified: 2025-03-13 17:08 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,163.58 KB, text/plain)
2022-12-15 19:18 UTC, Agostino Sarubbo
Details
emerge info (einfo,6.45 KB, text/plain)
2023-11-15 19:34 UTC, bschnzl
Details
build.log (build.log,126.87 KB, text/x-log)
2023-11-15 19:34 UTC, bschnzl
Details
environment (environment,127.14 KB, text/plain)
2023-11-15 19:35 UTC, bschnzl
Details
emerge spec (em-pqv,120 bytes, text/plain)
2023-11-15 23:32 UTC, bschnzl
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-12-15 19:18:47 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-shells/fish-3.5.1 fails tests (DASH-SYSTEM).
Discovered on: amd64 (internal ref: dash_tinderbox)

NOTE:
(DASH-SYSTEM) in the summary means that the bug was found on a machine that runs /bin/sh as dash but this bug MAY or MAY NOT BE related to dash.
Comment 1 Agostino Sarubbo gentoo-dev 2022-12-15 19:18:50 UTC
Created attachment 842911 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-12-15 19:18:51 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


	 93 - check-completions.fish (Failed)
	166 - redirect.fish (Failed)
    open: Permission denied
    open: Permission denied <= does not match CHECKERR 'warning: Path \'/bin/echo\' is not a directory' on line 144
FAILED: CMakeFiles/fish_run_tests /var/tmp/portage/app-shells/fish-3.5.1/work/fish-3.5.1_build/CMakeFiles/fish_run_tests
Comment 3 bschnzl 2023-11-15 19:30:47 UTC
168/245 Test #170: redirect.fish.............................***Failed    0.49 sec
Testing file checks/redirect.fish ... Failure:

  The CHECKERR on line 144 wants:
    warning: Path '/bin/echo' is not a directory
-----------
* ERROR: app-shells/fish-3.6.1::gentoo failed (test phase):
-----------
dash is NOT installed
Comment 4 bschnzl 2023-11-15 19:34:07 UTC
Created attachment 874838 [details]
emerge info
Comment 5 bschnzl 2023-11-15 19:34:28 UTC
Created attachment 874839 [details]
build.log
Comment 6 bschnzl 2023-11-15 19:35:03 UTC
Created attachment 874840 [details]
environment
Comment 7 bschnzl 2023-11-15 23:32:33 UTC
Created attachment 874842 [details]
emerge spec
Comment 8 bschnzl 2023-11-16 01:23:19 UTC
FEATURES="-usersandbox" exposes system defaults and passes test.
Comment 9 Arniiiii 2024-07-03 13:19:50 UTC
reproducible with app-shells/fish-3.7.1
Comment 10 Larry the Git Cow gentoo-dev 2025-03-13 17:08:00 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c449aec6f5bc6a3461c3479c44f6ba7ef95a655f

commit c449aec6f5bc6a3461c3479c44f6ba7ef95a655f
Author:     idealseal <realidealseal@protonmail.com>
AuthorDate: 2025-03-13 14:23:28 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-03-13 17:06:59 +0000

    app-shells/fish: cleanup ebuild, make tests work
    
    Remove all but cargo tests. Upstream has fixes for our test issues but
    they weren't backported to 4.0.1.
    
    Closes: https://bugs.gentoo.org/715976
    Closes: https://bugs.gentoo.org/727684
    Closes: https://bugs.gentoo.org/802873
    Closes: https://bugs.gentoo.org/807742
    Closes: https://bugs.gentoo.org/838187
    Closes: https://bugs.gentoo.org/886161
    Closes: https://bugs.gentoo.org/950051
    Signed-off-by: idealseal <realidealseal@protonmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 app-shells/fish/fish-4.0.1.ebuild | 104 ++++++++++----------------------------
 1 file changed, 28 insertions(+), 76 deletions(-)