Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 950051 - app-shells/fish-3.7.1 fails test checks/check-completions.fish (missing virtualx.eclass?)
Summary: app-shells/fish-3.7.1 fails test checks/check-completions.fish (missing virtu...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: idealseal
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-21 23:35 UTC by Jonathan Lovelace
Modified: 2025-03-13 17:07 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
app-shells:fish-3.7.1:20250221-161602.log (app-shells:fish-3.7.1:20250221-161602.log,137.55 KB, text/plain)
2025-02-21 23:35 UTC, Jonathan Lovelace
Details
emerge-info.txt (emerge-info.txt,9.62 KB, text/plain)
2025-02-21 23:35 UTC, Jonathan Lovelace
Details
LastTest.log (LastTest.log,192.99 KB, text/plain)
2025-02-21 23:46 UTC, Jonathan Lovelace
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Lovelace 2025-02-21 23:35:21 UTC
Created attachment 919651 [details]
app-shells:fish-3.7.1:20250221-161602.log

When rebuilding as part of an "emerge --emptytree" on my new system, =app-shells/fish-3.7.1 fails its test suite, specifically checks/check-completions.fish:

----------------------------
Test project /var/tmp/portage/app-shells/fish-3.7.1/work/fish-3.7.1_build
228/244 Test  #96: check-completions.fish....................***Failed    1.39 sec
Testing file checks/check-completions.fish ... Failure:

  There were no remaining checks left to match stderr:1:
    Failed to connect to X Server.

  Context:
    Failed to connect to X Server. <= no more checks

  when running command:
    ../test/root/bin/fish -C 'set -l fish ../test/root/bin/fish' checks/check-completions.fish

244/244 Test  #63: history_merge
99% tests passed, 1 tests failed out of 244

Total Test time (real) =   6.42 sec

The following tests FAILED:
         96 - check-completions.fish (Failed)
E
------------------

That error message makes me onder if this test (in some conditions) needs to be run under X, and thus the test phase needs virtualx.eclass? But when I tried (in a local overlay) adding virtualx.eclass to the 'inherit' line and changing the 'cmake_build test' line in src_test to 'virtx cmake_build test || die', the error changed to "Couldn't find synaptics properties. No synaptics driver loaded?" but the test still failed (though 'ebuild' then proceeded despite the failure, since virtx runs everything 'nonfatal').

(Because of what I read in, I think, bug #886161, the previous system whose config I've mostly copied to this one had, and thus this one has, the sandbox and usersandbox FEATURES disabled for this package, so I think this is a different failure than was reported in this test in an earlier version in that bug.)
Comment 1 Jonathan Lovelace 2025-02-21 23:35:53 UTC
Created attachment 919652 [details]
emerge-info.txt
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-02-21 23:37:45 UTC
Could you grab LastTest(s?).txt too?
Comment 3 Jonathan Lovelace 2025-02-21 23:46:25 UTC
Created attachment 919655 [details]
LastTest.log

(This is from running the build again, since I'd just resumed the emptytree process  with "FEATURES=test-fail-continue" toggled on for this package and it'd gotten a few packages in, but it shows the same failure.)
Comment 4 Larry the Git Cow gentoo-dev 2025-03-13 17:07:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c449aec6f5bc6a3461c3479c44f6ba7ef95a655f

commit c449aec6f5bc6a3461c3479c44f6ba7ef95a655f
Author:     idealseal <realidealseal@protonmail.com>
AuthorDate: 2025-03-13 14:23:28 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-03-13 17:06:59 +0000

    app-shells/fish: cleanup ebuild, make tests work
    
    Remove all but cargo tests. Upstream has fixes for our test issues but
    they weren't backported to 4.0.1.
    
    Closes: https://bugs.gentoo.org/715976
    Closes: https://bugs.gentoo.org/727684
    Closes: https://bugs.gentoo.org/802873
    Closes: https://bugs.gentoo.org/807742
    Closes: https://bugs.gentoo.org/838187
    Closes: https://bugs.gentoo.org/886161
    Closes: https://bugs.gentoo.org/950051
    Signed-off-by: idealseal <realidealseal@protonmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 app-shells/fish/fish-4.0.1.ebuild | 104 ++++++++++----------------------------
 1 file changed, 28 insertions(+), 76 deletions(-)