Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 838187 - app-shells/fish-3.4.*: "redirect.fish" tests failed on multiple platform
Summary: app-shells/fish-3.4.*: "redirect.fish" tests failed on multiple platform
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: idealseal
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks: 807742 909803
  Show dependency tree
 
Reported: 2022-04-13 07:46 UTC by Raymond Wong
Modified: 2025-03-13 17:07 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log on amd64 (build-amd64.log,119.79 KB, text/plain)
2022-04-13 07:48 UTC, Raymond Wong
Details
build.log on mips (build-mips.log,122.20 KB, text/plain)
2022-04-13 07:48 UTC, Raymond Wong
Details
build.log on riscv (build-riscv.log,125.32 KB, text/plain)
2022-04-13 07:49 UTC, Raymond Wong
Details
emerge --info on amd64 (emerge-info-amd64,5.88 KB, text/plain)
2022-04-13 07:49 UTC, Raymond Wong
Details
emerge --info on mips (emerge-info-mips,7.05 KB, text/plain)
2022-04-13 07:50 UTC, Raymond Wong
Details
emerge --info on riscv (emerge-info-riscv_unmatched,17.04 KB, text/plain)
2022-04-13 07:51 UTC, Raymond Wong
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Raymond Wong 2022-04-13 07:46:35 UTC
fish-3.4.1 test fails on my amd64/mips/riscv system with the following output:

...
165/229 Test #164: redirect.fish...........................
..***Failed    1.53 sec
Testing file checks/redirect.fish ... Failure:

  The CHECKERR on line 144 wants:
    warning: Path \'/bin/echo\' is not a directory

  which failed to match line stderr:9:
    open: Permission denied

  Context:
    [...] from line 106 (stderr:6):
    read: stdin is closed
    hooray2
    warning: An error occurred while redirecting file \'/bin/echo/file\'
    open: Permission denied <= does not match CHECKERR 'warning: Path \'/bin/echo\' is not a directory' on line 144

  when running command:
    ../test/root/bin/fish checks/redirect.fish
...

99% tests passed, 1 tests failed out of 229

...

The following tests FAILED:
        164 - redirect.fish (Failed)

fish-3.4.0 on amd64/mips would also yield identical failure on the same test; Conversely, fish-3.3.1-r1 on amd64/mips would not.
Comment 1 Raymond Wong 2022-04-13 07:48:01 UTC
Created attachment 770540 [details]
build.log on amd64
Comment 2 Raymond Wong 2022-04-13 07:48:42 UTC
Created attachment 770543 [details]
build.log on mips
Comment 3 Raymond Wong 2022-04-13 07:49:19 UTC
Created attachment 770546 [details]
build.log on riscv
Comment 4 Raymond Wong 2022-04-13 07:49:55 UTC
Created attachment 770549 [details]
emerge --info on amd64
Comment 5 Raymond Wong 2022-04-13 07:50:29 UTC
Created attachment 770552 [details]
emerge --info on mips
Comment 6 Raymond Wong 2022-04-13 07:51:02 UTC
Created attachment 770555 [details]
emerge --info on riscv
Comment 7 Raymond Wong 2022-04-13 08:08:14 UTC
Specifying FEATURES="-sandbox -usersandbox" to disable sandbox during test would resolve the issue somehow.
Probably because "redirect.fish" would attempt redirecting to /bin/echo/file, which is forbidden by default.
Comment 8 Raymond Wong 2022-04-24 06:42:06 UTC
This was done on amd64.
It seems that FEATURES='-usersandbox' is enough to work around this problem.

USE tests started on Sun 24 Apr 2022 02:20:33 PM CST

 FEATURES=' test' failed for =app-shells/fish-3.4.1
    log has been saved as ./tatt/logs/app-shells_fish-3.4.1_use_buUFS
    testsuite logs have been saved as ./tatt/logs/app-shells_fish-3.4.1_use_buUFS.tar
 FEATURES='-sandbox test' failed for =app-shells/fish-3.4.1
    log has been saved as ./tatt/logs/app-shells_fish-3.4.1_use_YUGwg
    testsuite logs have been saved as ./tatt/logs/app-shells_fish-3.4.1_use_YUGwg.tar

USE tests started on Sun 24 Apr 2022 02:26:55 PM CST

FEATURES='-sandbox -usersandbox test' USE='' succeeded for =app-shells/fish-3.4.1

USE tests started on Sun 24 Apr 2022 02:35:59 PM CST

FEATURES='-usersandbox test' USE='' succeeded for =app-shells/fish-3.4.1
Comment 9 Raymond Wong 2022-04-24 07:12:11 UTC
Can confirm that FEATURES='-usersandbox' also solve the issue on mips/riscv

USE tests started on Sun Apr 24 14:45:30 CST 2022

 FEATURES=' test' failed for =app-shells/fish-3.4.1
    log has been saved as ./tatt/logs/app-shells_fish-3.4.1_use_TvikL
    testsuite logs have been saved as ./tatt/logs/app-shells_fish-3.4.1_use_TvikL.tar
FEATURES='-usersandbox test' USE='' succeeded for =app-shells/fish-3.4.1
Comment 10 John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2024-12-02 01:04:10 UTC
Seems like we might've gotten by this with bug 934533 finishing?
Comment 11 Larry the Git Cow gentoo-dev 2025-03-13 17:07:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c449aec6f5bc6a3461c3479c44f6ba7ef95a655f

commit c449aec6f5bc6a3461c3479c44f6ba7ef95a655f
Author:     idealseal <realidealseal@protonmail.com>
AuthorDate: 2025-03-13 14:23:28 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-03-13 17:06:59 +0000

    app-shells/fish: cleanup ebuild, make tests work
    
    Remove all but cargo tests. Upstream has fixes for our test issues but
    they weren't backported to 4.0.1.
    
    Closes: https://bugs.gentoo.org/715976
    Closes: https://bugs.gentoo.org/727684
    Closes: https://bugs.gentoo.org/802873
    Closes: https://bugs.gentoo.org/807742
    Closes: https://bugs.gentoo.org/838187
    Closes: https://bugs.gentoo.org/886161
    Closes: https://bugs.gentoo.org/950051
    Signed-off-by: idealseal <realidealseal@protonmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 app-shells/fish/fish-4.0.1.ebuild | 104 ++++++++++----------------------------
 1 file changed, 28 insertions(+), 76 deletions(-)