in the ebuild tree files/appmenu-gtk-module uses double square brackets for test condition which fails if /bin/sh is set to dash and probably most shells other than bash Reproducible: Always Steps to Reproduce: 1.point /bin/sh to dash 2.login with startx &> ~/.local/share/xorg/sterr.log (that is in my .zprofile) 3.there will be errors in above log saying: /etc/X11/xinit/xinitrc.d/85-appmenu-gtk-module: [[: not found Actual Results: GTK_MODULES variable gets replaced instead of appended too because the first test falls through to the else condition. UBUNTU_MENUPROXY variable isn't set when it should be because that falls through too. Expected Results: set the correct environment variables when modifying the script to use single square brackets instead of double it works as expected and all the scripts in that directory use single square brackets too
emerge --info Portage 3.0.41 (python 3.10.9-final-0, default/linux/amd64/17.1/desktop/systemd/merged-usr, gcc-12, glibc-2.36-r6, 6.0.12-gentoo x86_64) ================================================================= System uname: Linux-6.0.12-gentoo-x86_64-11th_Gen_Intel-R-_Core-TM-_i9-11900K_@_3.50GHz-with-glibc2.36 KiB Mem: 32711144 total, 26629300 free KiB Swap: 33554428 total, 33554428 free Timestamp of repository gentoo: Thu, 08 Dec 2022 22:30:01 +0000 Head commit of repository gentoo: fde8d7ffb7b7d232992df97de1a4fc804c6ef7e8 Timestamp of repository guru: Thu, 08 Dec 2022 17:01:50 +0000 Head commit of repository guru: 06aee8a92f620a2ba2cafde67ee6f92ef958c330 Timestamp of repository steam-overlay: Tue, 06 Dec 2022 22:03:26 +0000 Head commit of repository steam-overlay: 3d28f5f2cf2d9525860f231ef42fdb9ffb26fc51 sh dash 0.5.11.5 ld GNU ld (Gentoo 2.39 p5) 2.39.0 app-misc/pax-utils: 1.3.5::gentoo app-shells/bash: 5.2_p12::gentoo dev-lang/perl: 5.36.0-r1::gentoo dev-lang/python: 3.10.9::gentoo, 3.11.1::gentoo dev-lang/rust: 1.65.0::gentoo dev-util/cmake: 3.25.1::gentoo dev-util/meson: 0.64.1::gentoo sys-apps/baselayout: 2.9::gentoo sys-apps/sandbox: 2.29::gentoo sys-apps/systemd: 252.2::gentoo sys-devel/autoconf: 2.13-r7::gentoo, 2.71-r5::gentoo sys-devel/automake: 1.16.5::gentoo sys-devel/binutils: 2.39-r4::gentoo sys-devel/binutils-config: 5.4.1::gentoo sys-devel/clang: 15.0.6::gentoo sys-devel/gcc: 12.2.1_p20221203::gentoo sys-devel/gcc-config: 2.8::gentoo sys-devel/libtool: 2.4.7::gentoo sys-devel/lld: 15.0.6::gentoo sys-devel/llvm: 15.0.6::gentoo sys-devel/make: 4.4::gentoo sys-kernel/linux-headers: 6.0::gentoo (virtual/os-headers) sys-libs/glibc: 2.36-r6::gentoo Repositories: gentoo location: /var/db/repos/gentoo sync-type: rsync sync-uri: rsync://rsync.gentoo.org/gentoo-portage priority: -1000 sync-rsync-verify-jobs: 1 sync-rsync-verify-metamanifest: yes sync-rsync-verify-max-age: 24 sync-rsync-extra-opts: guru location: /var/db/repos/guru sync-type: git sync-uri: https://github.com/gentoo-mirror/guru.git masters: gentoo local location: /var/db/repos/local masters: gentoo steam-overlay location: /var/db/repos/steam-overlay sync-type: git sync-uri: https://github.com/gentoo-mirror/steam-overlay.git masters: gentoo ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="@FREE" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=native -O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d" CXXFLAGS="-march=native -O2 -pipe" DISTDIR="/var/cache/distfiles" ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME" FCFLAGS="-march=native -O2 -pipe" FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-march=native -O2 -pipe" GENTOO_MIRRORS="https://mirror.bytemark.co.uk/gentoo/" LANG="en_US.utf8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" LEX="flex" MAKEOPTS="-j16 -l14.4" PKGDIR="/var/cache/binpkgs" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" SHELL="/bin/zsh" USE="X a52 aac acl acpi alsa amd64 bluetooth branding bzip2 cairo cdda cli crypt dbus dri dts encode exif flac fortran gdbm gif gtk gui iconv icu ipv6 jpeg lcms libglvnd libnotify libtirpc mad mng mp3 mp4 mpeg multilib ncurses nls nptl nvenc nvidia ogg opencl opengl openmp pam pango pcre pdf pipewire png policykit ppds pulseaudio qt5 readline screencast sdl seccomp spell ssl startup-notification svg systemd test-rust tiff tpm truetype udev udisks unicode upower usb user-session vdpau verify-sig vorbis vulkan wayland wxwidgets x264 xattr xcb xml xv xvid zlib zsh-completion" ABI_X86="64" ADA_TARGET="gnat_2021" ALSA_CARDS="ca0132" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_10" PYTHON_TARGETS="python3_10" RUBY_TARGETS="ruby31" USERLAND="GNU" VIDEO_CARDS="nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EMERGE_DEFAULT_OPTS, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Created attachment 901016 [details, diff] 0001-x11-misc-appmenu-gtk-module-eliminate-bashisms-in-ap.patch
It should be accompanied by a revision bump, really.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=80dcefb50475d15a43b65dca0324807d3d10b97a commit 80dcefb50475d15a43b65dca0324807d3d10b97a Author: Kerin Millar <kfm@plushkava.net> AuthorDate: 2024-08-23 15:05:08 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-08-26 22:54:24 +0000 x11-misc/appmenu-gtk-module: eliminate bashisms in appmenu-gtk-module Closes: https://bugs.gentoo.org/884891 Signed-off-by: Kerin Millar <kfm@plushkava.net> Signed-off-by: Sam James <sam@gentoo.org> x11-misc/appmenu-gtk-module/files/appmenu-gtk-module-r1 | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b3b6229c93f6a57685b81370e8c0d9e46cb68e4f commit b3b6229c93f6a57685b81370e8c0d9e46cb68e4f Author: Sam James <sam@gentoo.org> AuthorDate: 2024-08-26 22:52:26 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-08-26 22:54:06 +0000 x11-misc/appmenu-gtk-module: add 24.05 Note that this really is 24.05. The tarball has 24.02 as a directory inside but this tarball *is* different to that for the real 24.02. Upstream appear to have form for this, given the pkgconfig patch from before too. While here, apply Eli's new automagic gtk mechanism. Bug: https://bugs.gentoo.org/785619 Bug: https://bugs.gentoo.org/884891 Signed-off-by: Sam James <sam@gentoo.org> x11-misc/appmenu-gtk-module/Manifest | 1 + .../appmenu-gtk-module-24.05.ebuild | 77 ++++++++++++++++++++++ .../appmenu-gtk-module-24.05-fix-pkgconfig.patch | 10 +++ ...enu-gtk-module-24.05-no-automagic-unitdir.patch | 56 ++++++++++++++++ .../appmenu-gtk-module/files/appmenu-gtk-module-r1 | 12 ++++ 5 files changed, 156 insertions(+)
