Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 808883 - sci-geosciences/foxtrotgps-1.2.2: doesn't show position with some receivers (PATCH)
Summary: sci-geosciences/foxtrotgps-1.2.2: doesn't show position with some receivers (...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Sci-geo Project
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2021-08-18 13:25 UTC by Maciej S. Szmigiero
Modified: 2021-10-17 04:26 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej S. Szmigiero 2021-08-18 13:25:25 UTC
sci-geosciences/foxtrotgps-1.2.2 needs upstream patch [1], otherwise it won't show GPS position with GPS receivers that don't fill the "status" field.

[1]: https://bazaar.launchpad.net/~foxtrotgps-team/foxtrotgps/trunk/revision/329
Comment 1 Larry the Git Cow gentoo-dev 2021-08-18 19:39:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fd0eed75afb8e3d5377b611d9efc76ae4c5ab0d1

commit fd0eed75afb8e3d5377b611d9efc76ae4c5ab0d1
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-08-18 19:19:26 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-08-18 19:22:53 +0000

    sci-geosciences/foxtrotgps: add upstream patch for some receivers
    
    I've rebased the patch myself and added an extra API check
    to be conservative as the patch didn't apply cleanly to the tarball.
    
    Thanks-to: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
    Closes: https://bugs.gentoo.org/808883
    Signed-off-by: Sam James <sam@gentoo.org>

 .../foxtrotgps-1.2.2-fix-some-receivers.patch      | 33 +++++++++++++++++++++
 .../foxtrotgps/foxtrotgps-1.2.2-r1.ebuild          | 34 ++++++++++++++++++++++
 2 files changed, 67 insertions(+)
Comment 2 Maciej S. Szmigiero 2021-08-18 20:36:58 UTC
Thanks for your quick reaction Sam, however I am afraid that with the modified patch sci-geosciences/foxtrotgps still won't build with gpsd API 9, since libgps_gpsdata.fix.status was only introduced in gpsd API 10 [1].

The existing sci-geosciences/foxtrotgps patch commited in bug 739568 was incorrect, as I have said in that bug [2].


[1]: https://gitlab.com/gpsd/gpsd/-/commit/29991d6ffeb41ecfc8297db68bb68be0128c8514#fbec23e759c01a5d296e7d1e3a17e9b131df6ae4
[2]: https://bugs.gentoo.org/739568#c6
Comment 3 Larry the Git Cow gentoo-dev 2021-10-17 03:59:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1caddd2c85b8c9d6c90d414170dec987000e34a7

commit 1caddd2c85b8c9d6c90d414170dec987000e34a7
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-10-17 03:59:34 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-10-17 03:59:34 +0000

    sci-geosciences/foxtrotgps: fix build with newer gpsd
    
    Closes: https://bugs.gentoo.org/739568
    Closes: https://bugs.gentoo.org/806986
    Closes: https://bugs.gentoo.org/808883
    Signed-off-by: Sam James <sam@gentoo.org>

 .../foxtrotgps-1.2.2-fix-some-receivers.patch      | 29 ++++++++++++++--------
 .../foxtrotgps/foxtrotgps-1.2.2-r1.ebuild          |  2 +-
 2 files changed, 19 insertions(+), 12 deletions(-)
Comment 4 Larry the Git Cow gentoo-dev 2021-10-17 04:26:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e93640d6db2ef27849988cd5258eb4f3b1e8a67e

commit e93640d6db2ef27849988cd5258eb4f3b1e8a67e
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-10-17 04:25:34 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-10-17 04:25:34 +0000

    sci-geosciences/foxtrotgps: fix patch for newer gpsd (again)
    
    I don't think the API define got bumped in 3.23.1?
    
    Closes: https://bugs.gentoo.org/818268
    Closes: https://bugs.gentoo.org/739568
    Closes: https://bugs.gentoo.org/806986
    Closes: https://bugs.gentoo.org/808883
    Signed-off-by: Sam James <sam@gentoo.org>

 .../foxtrotgps/files/foxtrotgps-1.2.2-fix-some-receivers.patch          | 2 +-
 sci-geosciences/foxtrotgps/foxtrotgps-1.2.2-r1.ebuild                   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)