sci-geosciences/foxtrotgps-1.2.2 is available upstream, please bump. In addition to this, patches from https://bazaar.launchpad.net/~foxtrotgps-team/foxtrotgps/trunk/revision/320 https://bugs.launchpad.net/foxtrotgps/+bug/1893537 and https://bazaar.launchpad.net/~foxtrotgps-team/foxtrotgps/trunk/revision/323 are needed to build / use the package successfully with recent versions of sci-geosciences/gpsd and GCC 10.
Created attachment 666053 [details] foxtrotgps ebuild This is an ebuild for the new version. I will attach the patches in the couple of the next comments. Please note that existing in-tree foxtrotgps ebuild is broken (incompatible with recent gpsd and gcc).
Created attachment 666056 [details, diff] patch which fixes compilation with gcc-9 and gcc-10
Created attachment 666062 [details, diff] patch which adapts foxtrotgps to gpsd API version 9
Updated the gpsd API patch at https://bugs.launchpad.net/foxtrotgps/+bug/1893537 to also support gpsd API 10, which places the fix status field in a different place.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=97455176ec93f2d4f072e058918c28f9e02d359d commit 97455176ec93f2d4f072e058918c28f9e02d359d Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2021-08-14 19:58:46 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2021-08-14 19:59:14 +0000 sci-geosciences/foxtrotgps: Drop broken 1.2.0 Broken for months with GCC-10 and gpsd API 9 yet no one noticed. Demoting to ~arch. Closes: https://bugs.gentoo.org/739568 Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> sci-geosciences/foxtrotgps/Manifest | 1 - sci-geosciences/foxtrotgps/foxtrotgps-1.2.0.ebuild | 28 ---------------------- 2 files changed, 29 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e5b3ec269d0eae0d2370ae33c4236e7d3341c74a commit e5b3ec269d0eae0d2370ae33c4236e7d3341c74a Author: Andreas Sturmlechner <asturm@gentoo.org> AuthorDate: 2021-08-14 19:56:42 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2021-08-14 19:59:14 +0000 sci-geosciences/foxtrotgps: 1.2.2 version bump, EAPI-7 bump Thanks-to: Alexander Bezrukov <phmagic@mail.ru> Closes: https://bugs.gentoo.org/739568 Closes: https://bugs.gentoo.org/806986 Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org> sci-geosciences/foxtrotgps/Manifest | 1 + .../foxtrotgps/files/foxtrotgps-1.2.2-gcc10.patch | 24 ++++++++++++++ .../files/foxtrotgps-1.2.2-gpsd-api9.patch | 37 ++++++++++++++++++++++ sci-geosciences/foxtrotgps/foxtrotgps-1.2.2.ebuild | 33 +++++++++++++++++++ 4 files changed, 95 insertions(+)
Thanks for bumping, however the patch committed is slightly incorrect: it has "libgps_gpsdata.status" move to "libgps_gpsdata.fix.status" guarded by API version 9 instead of 10. This means that the package won't build against sci-geosciences/gpsd that has API version 9. For reference please see the upstream fix [1] and the gpsd commit that introduced API version 10 and moved this status field [2]. [1]: https://bazaar.launchpad.net/~foxtrotgps-team/foxtrotgps/trunk/revision/327 [2]: https://gitlab.com/gpsd/gpsd/-/commit/29991d6ffeb41ecfc8297db68bb68be0128c8514#fbec23e759c01a5d296e7d1e3a17e9b131df6ae4
(In reply to Maciej S. Szmigiero from comment #6) > Thanks for bumping, however the patch committed is slightly incorrect: > it has "libgps_gpsdata.status" move to "libgps_gpsdata.fix.status" guarded > by API version 9 instead of 10. > This means that the package won't build against sci-geosciences/gpsd that > has API version 9. > > For reference please see the upstream fix [1] and the gpsd commit that > introduced API version 10 and moved this status field [2]. > > [1]: > https://bazaar.launchpad.net/~foxtrotgps-team/foxtrotgps/trunk/revision/327 > [2]: > https://gitlab.com/gpsd/gpsd/-/commit/ > 29991d6ffeb41ecfc8297db68bb68be0128c8514#fbec23e759c01a5d296e7d1e3a17e9b131df > 6ae4 Ah, sorry, I missed your comment because the bug was closed.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1caddd2c85b8c9d6c90d414170dec987000e34a7 commit 1caddd2c85b8c9d6c90d414170dec987000e34a7 Author: Sam James <sam@gentoo.org> AuthorDate: 2021-10-17 03:59:34 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-10-17 03:59:34 +0000 sci-geosciences/foxtrotgps: fix build with newer gpsd Closes: https://bugs.gentoo.org/739568 Closes: https://bugs.gentoo.org/806986 Closes: https://bugs.gentoo.org/808883 Signed-off-by: Sam James <sam@gentoo.org> .../foxtrotgps-1.2.2-fix-some-receivers.patch | 29 ++++++++++++++-------- .../foxtrotgps/foxtrotgps-1.2.2-r1.ebuild | 2 +- 2 files changed, 19 insertions(+), 12 deletions(-)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e93640d6db2ef27849988cd5258eb4f3b1e8a67e commit e93640d6db2ef27849988cd5258eb4f3b1e8a67e Author: Sam James <sam@gentoo.org> AuthorDate: 2021-10-17 04:25:34 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-10-17 04:25:34 +0000 sci-geosciences/foxtrotgps: fix patch for newer gpsd (again) I don't think the API define got bumped in 3.23.1? Closes: https://bugs.gentoo.org/818268 Closes: https://bugs.gentoo.org/739568 Closes: https://bugs.gentoo.org/806986 Closes: https://bugs.gentoo.org/808883 Signed-off-by: Sam James <sam@gentoo.org> .../foxtrotgps/files/foxtrotgps-1.2.2-fix-some-receivers.patch | 2 +- sci-geosciences/foxtrotgps/foxtrotgps-1.2.2-r1.ebuild | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
