Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 763591 - dev-games/t4k-common: tuxmath fails because of a t4k-common patch not applied
Summary: dev-games/t4k-common: tuxmath fails because of a t4k-common patch not applied
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2021-01-04 21:37 UTC by Xavier Fernández i Marín
Modified: 2021-06-10 12:48 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (einfo,6.85 KB, text/plain)
2021-01-04 21:37 UTC, Xavier Fernández i Marín
Details
fix crash for tuxmath[svg] + build fix.patch (0001-dev-games-t4k-common-fix-crash-for-tuxmath-svg-build.patch,5.45 KB, patch)
2021-01-05 02:32 UTC, Ionen Wolkens
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xavier Fernández i Marín 2021-01-04 21:37:48 UTC
Created attachment 681055 [details]
emerge --info

Hello,

games-kids/tuxmath-2.0.3-r1 crashes when launched. I've traced it and it is apparently due to a problem related to svg. As far as I have been able to understand, there is a solution here:
https://github.com/tux4kids/t4kcommon/pull/5

and Debian has a patch here:
https://sources.debian.org/data/main/t/t4kcommon/0.1.1-6/debian/patches/916060_bugfix.patch

Would it be possible to apply such patch in Gentoo, so that tuxmath can work?


Thank you very much.
Comment 1 Ionen Wolkens gentoo-dev 2021-01-05 02:32:48 UTC
Created attachment 681079 [details, diff]
fix crash for tuxmath[svg] + build fix.patch

Could reproduce the crash, and I put things together.

It might(?) be okay to push straight-to-stable, no code change with USE=-svg (beside declaration fix), and with USE=svg it was broken either way. Doesn't seem to affect tuxtype[svg] but I can't be sure, so change that or ignore patch if in doubt.

What t4k-common really needs is a new release, upstream seems to be considering it.
Comment 2 Xavier Fernández i Marín 2021-01-05 20:28:37 UTC
Seems to work.

Thank you very much Ionen Walkens. I appreciate it. Must the bug then be closed?
Comment 3 Ionen Wolkens gentoo-dev 2021-01-05 20:39:15 UTC
(In reply to Xavier Fernández i Marín from comment #2)
> Seems to work.
good to hear :)

> Must the bug then be closed?
No, I'm just proposing the change so it's not fixed yet. A gentoo developer (I'm not one) needs to review it and consider whether to use or not, will close themselves when fixed.

Thanks for reporting.
Comment 4 Larry the Git Cow gentoo-dev 2021-06-10 11:52:36 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dfffb12847f492c5e489ae5457890b8fc7c45d79

commit dfffb12847f492c5e489ae5457890b8fc7c45d79
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2021-06-09 13:39:02 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2021-06-10 11:51:42 +0000

    games-kids/tuxmath: EAPI-7, -fno-common, and crash fix
    
    Two causes of crashes, mismatch with t4k-common is exposed by
    gcc10+ (blits-to-tmblits patch), and bug #763591 is fixed in
    >=t4k-common-0.1.1-r1 which now depend on.
    
    Thanks to Samuel Bauer for pointing out -fno-common fix
    
    Closes: https://bugs.gentoo.org/763591
    Closes: https://bugs.gentoo.org/795069
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 .../files/tuxmath-2.0.3-blits-to-tmblits.patch     | 36 +++++++++++++
 .../tuxmath/files/tuxmath-2.0.3-fno-common.patch   |  8 +++
 games-kids/tuxmath/tuxmath-2.0.3-r2.ebuild         | 62 ++++++++++++++++++++++
 3 files changed, 106 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c4993b6a7a6daa41d9b5b2efb53dc0a0f5e90d64

commit c4993b6a7a6daa41d9b5b2efb53dc0a0f5e90d64
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2021-06-09 11:43:55 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2021-06-10 11:51:42 +0000

    dev-games/t4k-common: svg, text, and build fix
    
    Three patches fix:
    - tuxmath[svg] crash (bug #763591)
    - tuxmath lacking text with current libsdl
    - set_font_size build (bug #759574)
    
    Bug: https://bugs.gentoo.org/763591
    Closes: https://bugs.gentoo.org/759574
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 .../files/t4k-common-0.1.1-fix-declaration.patch   | 10 +++
 .../files/t4k-common-0.1.1-missing-text.patch      | 14 +++++
 .../files/t4k-common-0.1.1-svg-libxml2.patch       | 73 ++++++++++++++++++++++
 dev-games/t4k-common/t4k-common-0.1.1-r1.ebuild    | 65 +++++++++++++++++++
 4 files changed, 162 insertions(+)
Comment 5 Xavier Fernández i Marín 2021-06-10 12:48:14 UTC
Thank you, Ionen Wolkens.