Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 795069 - games-kids/tuxmath-2.0.3-r1: -fno-common compile error
Summary: games-kids/tuxmath-2.0.3-r1: -fno-common compile error
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: -fno-common
  Show dependency tree
 
Reported: 2021-06-09 08:37 UTC by Samuel Bauer
Modified: 2021-06-10 11:52 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
tuxmath-2.0.3-r1.ebuild.patch (tuxmath-2.0.3-r1.ebuild.patch,814 bytes, patch)
2021-06-09 08:37 UTC, Samuel Bauer
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Bauer 2021-06-09 08:37:02 UTC
Created attachment 714891 [details, diff]
tuxmath-2.0.3-r1.ebuild.patch

The error:

/usr/lib/gcc/x86_64-pc-linux-gnu/10.3.0/../../../../x86_64-pc-linux-gnu/bin/ld: network.o:/var/tmp/portage/games-kids/tuxmath-2.0.3-r1/work/tuxmath_w_fonts-2.0.3/src/network.c:57: multiple definition of `lan_player_info'; menu_lan.o:/var/tmp/portage/games-kids/tuxmath-2.0.3-r1/work/tuxmath_w_fonts-2.0.3/src/menu_lan.c:40: first defined here

A patch for the ebuild is attached there/mnt/gentoo/overlay/bugs/games-kids/tuxmath
Comment 1 Ionen Wolkens gentoo-dev 2021-06-09 08:59:06 UTC
Hadn't realized this has -fno-common issues too, thanks.

I'll do a full review of the t4k packages, there's the old patch for t4k-common I still haven't followed up on too.
Comment 2 Larry the Git Cow gentoo-dev 2021-06-10 11:52:38 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dfffb12847f492c5e489ae5457890b8fc7c45d79

commit dfffb12847f492c5e489ae5457890b8fc7c45d79
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2021-06-09 13:39:02 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2021-06-10 11:51:42 +0000

    games-kids/tuxmath: EAPI-7, -fno-common, and crash fix
    
    Two causes of crashes, mismatch with t4k-common is exposed by
    gcc10+ (blits-to-tmblits patch), and bug #763591 is fixed in
    >=t4k-common-0.1.1-r1 which now depend on.
    
    Thanks to Samuel Bauer for pointing out -fno-common fix
    
    Closes: https://bugs.gentoo.org/763591
    Closes: https://bugs.gentoo.org/795069
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 .../files/tuxmath-2.0.3-blits-to-tmblits.patch     | 36 +++++++++++++
 .../tuxmath/files/tuxmath-2.0.3-fno-common.patch   |  8 +++
 games-kids/tuxmath/tuxmath-2.0.3-r2.ebuild         | 62 ++++++++++++++++++++++
 3 files changed, 106 insertions(+)