Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 759574 - dev-games/t4k-common-0.1.1 : t4k_menu.c: error: conflicting types for set_font_size
Summary: dev-games/t4k-common-0.1.1 : t4k_menu.c: error: conflicting types for set_fon...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: PATCH
: 787107 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-12-12 09:41 UTC by Toralf Förster
Modified: 2021-06-10 11:52 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,17.21 KB, text/plain)
2020-12-12 09:41 UTC, Toralf Förster
Details
dev-games:t4k-common-0.1.1:20201212-011707.log (dev-games:t4k-common-0.1.1:20201212-011707.log,87.32 KB, text/plain)
2020-12-12 09:41 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,183.68 KB, text/plain)
2020-12-12 09:41 UTC, Toralf Förster
Details
environment (environment,65.67 KB, text/plain)
2020-12-12 09:41 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,15.80 KB, application/x-bzip)
2020-12-12 09:41 UTC, Toralf Förster
Details
logs.tbz2 (logs.tbz2,14.89 KB, application/x-bzip)
2020-12-12 09:41 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,27.73 KB, application/x-bzip)
2020-12-12 09:41 UTC, Toralf Förster
Details
/etc/portage/patches/dev-games/t4k-common-0.1.1/set_font_size.patch (set_font_size.patch,530 bytes, patch)
2021-03-23 12:40 UTC, Cyp
Details | Diff
fix crash on tuxmath startup (fix-null-sscanf.patch,1.16 KB, patch)
2021-03-28 11:36 UTC, Mr.Chauv
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2020-12-12 09:41:20 UTC
      |                        ^~
t4k_menu.c: At top level:
t4k_menu.c:1264:6: error: conflicting types for ‘set_font_size’
 1264 | void set_font_size(bool uniform)
      |      ^~~~~~~~~~~~~
t4k_menu.c:1265:1: note: an argument type that has a default promotion cannot match an empty parameter name list declaration

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop_gnome-20201207-114500

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-7.3.1
 [2] x86_64-pc-linux-gnu-10.2.0 *
clang version 11.0.0
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/11/bin
/usr/lib/llvm/11
11.0.0
Available Python interpreters, in order of preference:
  [1]   python3.9
  [2]   python3.8 (fallback)
  [3]   python3.7 (fallback)
  [4]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby25 (with Rubygems)
  [2]   ruby26 (with Rubygems)
  [3]   ruby27 (with Rubygems) *
Available Rust versions:
  [1]   rust-1.48.0 *
The following VMs are available for generation-2:
*)	AdoptOpenJDK 8.272_p10 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   openjdk-bin-8  system-vm

The Glorious Glasgow Haskell Compilation System, version 8.8.4

  timestamp(s) of HEAD at this tinderbox image:
/var/db/repos/gentoo	Sat Dec 12 12:35:11 AM UTC 2020

emerge -qpvO dev-games/t4k-common
[ebuild  N    ] dev-games/t4k-common-0.1.1  USE="svg"
Comment 1 Toralf Förster gentoo-dev 2020-12-12 09:41:21 UTC
Created attachment 678094 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2020-12-12 09:41:23 UTC
Created attachment 678097 [details]
dev-games:t4k-common-0.1.1:20201212-011707.log
Comment 3 Toralf Förster gentoo-dev 2020-12-12 09:41:25 UTC
Created attachment 678100 [details]
emerge-history.txt
Comment 4 Toralf Förster gentoo-dev 2020-12-12 09:41:26 UTC
Created attachment 678103 [details]
environment
Comment 5 Toralf Förster gentoo-dev 2020-12-12 09:41:27 UTC
Created attachment 678106 [details]
etc.portage.tbz2
Comment 6 Toralf Förster gentoo-dev 2020-12-12 09:41:28 UTC
Created attachment 678109 [details]
logs.tbz2
Comment 7 Toralf Förster gentoo-dev 2020-12-12 09:41:29 UTC
Created attachment 678112 [details]
temp.tbz2
Comment 8 Samuel Bauer 2021-01-14 13:26:57 UTC
My fix is adding:

sed -i -e '154s/()/(bool uniform)/' src/t4k_menu.c

to the src_prepare phase just before eautoreconf.

I know that nowadays gentoo devs prefer patches, it's still not in my workflow for such trivial fixes. Feel free to make the patch according my fix (the error seems a typo to me)
Comment 9 Cyp 2021-03-23 12:40:54 UTC
Created attachment 693234 [details, diff]
/etc/portage/patches/dev-games/t4k-common-0.1.1/set_font_size.patch

This is Comment 8 as a patch.

Saving it as /etc/portage/patches/dev-games/t4k-common-0.1.1/set_font_size.patch automagically fixes the compilation issue for me.
Comment 10 Mr.Chauv 2021-03-28 11:36:06 UTC
Created attachment 695472 [details, diff]
fix crash on tuxmath startup

Additionally to the compile error I had to apply this patch as well. Otherwise tuxmath would crash on startup.
Comment 11 Mr.Chauv 2021-03-28 11:46:11 UTC
(In reply to Mr.Chauv from comment #10)
> Created attachment 695472 [details, diff] [details, diff]
> fix crash on tuxmath startup
> 
> Additionally to the compile error I had to apply this patch as well.
> Otherwise tuxmath would crash on startup.

This patch was stolen from here:
https://bugzilla.redhat.com/show_bug.cgi?id=1665008
Comment 12 Ionen Wolkens gentoo-dev 2021-04-30 20:13:29 UTC
*** Bug 787107 has been marked as a duplicate of this bug. ***
Comment 13 Larry the Git Cow gentoo-dev 2021-06-10 11:52:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c4993b6a7a6daa41d9b5b2efb53dc0a0f5e90d64

commit c4993b6a7a6daa41d9b5b2efb53dc0a0f5e90d64
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2021-06-09 11:43:55 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2021-06-10 11:51:42 +0000

    dev-games/t4k-common: svg, text, and build fix
    
    Three patches fix:
    - tuxmath[svg] crash (bug #763591)
    - tuxmath lacking text with current libsdl
    - set_font_size build (bug #759574)
    
    Bug: https://bugs.gentoo.org/763591
    Closes: https://bugs.gentoo.org/759574
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 .../files/t4k-common-0.1.1-fix-declaration.patch   | 10 +++
 .../files/t4k-common-0.1.1-missing-text.patch      | 14 +++++
 .../files/t4k-common-0.1.1-svg-libxml2.patch       | 73 ++++++++++++++++++++++
 dev-games/t4k-common/t4k-common-0.1.1-r1.ebuild    | 65 +++++++++++++++++++
 4 files changed, 162 insertions(+)