Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 646588 (which-hunt) - [TRACKER] Remove sys-apps/which from @system
Summary: [TRACKER] Remove sys-apps/which from @system
Status: CONFIRMED
Alias: which-hunt
Product: Gentoo Linux
Classification: Unclassified
Component: Profiles (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Quality Assurance Team
URL: https://lwn.net/Articles/874049/
Whiteboard:
Keywords: PullRequest, Tracker
Depends on: 853271 877477 920023 926270 930088 102464 502084 828100 844088 844094 844109 844169 844865 844868 844886 844901 845141 851018 868486
Blocks:
  Show dependency tree
 
Reported: 2018-02-04 17:01 UTC by Michał Górny
Modified: 2024-04-16 02:37 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-02-04 17:01:16 UTC
Let's work on removing sys-apps/which from the @system set. It is not listed as a required command by POSIX, and it is entirely superficial on any system with POSIX shell, with the shell providing a more reliable built-ins that don't reinvent the wheel.

If any packages really rely on which, they should depend on it explicitly and preferably be fixed upstream to use shell builtin 'type -P' or likewise.
Comment 1 Larry the Git Cow gentoo-dev 2022-12-06 05:45:11 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1769ce6cb3a9b6273033158574ed833b11eb7d0d

commit 1769ce6cb3a9b6273033158574ed833b11eb7d0d
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-12-06 05:44:04 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-12-06 05:44:04 +0000

    postgres.eclass: stop using which(1)
    
    It's non-portable and we're looking to remove it from @system.
    
    Bug: https://bugs.gentoo.org/646588
    Signed-off-by: Sam James <sam@gentoo.org>

 eclass/postgres.eclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=da744421aa59fbf4e05b92702dae88dcb7af33d4

commit da744421aa59fbf4e05b92702dae88dcb7af33d4
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-12-06 05:44:03 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-12-06 05:44:03 +0000

    postgres-multi.eclass: stop using which(1)
    
    It's non-portable and we're looking to remove it from @system.
    
    Bug: https://bugs.gentoo.org/646588
    Signed-off-by: Sam James <sam@gentoo.org>

 eclass/postgres-multi.eclass | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=88389031f2b0377f449ed0c6cd65c85a989b8470

commit 88389031f2b0377f449ed0c6cd65c85a989b8470
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-12-06 05:44:03 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-12-06 05:44:03 +0000

    usr-ldscript.eclass: stop using which(1)
    
    It's non-portable and we're looking to remove it from @system.
    
    Bug: https://bugs.gentoo.org/646588
    Signed-off-by: Sam James <sam@gentoo.org>

 eclass/usr-ldscript.eclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=88607de9c44a1b11017ecb7d2d5e8868c48b1695

commit 88607de9c44a1b11017ecb7d2d5e8868c48b1695
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2022-12-06 05:44:03 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2022-12-06 05:44:03 +0000

    toolchain-funcs.eclass: stop using which(1)
    
    It's non-portable and we're looking to remove it from @system.
    
    Bug: https://bugs.gentoo.org/487696
    Bug: https://bugs.gentoo.org/646588
    Signed-off-by: Sam James <sam@gentoo.org>

 eclass/toolchain-funcs.eclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)