Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 502084 - sys-apps/which should be in stage2
Summary: sys-apps/which should be in stage2
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Release Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: which-hunt
  Show dependency tree
 
Reported: 2014-02-22 05:25 UTC by mike@marineau.org
Modified: 2022-05-14 09:05 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description mike@marineau.org 2014-02-22 05:25:49 UTC
I stumbled across this while building stages w/ systemd via catalyst. 'which' is in the @system set but not the build set used by stage1. As a dependency of systemd libseccomp just happened to get built during stage3 before 'which' causing the configure script to fail.

Easily fixed with DEPEND=sys-apps/which or slightly less easily with a patch to use 'type -p' in the configure script.
Comment 1 SpanKY gentoo-dev 2014-02-27 00:22:30 UTC
i think we should just add which to stage2
Comment 2 Jorge Manuel B. S. Vicetto Gentoo Infrastructure gentoo-dev 2014-02-27 00:40:53 UTC
(In reply to SpanKY from comment #1)
> i think we should just add which to stage2

Mike,

to me it seems that adding the dep to libseccomp makes more sense. If there is a strong reason not to add it, then perhaps we can just add it to the list of packages to build on stage1.
Comment 3 SpanKY gentoo-dev 2014-02-28 21:20:42 UTC
(In reply to Jorge Manuel B. S. Vicetto from comment #2)

sys-apps/which is already part of @system precisely because we don't want to track the deps in various packages that use it.  saying "if your package has the potential to end up in a stage1/2/3, then you need to depend on which" doesn't really make sense.
Comment 4 Jorge Manuel B. S. Vicetto Gentoo Infrastructure gentoo-dev 2014-03-01 05:28:51 UTC
(In reply to SpanKY from comment #3)
> sys-apps/which is already part of @system precisely because we don't want to
> track the deps in various packages that use it.  saying "if your package has
> the potential to end up in a stage1/2/3, then you need to depend on which"
> doesn't really make sense.

So any objection to add it to the end of profiles/base/packages?
Comment 5 Jorge Manuel B. S. Vicetto Gentoo Infrastructure gentoo-dev 2014-03-01 18:02:56 UTC
(In reply to Jorge Manuel B. S. Vicetto from comment #4)
> (In reply to SpanKY from comment #3)
> > sys-apps/which is already part of @system precisely because we don't want to
> > track the deps in various packages that use it.  saying "if your package has
> > the potential to end up in a stage1/2/3, then you need to depend on which"
> > doesn't really make sense.
> 
> So any objection to add it to the end of profiles/base/packages?

Sorry, I meant to profiles/default/linux/packages.build and profiles/default/bsd/fbsd/packages.build.
Comment 6 mike@marineau.org 2014-03-01 19:07:40 UTC
(In reply to Jorge Manuel B. S. Vicetto from comment #5)
> (In reply to Jorge Manuel B. S. Vicetto from comment #4)
> > (In reply to SpanKY from comment #3)
> > > sys-apps/which is already part of @system precisely because we don't want to
> > > track the deps in various packages that use it.  saying "if your package has
> > > the potential to end up in a stage1/2/3, then you need to depend on which"
> > > doesn't really make sense.
> > 
> > So any objection to add it to the end of profiles/base/packages?
> 
> Sorry, I meant to profiles/default/linux/packages.build and
> profiles/default/bsd/fbsd/packages.build

That's certainly fine by me, I proposed the same change in CoreOS :)
https://github.com/coreos/coreos-overlay/commit/89edb94573921ba30d800548e59a6073e2a1938b
Comment 7 Jorge Manuel B. S. Vicetto Gentoo Infrastructure gentoo-dev 2014-06-03 02:13:14 UTC
02:11 < irker781> gentoo-x86: jmbsvicetto profiles/default/bsd/fbsd: Add sys-apps/which to the list of packages to build on stage1 - fixes bug 502084.
02:11 < irker781> gentoo-x86: jmbsvicetto profiles/default/linux: Add sys-apps/which to the list of packages to build on stage1 - fixes bug 502084.

Done. Please test the change works. Please reopen the bug if you hit the same issue.
Comment 8 Ulrich Müller gentoo-dev 2022-05-13 09:19:37 UTC
Looks like the which was removed from libseccomp's configure.ac:
https://github.com/seccomp/libseccomp/commit/45b7b49a04eafb544e4bd1768b46a407fc696ff9
I have verified that sys-libs/libseccomp-2.5.3 (the stable version) builds here without sys-apps/which installed.

So I wonder if that change could be reverted? It is contrary to the goal of bug 646588.