Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 579912 - sys-power/pm-utils depends on net-misc/ntp || net-misc/openntpd – mistake?
Summary: sys-power/pm-utils depends on net-misc/ntp || net-misc/openntpd – mistake?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Freedesktop bugs
URL:
Whiteboard:
Keywords: PMASKED
Depends on:
Blocks:
 
Reported: 2016-04-14 07:46 UTC by Beelzebubbie
Modified: 2021-02-21 10:57 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Beelzebubbie 2016-04-14 07:46:35 UTC
pm-utils-1.4.1-r6.ebuild defines ntp IUSE flag, which used in dependency:
ntp? ( || ( net-misc/ntp net-misc/openntpd ) )

Maybe I wrong, but I found no traces of ntp in pm-utils files. Only relevant is Changelog:
commit 3e72a7a5adb9d3b69d45dda327ed5bde5ad2eabc                   
Author: Victor Lowther <victor.lowther@gmail.com>                 
Date:   Sun Nov 30 09:51:38 2008 -0600                            
                                                                  
    Drop 50ntpd                                                   
                                                                  
    ntpd operates normally over a sleep/wake cycle. Stoppping and 
    restarting it in a sleep hook is too adhoc. If it is essential
    that ntpd be stopped and restarted, then having NetworkManager
    do the job when interfaces go offline and come back online is 
    a better way to do things.                                    

And more, this seems strange too:
use ntp || ignore+=" 90clock"
because of /usr/lib/pm-utils/sleep.d/90clock manages hwclock usage, but no ntp stuff

Seems that ntp flag and dependency should be removed, and 90clock ignoring should be changed for something like:
use hwclock || ignore+=" 90clock" # new hwclock flag
Comment 1 faminebadger 2018-01-17 23:52:32 UTC
I guess the ebuild author was trying to say something like:

"If you have installed ntp, I assume you use it to keep the system clock accurate, and therefore we should set the hwclock from the system clock - but if you haven't installed ntp, then you probably didn't sync the system clock, so there's no need to write it to the hwclock".

These days the kernel itself manages the set to/from hwclock, so I don't see why that ignore line should be conditional on anything.
Comment 2 Maciej S. Szmigiero 2019-10-17 17:41:13 UTC
IMHO this package "ntp" USE flag and the dependency it brings should just
be removed and 90clock ignored unconditionally as this pm-utils module is
unnecessary on any remotely modern kernel.

The USE flag dependency also does not take into account the existence of
net-misc/ntpsec.
Comment 3 Larry the Git Cow gentoo-dev 2021-02-21 10:57:18 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f146bb7e14ac3405429772d4adfef555f7810c20

commit f146bb7e14ac3405429772d4adfef555f7810c20
Author:     Jakov Smolic <jakov.smolic@sartura.hr>
AuthorDate: 2021-02-21 10:56:16 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2021-02-21 10:56:16 +0000

    sys-power/pm-utils: Remove last-rited pkg
    
    Closes: https://bugs.gentoo.org/659616
    Closes: https://bugs.gentoo.org/703026
    Closes: https://bugs.gentoo.org/666380
    Closes: https://bugs.gentoo.org/579912
    Closes: https://bugs.gentoo.org/549848
    Closes: https://bugs.gentoo.org/533168
    Closes: https://bugs.gentoo.org/489650
    Closes: https://bugs.gentoo.org/443530
    Closes: https://bugs.gentoo.org/442052
    Closes: https://bugs.gentoo.org/437930
    Closes: https://bugs.gentoo.org/426952
    Closes: https://bugs.gentoo.org/426510
    Closes: https://bugs.gentoo.org/403523
    Closes: https://bugs.gentoo.org/401257
    Closes: https://bugs.gentoo.org/362387
    Closes: https://bugs.gentoo.org/257156
    
    Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>
    Signed-off-by: David Seifert <soap@gentoo.org>

 profiles/arch/amd64/package.use.mask               |  4 -
 profiles/arch/base/package.use.mask                |  4 -
 profiles/arch/hppa/use.mask                        |  4 -
 profiles/arch/x86/package.use.mask                 |  4 -
 sys-power/pm-utils/Manifest                        |  1 -
 .../pm-utils/files/1.4.1-bluetooth-sync.patch      | 43 ----------
 .../pm-utils/files/1.4.1-disable-sata-alpm.patch   | 24 ------
 sys-power/pm-utils/files/1.4.1-echo-n.patch        | 51 ------------
 sys-power/pm-utils/files/1.4.1-fix-alpm-typo.patch | 29 -------
 .../1.4.1-fix-intel-audio-powersave-hook.patch     | 40 ---------
 .../pm-utils/files/1.4.1-ignore-led-failure.patch  | 14 ----
 .../files/1.4.1-inhibit-on-right-status.patch      | 20 -----
 .../pm-utils/files/1.4.1-logging-append.patch      | 17 ----
 .../pm-utils/files/1.4.1-run-hook-logging.patch    | 17 ----
 .../pm-utils/files/1.4.1-suspend-hybrid.patch      | 36 ---------
 .../files/1.4.1-uswsusp-hibernate-mode.patch       | 19 -----
 .../files/1.4.1-xfs_buffer_arguments.patch         | 31 -------
 sys-power/pm-utils/files/pm-utils.logrotate        |  8 --
 sys-power/pm-utils/files/power.d/pci_devices       | 61 --------------
 sys-power/pm-utils/files/power.d/usb_bluetooth     | 45 -----------
 sys-power/pm-utils/files/sleep.d/50unload_alx      | 18 -----
 sys-power/pm-utils/metadata.xml                    | 10 ---
 sys-power/pm-utils/pm-utils-1.4.1-r7.ebuild        | 94 ----------------------
 23 files changed, 594 deletions(-)