Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 351100 - app-portage/portage-utils: qlop: -t does not show correctly when emerge never completed
Summary: app-portage/portage-utils: qlop: -t does not show correctly when emerge never...
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Third-Party Tools (show other bugs)
Hardware: All Linux
: High normal with 4 votes (vote)
Assignee: Fabian Groffen
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-08 09:33 UTC by Andreas Fink
Modified: 2018-04-05 19:02 UTC (History)
11 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
bugfix patch (qlop.patch,1.15 KB, text/plain)
2011-01-08 09:33 UTC, Andreas Fink
Details
Patch for qlop-0.5 (qlop.patch,1.36 KB, patch)
2011-03-20 13:32 UTC, Andreas Fink
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Fink 2011-01-08 09:33:03 UTC
The result on my machine with qlop -tHgv chromium:
chromium-8.0.552.208: Mon Nov 22 00:02:00 2010: 1 hour, 48 minutes, 10 seconds
chromium-8.0.552.210: Wed Nov 24 21:48:11 2010: 2 hours, 1 minute, 58 seconds
chromium-8.0.552.210: Mon Nov 29 00:36:53 2010: 1 hour, 47 minutes, 41 seconds
chromium: 3 times

However I have installed quite a few more times chromium. But the next merge of chromium never completed (because I cancelled).
Attached is a patch which is ugly and dirty, since it just duplicates code already there but at another place where it's needed.

The output with the patched qlop:
chromium-8.0.552.208: Mon Nov 22 00:02:00 2010: 1 hour, 48 minutes, 10 seconds
chromium-8.0.552.210: Wed Nov 24 21:48:11 2010: 2 hours, 1 minute, 58 seconds
chromium-8.0.552.210: Mon Nov 29 00:36:53 2010: 1 hour, 47 minutes, 41 seconds
chromium-8.0.552.224: Tue Dec 14 09:21:16 2010: 2 hours, 1 minute, 17 seconds
chromium-9.0.597.19: Fri Dec 17 08:25:29 2010: 2 hours, 24 minutes, 38 seconds
chromium-9.0.597.19: Tue Dec 28 01:46:20 2010: 1 hour, 56 minutes, 12 seconds
chromium-9.0.597.44: Thu Jan  6 14:00:09 2011: 2 hours, 5 minutes, 35 seconds
chromium: 7 times

Patched against portage-utils-0.4. But all previous versions are affected of the same bug.

Reproducible: Always

Steps to Reproduce:
Comment 1 Andreas Fink 2011-01-08 09:33:48 UTC
Created attachment 259274 [details]
bugfix patch

ugly'n'dirty patch, but it works ;)
Comment 2 Andrew Savchenko gentoo-dev 2011-02-20 21:54:40 UTC
I have the same problem with missed or miscalculated emerge entries.
Patch from Andreas helps, thanks.
Comment 3 Nikolaj Šujskij 2011-03-02 08:23:31 UTC
Fixed with patch for me too, hooray! Thanks for patch, Andreas, I hope it'd hit the tree soon.
Comment 4 Nikolaj Šujskij 2011-03-17 05:59:06 UTC
Seems to be fixed in app-portage/portage-utils-0.5
Comment 5 Andreas Fink 2011-03-20 13:31:49 UTC
portage-utils-0.5 does *NOT* fix the problem completely.
The problem with 0.5 is that a corrupted emerge process forces that the next time the same version is going to be installed. However this is an assumption which in my case is not true (I have a chromium emerge started with version 8.0.552.215 which never completed. The next merge was with version 8.0.552.224, so qlop got confused and showed way to few results).
I will attach a new patch which fixes this issue and can be applied to qlop-0.5.
Comment 6 Andreas Fink 2011-03-20 13:32:44 UTC
Created attachment 266609 [details, diff]
Patch for qlop-0.5
Comment 7 Balint Dobai-Pataky 2016-03-24 15:03:18 UTC
still not fixed in app-portage/portage-utils-0.62
Comment 8 SpanKY gentoo-dev 2016-03-24 15:56:11 UTC
(In reply to Balint Dobai-Pataky from comment #7)

no one said otherwise.  the bug is still open.
Comment 9 Balint Dobai-Pataky 2016-03-25 14:40:22 UTC
Sorry, didn't mean to be offensive, at all.
I just thought to supply info about the new version, for users who use the patched 0.56 version like me.
Comment 10 SpanKY gentoo-dev 2016-03-26 17:24:35 UTC
for portage-utils, the bug flow is controlled enough that bugs get closed when the code is fixed, so things rarely go stale.

at this point, qlop isn't getting too much love as i don't really use it much anymore, and the portage log system is so noisy it's hard to reasonably parse.

to do this reliably, would have to maintain state vs timestamps.
Comment 11 Fabian Groffen gentoo-dev 2018-03-31 07:11:44 UTC
*** Bug 470168 has been marked as a duplicate of this bug. ***
Comment 12 Fabian Groffen gentoo-dev 2018-03-31 18:36:26 UTC
I don't see how treating aborted merges as successful ones is going to be helpful.  I just added a fix for miscalculation in case of aborted merges, but that doesn't show merge attempts either.

Judging from your patch, you use atoms to compare category/package, while the original code compares category/package-version, which is more specific.  The real catch is in t[0] = t[1].  This bit is in the fix I added.
Comment 13 Larry the Git Cow gentoo-dev 2018-04-05 19:02:56 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=34b636503cc7dcabe32b9b377c2eb77cb5fd5575

commit 34b636503cc7dcabe32b9b377c2eb77cb5fd5575
Author:     Fabian Groffen <grobian@gentoo.org>
AuthorDate: 2018-04-05 19:02:10 +0000
Commit:     Fabian Groffen <grobian@gentoo.org>
CommitDate: 2018-04-05 19:02:34 +0000

    app-portage/portage-utils: version bump to 0.70
    
    This release fixes multiple bugs lingering around for a while.
    
    Closes: https://bugs.gentoo.org/651546
    Closes: https://bugs.gentoo.org/646310
    Closes: https://bugs.gentoo.org/645554
    Closes: https://bugs.gentoo.org/643820
    Closes: https://bugs.gentoo.org/638032
    Closes: https://bugs.gentoo.org/608960
    Closes: https://bugs.gentoo.org/607498
    Closes: https://bugs.gentoo.org/558306
    Closes: https://bugs.gentoo.org/526596
    Closes: https://bugs.gentoo.org/470168
    Closes: https://bugs.gentoo.org/351100
    Closes: https://bugs.gentoo.org/335453
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 app-portage/portage-utils/Manifest                 |  2 +-
 .../portage-utils/portage-utils-0.62.ebuild        |  2 +-
 .../portage-utils/portage-utils-0.63.ebuild        | 43 ----------------------
 ...ls-0.64-r1.ebuild => portage-utils-0.70.ebuild} | 16 +-------
 4 files changed, 4 insertions(+), 59 deletions(-)