Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 646310 - app-portage/portage-utils: qlist: also hide /usr/src/debug when --showdebug is not given
Summary: app-portage/portage-utils: qlist: also hide /usr/src/debug when --showdebug i...
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Fabian Groffen
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-01 15:26 UTC by Niklas Haas
Modified: 2018-04-05 19:02 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Example of a trivial patch (file_646310.txt,435 bytes, patch)
2018-02-01 15:28 UTC, Niklas Haas
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Niklas Haas 2018-02-01 15:26:02 UTC
`--showdebug` is an option (off by default) that controls whether or not the qlist output should be cluttered by /usr/lib/debug entries. Since FEATURES="installsources" also installs debugging information to /usr/src/debug, we should also hide files from here unless `--showdebug` is given.

Reproducible: Always

Steps to Reproduce:
1. Enable FEATURES="splitdebug installsources"
2. Emerge a package
3. `qlist NAME`
Actual Results:  
Only the debugging information from /usr/lib/debug is hidden, the source code from /usr/src/debug is still in the output (and often rather verbose and uninteresting).

Expected Results:  
Both debug paths should be occluded by default.

This is a trivial patch, since the decision logic for hiding a filename starting with /usr/lib/debug just needs to be minimally extended.
Comment 1 Niklas Haas 2018-02-01 15:28:23 UTC
Created attachment 517374 [details, diff]
Example of a trivial patch

I have included a trivial example of a patch that fixes this problem.
Comment 2 Larry the Git Cow gentoo-dev 2018-03-26 19:08:49 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=e8c0e327e7e1ec83a63c2c7a6b44567773ec7d94

commit e8c0e327e7e1ec83a63c2c7a6b44567773ec7d94
Author:     Fabian Groffen <grobian@gentoo.org>
AuthorDate: 2018-03-26 19:06:19 +0000
Commit:     Fabian Groffen <grobian@gentoo.org>
CommitDate: 2018-03-26 19:06:19 +0000

    qlist_cb: exclude /usr/src/debug by default too
    
    This is an somewhat alternative take to the patch by
    Niklas Haas <bgo@nand.wakku.to>.
    
    Also exclude /usr/src/debug by default, because it contains a lot of
    clutter.
    
    Bug: https://bugs.gentoo.org/646310

 qlist.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)}
Comment 3 Larry the Git Cow gentoo-dev 2018-04-05 19:02:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=34b636503cc7dcabe32b9b377c2eb77cb5fd5575

commit 34b636503cc7dcabe32b9b377c2eb77cb5fd5575
Author:     Fabian Groffen <grobian@gentoo.org>
AuthorDate: 2018-04-05 19:02:10 +0000
Commit:     Fabian Groffen <grobian@gentoo.org>
CommitDate: 2018-04-05 19:02:34 +0000

    app-portage/portage-utils: version bump to 0.70
    
    This release fixes multiple bugs lingering around for a while.
    
    Closes: https://bugs.gentoo.org/651546
    Closes: https://bugs.gentoo.org/646310
    Closes: https://bugs.gentoo.org/645554
    Closes: https://bugs.gentoo.org/643820
    Closes: https://bugs.gentoo.org/638032
    Closes: https://bugs.gentoo.org/608960
    Closes: https://bugs.gentoo.org/607498
    Closes: https://bugs.gentoo.org/558306
    Closes: https://bugs.gentoo.org/526596
    Closes: https://bugs.gentoo.org/470168
    Closes: https://bugs.gentoo.org/351100
    Closes: https://bugs.gentoo.org/335453
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 app-portage/portage-utils/Manifest                 |  2 +-
 .../portage-utils/portage-utils-0.62.ebuild        |  2 +-
 .../portage-utils/portage-utils-0.63.ebuild        | 43 ----------------------
 ...ls-0.64-r1.ebuild => portage-utils-0.70.ebuild} | 16 +-------
 4 files changed, 4 insertions(+), 59 deletions(-)