genlop bash-completion script should use PORTDIR instead using /usr/portage for portagedir (it is hard-coded atm). sorry, no time to provide a fix now...
Created attachment 64011 [details, diff] Grabs PORTDIR from /etc/make.conf or defaults to /usr/portage
Created attachment 64016 [details, diff] A patch to include in Portage directly.
fixed in next version thank you
Created attachment 70061 [details, diff] Fix for genlop's bash-completion if PORTDIR isn't set in make.conf The attached patch quotes ${portagedir} so it also works when $PORTDIR is not set in /etc/make.conf. Besides, genlop's bash-completion does not complete packages specified without their category on the commandline, unlike emerge's completion does, for example. Therefore i think it's probably good to copy the relevant parts from emerge's completion and implement them here? Maybe i'll try if noone else does, but i'm no bash coder... if bash coding just wouldn't be so ugly :(
Created attachment 70066 [details, diff] Or something like this... Get PORTDIR from make.globals, then get PORTDIR from make.conf, then see if ${portagedir} is a (symlink to a) directory and only if that fails, set ${portagedir} to "/usr/portage".
(In reply to comment #5) > Created an attachment (id=70066) [edit] > Or something like this... > > Get PORTDIR from make.globals, then get PORTDIR from make.conf, then see if > ${portagedir} is a (symlink to a) directory and only if that fails, set > ${portagedir} to "/usr/portage". That's a patch against genlop-0.30.5, btw.
genlop has been moved into gentoo's svn per permission from the original authors to take over maintainership. I've adjusted the sourcing of make.conf to include make.global per the patch offered in this bug and those changes are available in svn, thanks!
