Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 935134 - games-simulation/simutrans-124.1: does not compile with net-libs/miniupnpc-2.2.8 error: too few arguments to function ‘int UPNP_GetValidIGD(UPNPDev*, UPNPUrls*, IGDdatas*, char*, int, char*, int)’
Summary: games-simulation/simutrans-124.1: does not compile with net-libs/miniupnpc-2....
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL: https://forum.simutrans.com/index.php...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-06-29 11:04 UTC by tea
Modified: 2025-02-27 13:34 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build log (simutrans-124.1:20240629-102620.log,110.08 KB, text/x-log)
2024-06-29 11:04 UTC, tea 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description tea 2024-06-29 11:04:40 UTC 
Created attachment 896619 [details]
build log

miniupnpc changed the number of arguments for UPNP_GetValidIGD() in 2.2.8, which causes the simutrans build to fail. this also is true for simutrans-124.0. it works fine with miniupnpc-2.2.7.

i believe this may be problem with more packages.
Comment 1 tea 2024-06-29 11:11:27 UTC 
forgot to add the lik to the miniupnpc changelog: <miniupnp.free.fr/files/changelog.php?file=miniupnpc-2.2.8.tar.gz>

> UPNP_GetValidIGD(): distinguish between not connected and connected to a
>     "private" network (with a reserved IP address).
>   Increments API_VERSION to 18
Comment 2 Larry the Git Cow gentoo-dev 2024-07-26 07:40:34 UTC 
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=84c4b307d7073adfeb1de635e0d6e09819befe92

commit 84c4b307d7073adfeb1de635e0d6e09819befe92
Author:     tastytea <gentoo@tastytea.de>
AuthorDate: 2024-06-29 11:43:18 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2024-07-26 07:40:31 +0000

    games-simulation/simutrans: fix net-libs/miniupnpc dependency
    
    miniupnpc changed API in 2.2.8, simutrans doesn't build with it
      - patch 124.0
      - restrict miniupnpc version in 123.0.1-r2
    
    Bug: https://bugs.gentoo.org/935134
    Signed-off-by: tastytea <gentoo@tastytea.de>
    Closes: https://github.com/gentoo/gentoo/pull/37357
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 games-simulation/simutrans/simutrans-123.0.1-r2.ebuild | 2 +-
 games-simulation/simutrans/simutrans-124.0.ebuild      | 5 ++++-
 2 files changed, 5 insertions(+), 2 deletions(-)
Comment 3 Larry the Git Cow gentoo-dev 2025-02-27 13:34:42 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ab6e0062c94e108d8b9f8840d0cf786453688d5f

commit ab6e0062c94e108d8b9f8840d0cf786453688d5f
Author:     Petr Vaněk <arkamar@gentoo.org>
AuthorDate: 2025-02-27 13:17:08 +0000
Commit:     Petr Vaněk <arkamar@gentoo.org>
CommitDate: 2025-02-27 13:34:07 +0000

    games-simulation/simutrans: drop 124.1
    
    Closes: https://bugs.gentoo.org/935134
    Signed-off-by: Petr Vaněk <arkamar@gentoo.org>

 games-simulation/simutrans/Manifest                |   3 -
 .../files/simutrans-124.1-fix-miniupnpc-api.patch  |  42 --------
 games-simulation/simutrans/simutrans-124.1.ebuild  | 114 ---------------------
 3 files changed, 159 deletions(-)