935134 – games-simulation/simutrans-124.1: does not compile with net-libs/miniupnpc-2.2.8 error: too few arguments to function ‘int UPNP_GetValidIGD(UPNPDev*, UPNPUrls*, IGDdatas*, char*, int, char*, int)’

Bug 935134 - games-simulation/simutrans-124.1: does not compile with net-libs/miniupnpc-2.2.8 error: too few arguments to function ‘int UPNP_GetValidIGD(UPNPDev*, UPNPUrls*, IGDdatas*, char*, int, char*, int)’

Summary: games-simulation/simutrans-124.1: does not compile with net-libs/miniupnpc-2....

Status:	UNCONFIRMED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	tastytea

URL:	https://forum.simutrans.com/index.php...
Whiteboard:
Keywords:	PullRequest

Depends on:
Blocks:

Reported:	2024-06-29 11:04 UTC by tastytea
Modified:	2024-06-29 21:14 UTC (History)
CC List:	2 users (show)

See Also:	https://github.com/gentoo/gentoo/pull/37357
Package list:
Runtime testing required:	---

Attachments
build log (simutrans-124.1:20240629-102620.log,110.08 KB, text/x-log) 2024-06-29 11:04 UTC, tastytea	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description tastytea 2024-06-29 11:04:40 UTC

Created attachment 896619 [details]
build log

miniupnpc changed the number of arguments for UPNP_GetValidIGD() in 2.2.8, which causes the simutrans build to fail. this also is true for simutrans-124.0. it works fine with miniupnpc-2.2.7.

i believe this may be problem with more packages.

Comment 1 tastytea 2024-06-29 11:11:27 UTC

forgot to add the lik to the miniupnpc changelog: <miniupnp.free.fr/files/changelog.php?file=miniupnpc-2.2.8.tar.gz>

> UPNP_GetValidIGD(): distinguish between not connected and connected to a
>     "private" network (with a reserved IP address).
>   Increments API_VERSION to 18