Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 934927 - media-sound/mpd-0.23.15-r1 depends on dev-libs/yajl even without USE=soundcloud
Summary: media-sound/mpd-0.23.15-r1 depends on dev-libs/yajl even without USE=soundcloud
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Adrian Schollmeyer
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-06-25 13:39 UTC by Daniel M. Weeks
Modified: 2024-09-22 13:07 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info mpd (mpd.info,8.03 KB, text/plain)
2024-08-20 15:09 UTC, Filip Kobierski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel M. Weeks 2024-06-25 13:39:12 UTC
It looks like this may be automagic since there is no meson_feature in the ebuild but it appears in the project's meson_options.txt.

On a system with media-sound/mpd-0.23.15-r1 USE="alsa audiofile bzip2 cue dbus eventfd faad ffmpeg fifo flac icu id3tag inotify libsamplerate mad network snapcast sqlite vorbis zlib" yajl was depcleaned since it was no longer needed by any package resulting in the following preserved lib:

>>> package: dev-libs/yajl-2.1.0-r4
 *  - /usr/lib64/libyajl.so.2
 *  - /usr/lib64/libyajl.so.2.1.0
 *      used by /usr/bin/mpd (media-sound/mpd-0.23.15-r1)



Reproducible: Always
Comment 1 Filip Kobierski 2024-08-20 15:09:37 UTC
Created attachment 900788 [details]
emerge --info mpd

I am unable to reproduce this with the use flags:
"alsa audiofile bzip2 cue curl dbus eventfd ffmpeg fifo icu id3tag inotify mad network pipewire sndio zlib"



`lddtree $(which mpd) | grep libyajl` prints nothing
Comment 2 Adrian Schollmeyer 2024-08-20 15:45:28 UTC
I can't reproduce the issue. I first set USE=soundcloud, then emerged, then unset USE=soundcloud and re-emerged. Afterwards, MPD wasn't linked against libyajl.so, although it was present on the system the whole time.

Please add more detailed instructions to reproduce the issue and include a build log, if possible.
Comment 3 Daniel M. Weeks 2024-08-23 01:49:09 UTC
Ah this is caused by USE=snapcast - from meson.build:

if get_option('snapcast')
  output_plugins_sources += [
    'snapcast/SnapcastOutputPlugin.cxx',
    'snapcast/Client.cxx',
  ]
  output_plugins_deps += [ event_dep, net_dep, yajl_dep, zeroconf_dep ]

  output_features.set('HAVE_YAJL', yajl_dep.found())

  need_wave_encoder = true
endif
Comment 4 Larry the Git Cow gentoo-dev 2024-09-22 13:07:12 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7274988e561d1dfd666b5c02d39a98d7db39995e

commit 7274988e561d1dfd666b5c02d39a98d7db39995e
Author:     Adrian Schollmeyer <nex+b-g-o@nexadn.de>
AuthorDate: 2024-09-21 14:42:23 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-09-22 13:06:29 +0000

    media-sound/mpd: optional io-uring, fix yajl deps, support log_file=syslog
    
    This introduces yajl as a new USE flag, controlling whether the program
    should link against dev-libs/yajl. This is needed for two different
    features, hence the new REQUIRED_USE.
    
    Closes: https://bugs.gentoo.org/922980
    Closes: https://bugs.gentoo.org/934927
    Closes: https://bugs.gentoo.org/937264
    
    Signed-off-by: Adrian Schollmeyer <nex+b-g-o@nexadn.de>
    Signed-off-by: Sam James <sam@gentoo.org>

 media-sound/mpd/files/mpd-0.23.15.init-r1 |  61 +++++++
 media-sound/mpd/metadata.xml              |   2 +
 media-sound/mpd/mpd-0.23.15-r2.ebuild     | 291 ++++++++++++++++++++++++++++++
 3 files changed, 354 insertions(+)