Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 929876 - www-client/elinks: needs upgrade to Python 3.12 (PythonCompatUpdate)
Summary: www-client/elinks: needs upgrade to Python 3.12 (PythonCompatUpdate)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal
Assignee: Felix Janda
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 921826
  Show dependency tree
 
Reported: 2024-04-13 08:56 UTC by Michał Górny
Modified: 2024-07-16 22:46 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-04-13 08:56:30 UTC
This package does not support Python 3.12.  Please test it with Python 3.12 as a matter of urgency as the default will change in early June, as per message on gentoo-dev: https://www.mail-archive.com/gentoo-dev@lists.gentoo.org/msg99104.html.  Please check the information provided in the tracker.  Ask in #gentoo-python on IRC if need any help.
Comment 1 Dion Moult 2024-06-10 10:30:42 UTC
I've started testing it. So far I have this error which I've reported upstream: https://github.com/rkd77/elinks/issues/313 (this is from a manual compilation, not via Gentoo ebuild)

I also have this error in the dodoc phase:

```
Installing doc/manual.html to /var/tmp/portage/www-client/elinks-9999/image/usr/share/doc/elinks-9999
Traceback (most recent call last):
  File "/usr/lib/portage/python3.12/doins.py", line 609, in <module>
    sys.exit(main(sys.argv[1:]))
             ^^^^^^^^^^^^^^^^^^
  File "/usr/lib/portage/python3.12/doins.py", line 598, in main
    if _doins(
       ^^^^^^^
  File "/usr/lib/portage/python3.12/doins.py", line 441, in _doins
    return install_runner.install_file(source, os.path.dirname(dest))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/portage/python3.12/doins.py", line 375, in install_file
    return self._ins_runner.run(source, dest_dir)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/portage/python3.12/doins.py", line 183, in run
    sstat = os.stat(source)
            ^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: b'README'
```
Comment 2 Larry the Git Cow gentoo-dev 2024-07-14 14:03:08 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=42bc41fafc56913795493ed13ef4d663e9760560

commit 42bc41fafc56913795493ed13ef4d663e9760560
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2024-07-14 13:47:19 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2024-07-14 13:47:19 +0000

    www-client/elinks: add python3.12 support
    
    Compiles for me fine, all tests passed.
    
    Closes: https://bugs.gentoo.org/929876
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 www-client/elinks/elinks-0.16.1.1-r3.ebuild | 2 +-
 www-client/elinks/elinks-9999.ebuild        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-07-15 00:21:45 UTC
Per the bug linked above, I think https://github.com/rkd77/elinks/commit/2577da89420ce2a1d58fadd7f2e6809d2ba70dd8 must be backported, as it's not on the upstream 0.16.x branch and not in a 0.16.x release.
Comment 4 Joonas Niilola gentoo-dev 2024-07-15 08:19:06 UTC
Looks like +javascript use flag requires python-3.12:

[ERROR] >>> Not all runs were successful.
atom: =www-client/elinks-0.16.1.1-r3, USE flags: '-X bittorrent brotli -bzip2 finger ftp -gnutls -gopher -gpm -guile idn javascript -lua -lzma -mouse nls -nntp perl -python samba -ssl tre -unicode xml -zlib zstd'
atom: =www-client/elinks-0.16.1.1-r3, USE flags: 'X -bittorrent -brotli bzip2 -finger ftp gnutls gopher gpm guile -idn javascript -lua -lzma -mouse -nls -nntp -perl -python samba -ssl tre -unicode -xml -zlib -zstd'
atom: =www-client/elinks-0.16.1.1-r3, USE flags: 'X bittorrent -brotli bzip2 -finger ftp -gnutls -gopher -gpm -guile idn javascript -lua -lzma mouse -nls nntp perl -python samba ssl -tre unicode xml zlib zstd'
atom: =www-client/elinks-0.16.1.1-r3, USE flags: 'X -bittorrent -brotli -bzip2 finger -ftp -gnutls -gopher gpm -guile idn javascript -lua lzma mouse -nls -nntp perl -python -samba -ssl tre unicode -xml -zlib -zstd'
atom: =www-client/elinks-0.16.1.1-r3, USE flags: 'X bittorrent brotli bzip2 finger ftp gnutls -gopher gpm -guile -idn javascript -lua lzma mouse nls nntp -perl -python -samba ssl tre -unicode xml -zlib zstd'
atom: =www-client/elinks-0.16.1.1-r3, USE flags: '-X bittorrent brotli bzip2 finger -ftp -gnutls gopher gpm guile idn javascript -lua lzma mouse -nls nntp perl -python samba ssl -tre unicode -xml zlib zstd'
atom: =www-client/elinks-0.16.1.1-r3, USE flags: 'X bittorrent brotli -bzip2 -finger -ftp gnutls -gopher -gpm guile -idn javascript -lua -lzma mouse -nls nntp -perl -python -samba -ssl -tre -unicode -xml -zlib zstd'

Though I agree it should be patched, especially since it's still with unstable keywords. 

[ebuild   R    ] www-client/elinks-0.16.1.1-r3::gentoo  USE="bzip2 mouse ssl unicode zlib -X -bittorrent -brotli (-debug) -finger -ftp -gnutls -gopher -gpm (-guile) -idn -javascript -lua -lzma -nls -nntp -perl -python -samba -test* -tre -xml -zstd" LUA_SINGLE_TARGET="lua5-1 -lua5-3 -lua5-4 -luajit" PYTHON_SINGLE_TARGET="python3_12 -python3_10 -python3_11" 0 KiB
Comment 5 Conrad Kostecki gentoo-dev 2024-07-16 21:23:07 UTC
Hm. I do wonder, why I didn't get any errors during runtime usage of javascript? Anyway, I have applied the patch and will commit it shortly.
Comment 6 Larry the Git Cow gentoo-dev 2024-07-16 21:28:38 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2d9fa2ef2f89fb72275dab73204ad2404b22d666

commit 2d9fa2ef2f89fb72275dab73204ad2404b22d666
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2024-07-16 21:24:55 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2024-07-16 21:24:55 +0000

    www-client/elinks: fix python3.12 support
    
    Closes: https://bugs.gentoo.org/929876
    Bug: https://bugs.gentoo.org/919372
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 www-client/elinks/elinks-0.16.1.1-r3.ebuild        |  2 ++
 ...-0.16.1.1-ecmascript-implicit-declaration.patch | 36 ++++++++++++++++++++++
 .../elinks/files/elinks-0.16.1.1-python-3.12.patch | 26 ++++++++++++++++
 3 files changed, 64 insertions(+)
Comment 7 Larry the Git Cow gentoo-dev 2024-07-16 22:46:41 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e4a0bd05737d742166c2c4103c90ace278285b09

commit e4a0bd05737d742166c2c4103c90ace278285b09
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-07-16 22:45:45 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-07-16 22:45:45 +0000

    www-client/elinks: revbump for py3.12 patch
    
    It'll import the wrong thing at runtime otherwise if already built w/
    py3.12 support.
    
    Fixes: 2d9fa2ef2f89fb72275dab73204ad2404b22d666
    Closes: https://bugs.gentoo.org/929876
    Signed-off-by: Sam James <sam@gentoo.org>

 .../elinks/{elinks-0.16.1.1-r3.ebuild => elinks-0.16.1.1-r4.ebuild}       | 0
 1 file changed, 0 insertions(+), 0 deletions(-)