Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 919372 - www-client/elinks-0.16.1.1-r2 - ../.../general.c: error: implicit declaration of function add_to_ecmascript_string_list [-Wimplicit-function-declarati
Summary: www-client/elinks-0.16.1.1-r2 - ../.../general.c: error: implicit declaration...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Felix Janda
URL:
Whiteboard: fixed in 0.16.1.1-r3
Keywords:
Depends on:
Blocks: c99-porting
  Show dependency tree
 
Reported: 2023-12-06 18:10 UTC by Toralf Förster
Modified: 2024-10-31 19:59 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,21.60 KB, text/plain)
2023-12-06 18:10 UTC, Toralf Förster
Details
emerge-history.txt.xz (emerge-history.txt.xz,94.73 KB, application/x-xz)
2023-12-06 18:10 UTC, Toralf Förster
Details
environment (environment,122.18 KB, text/plain)
2023-12-06 18:10 UTC, Toralf Förster
Details
etc.clang.tar.xz (etc.clang.tar.xz,1.14 KB, application/x-xz)
2023-12-06 18:10 UTC, Toralf Förster
Details
etc.portage.tar.xz (etc.portage.tar.xz,26.04 KB, application/x-xz)
2023-12-06 18:10 UTC, Toralf Förster
Details
logs.tar.xz (logs.tar.xz,11.63 KB, application/x-xz)
2023-12-06 18:10 UTC, Toralf Förster
Details
qlist-info.txt.xz (qlist-info.txt.xz,102.86 KB, application/x-xz)
2023-12-06 18:10 UTC, Toralf Förster
Details
temp.tar.xz (temp.tar.xz,43.26 KB, application/x-xz)
2023-12-06 18:10 UTC, Toralf Förster
Details
www-client:elinks-0.16.1.1-r2:20231206-022817.log (www-client:elinks-0.16.1.1-r2:20231206-022817.log,152.95 KB, text/plain)
2023-12-06 18:10 UTC, Toralf Förster
Details
Patch addressing the issue (ecmascript.patch,1.07 KB, patch)
2024-06-06 05:24 UTC, Marcin Deranek
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2023-12-06 18:10:12 UTC
too long lines were shrinked:

[136/276] x86_64-pc-linux-gnu-gcc -Isrc/elinks.p -Isrc -I../elinks-0.16.1.1/src -I. -I../elinks-0.16.1.1 -I/usr/include/lua5.1 -I/usr/include/libxml++-5.0 -I/usr/lib64/libxml++-5.0/include -I/usr/include/libxml2 -I/usr/lib64/perl5/5.38/x86_64-linux/CORE -I/usr/include/ncursesw -fdiagnostics-color=al
[137/276] x86_64-pc-linux-gnu-gcc -Isrc/elinks.p -Isrc -I../elinks-0.16.1.1/src -I. -I../elinks-0.16.1.1 -I/usr/include/lua5.1 -I/usr/include/libxml++-5.0 -I/usr/lib64/libxml++-5.0/include -I/usr/include/libxml2 -I/usr/lib64/perl5/5.38/x86_64-linux/CORE -I/usr/include/ncursesw -fdiagnostics-color=al
[138/276] x86_64-pc-linux-gnu-gcc -Isrc/elinks.p -Isrc -I../elinks-0.16.1.1/src -I. -I../elinks-0.16.1.1 -I/usr/include/lua5.1 -I/usr/include/libxml++-5.0 -I/usr/lib64/libxml++-5.0/include -I/usr/include/libxml2 -I/usr/lib64/perl5/5.38/x86_64-linux/CORE -I/usr/include/ncursesw -fdiagnostics-color=al
FAILED: src/elinks.p/document_html_parser_general.c.o 
x86_64-pc-linux-gnu-gcc -Isrc/elinks.p -Isrc -I../elinks-0.16.1.1/src -I. -I../elinks-0.16.1.1 -I/usr/include/lua5.1 -I/usr/include/libxml++-5.0 -I/usr/lib64/libxml++-5.0/include -I/usr/include/libxml2 -I/usr/lib64/perl5/5.38/x86_64-linux/CORE -I/usr/include/ncursesw -fdiagnostics-color=always -Wall
../elinks-0.16.1.1/src/document/html/parser/general.c: In function html_script:
../elinks-0.16.1.1/src/document/html/parser/general.c:319:17: error: implicit declaration of function add_to_ecmascript_string_list [-Wimplicit-function-declaration]
  319 |                 add_to_ecmascript_string_list(&html_context->part->document->onload_snippets,
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop_gnome_systemd-20231123-170505

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-10
 [2] x86_64-pc-linux-gnu-14 *
clang/llvm (if any):
clang version 17.0.6
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/17/bin
Configuration file: /etc/clang/x86_64-pc-linux-gnu-clang.cfg
/usr/lib/llvm/17
17.0.6
Python 3.11.7
Available Ruby profiles:
  [1]   ruby31 (with Rubygems) *
Available Rust versions:
  [1]   rust-bin-1.73.0 *
The following VMs are available for generation-2:
1)	Eclipse Temurin JDK 17.0.8.1_p1 [openjdk-bin-17]
*)	Eclipse Temurin JDK 21.0.1_p12 [openjdk-bin-21]
3)	Eclipse Temurin JDK 8.382_p05 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   openjdk-bin-8 
  [2]   openjdk-bin-17 
  [3]   openjdk-bin-21  system-vm

The Glorious Glasgow Haskell Compilation System, version 9.2.8
php cli (if any):
go version go1.21.4 linux/amd64

  HEAD of ::gentoo
commit 1ef4830e1dca577848a03e7f564905475b6619bb
Author: Repository mirror & CI <repomirrorci@gentoo.org>
Date:   Tue Dec 5 22:35:30 2023 +0000

    2023-12-05 22:35:29 UTC

emerge -qpvO www-client/elinks
[ebuild  N    ] www-client/elinks-0.16.1.1-r2  USE="X bzip2 ftp gpm idn javascript lua lzma mouse nls perl ssl unicode xml zlib zstd -bittorrent -brotli -debug -finger -gnutls -gopher (-guile) -nntp -samba -test -tre" LUA_SINGLE_TARGET="lua5-1 -lua5-3 -lua5-4 -luajit"
Comment 1 Toralf Förster gentoo-dev 2023-12-06 18:10:13 UTC
Created attachment 877923 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2023-12-06 18:10:15 UTC
Created attachment 877924 [details]
emerge-history.txt.xz
Comment 3 Toralf Förster gentoo-dev 2023-12-06 18:10:16 UTC
Created attachment 877925 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2023-12-06 18:10:17 UTC
Created attachment 877926 [details]
etc.clang.tar.xz
Comment 5 Toralf Förster gentoo-dev 2023-12-06 18:10:18 UTC
Created attachment 877927 [details]
etc.portage.tar.xz
Comment 6 Toralf Förster gentoo-dev 2023-12-06 18:10:19 UTC
Created attachment 877928 [details]
logs.tar.xz
Comment 7 Toralf Förster gentoo-dev 2023-12-06 18:10:20 UTC
Created attachment 877929 [details]
qlist-info.txt.xz
Comment 8 Toralf Förster gentoo-dev 2023-12-06 18:10:22 UTC
Created attachment 877930 [details]
temp.tar.xz
Comment 9 Toralf Förster gentoo-dev 2023-12-06 18:10:24 UTC
Created attachment 877931 [details]
www-client:elinks-0.16.1.1-r2:20231206-022817.log
Comment 10 Marcin Deranek 2024-06-06 05:24:06 UTC
Created attachment 895204 [details, diff]
Patch addressing the issue
Comment 11 Alexander Wessel 2024-06-24 23:48:41 UTC
Confirmed, I get this error with a re-emerge of www-client/elinks-0.16.1.1-r2 or-r3. First, the build failed for the -r3 update, then after masking -r3 it also happened when trying an emerge -1va for -r2.

I get the same error:

../elinks-0.16.1.1/src/document/html/parser/general.c: In function ‘html_script’:
../elinks-0.16.1.1/src/document/html/parser/general.c:319:17: error: implicit declaration of function ‘add_to_ecmascript_string_list’ [-Wimplicit-function-declaration]
  319 |                 add_to_ecmascript_string_list(&html_context->part->document->onload_snippets,
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I have www-client/elinks-0.16.1.1-r2 installed, so it must have built before:

Installed versions:  0.16.1.1-r2^t(21:29:49 05/08/24)(X brotli bzip2 ftp gpm javascript mouse nls perl ssl unicode xml zlib zstd -bittorrent -debug -finger -gnutls -gopher -guile -idn -lua -lzma -nntp -samba -test -tre LUA_SINGLE_TARGET="lua5-1 -lua5-3 -lua5-4 -luajit")

It would have been built with gcc-13.2.1_p20240503 for that installation:

2024-05-07T04:07:47 >>> sys-devel/gcc-13.2.1_p20240503

Since then I updated to gcc-14.1.1, and I guess that's causing the issue:

2024-05-08T21:48:45 >>> sys-devel/gcc-13.2.1_p20240503
2024-05-20T12:45:16 >>> sys-devel/gcc-14.1.1_p20240518
2024-05-28T03:42:42 <<< sys-devel/gcc-13.2.1_p20240503
2024-06-19T06:28:52 >>> sys-devel/gcc-14.1.1_p20240615
2024-06-23T06:00:25 >>> sys-devel/gcc-14.1.1_p20240622
Comment 12 Larry the Git Cow gentoo-dev 2024-07-16 21:28:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c6a2b34886febe729db3200202a0b31578f7638b

commit c6a2b34886febe729db3200202a0b31578f7638b
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2024-07-16 21:26:17 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2024-07-16 21:26:17 +0000

    www-client/elinks: fix implicit declaration ecmascript
    
    Closes: https://bugs.gentoo.org/919372
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 www-client/elinks/elinks-0.16.1.1-r2.ebuild | 1 +
 1 file changed, 1 insertion(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2d9fa2ef2f89fb72275dab73204ad2404b22d666

commit 2d9fa2ef2f89fb72275dab73204ad2404b22d666
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2024-07-16 21:24:55 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2024-07-16 21:24:55 +0000

    www-client/elinks: fix python3.12 support
    
    Closes: https://bugs.gentoo.org/929876
    Bug: https://bugs.gentoo.org/919372
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 www-client/elinks/elinks-0.16.1.1-r3.ebuild        |  2 ++
 ...-0.16.1.1-ecmascript-implicit-declaration.patch | 36 ++++++++++++++++++++++
 .../elinks/files/elinks-0.16.1.1-python-3.12.patch | 26 ++++++++++++++++
 3 files changed, 64 insertions(+)