Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 926110 - dev-tcltk/itk-4.2.3 needs a patch to install
Summary: dev-tcltk/itk-4.2.3 needs a patch to install
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: TCL/TK Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-03 18:17 UTC by Helmut Jarausch
Modified: 2024-03-06 21:11 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (itk-4.2.3.build,15.09 KB, text/plain)
2024-03-05 10:58 UTC, Helmut Jarausch
Details
emerge --info (itk.info,20.45 KB, text/plain)
2024-03-05 10:59 UTC, Helmut Jarausch
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Helmut Jarausch 2024-03-03 18:17:47 UTC
The generated Makefile contains
INSTALL		= $(SHELL) install -c $(INSTALL_OPTIONS)


but /usr/bin/install  from sys-apps/coreutils
is a binary executable which cannot be executed by the shell.

An ad hoc fix is

src_compile() {
	sed -e's:@INSTALL@:/usr/bin/install:' -i Makefile.in  || die
	emake CFLAGS_DEFAULT="${CFLAGS}"
}
Comment 1 Andreas Sturmlechner gentoo-dev 2024-03-03 18:23:20 UTC
That's not, by chance, bug 925741?

Please stop filing bugs right now, run emerge --sync and start adding build.log (as you would know).
Comment 2 Helmut Jarausch 2024-03-05 10:58:41 UTC
Created attachment 886734 [details]
build log
Comment 3 Helmut Jarausch 2024-03-05 10:59:02 UTC
Created attachment 886735 [details]
emerge --info
Comment 4 Helmut Jarausch 2024-03-05 16:33:33 UTC
IMHO, the patch itk-4.2.3-install.patch is wrong.
+    INSTALL='$(SHELL) install -c'

tries to run the shell on the binary executable /usr/bin/install.
Comment 5 Larry the Git Cow gentoo-dev 2024-03-06 21:10:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cbbabe2e958fc528dc342680e6cc4fd62961661a

commit cbbabe2e958fc528dc342680e6cc4fd62961661a
Author:     Alfredo Tupone <tupone@gentoo.org>
AuthorDate: 2024-03-06 21:09:01 +0000
Commit:     Alfredo Tupone <tupone@gentoo.org>
CommitDate: 2024-03-06 21:09:47 +0000

    dev-tcltk/itk: fix install
    
    Closes: https://bugs.gentoo.org/926110
    Signed-off-by: Alfredo Tupone <tupone@gentoo.org>

 dev-tcltk/itk/files/itk-4.2.3-install.patch             | 2 +-
 dev-tcltk/itk/{itk-4.2.3.ebuild => itk-4.2.3-r1.ebuild} | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
Comment 6 Tupone Alfredo gentoo-dev 2024-03-06 21:11:49 UTC
I don't know why it works here from ebuild.
but don't if done by make install

But now It works in both cases