Created attachment 882105 [details] emerge --info similar to https://bugs.gentoo.org/921938, experienced at the same time and on same system
Created attachment 882106 [details] emerge build log
Missing includes (exposed by PCH disabling).
MYCMAKEARGS="-DCMAKE_DISABLE_PRECOMPILE_HEADERS=OFF"
(In reply to bratzmeister from comment #3) > MYCMAKEARGS="-DCMAKE_DISABLE_PRECOMPILE_HEADERS=OFF" compilation succeeds with that variable
I don't see where in the log the PCH headers are disabled?
(In reply to Esteve Varela Colominas from comment #5) > I don't see where in the log the PCH headers are disabled? Look at the See Also bug.
Ah... That's gonna be annoying going forward given upstream never tests without...
So, the net-im/telegram-desktop::gentoo is still broken...
(In reply to Dmitry Baranov from comment #8) > So, the net-im/telegram-desktop::gentoo is still broken... Not a helpful comment, and it's only been a day too.
I don't have time to fix and test this right now. I'm inclined to just re-enable PCH since it worked thus far, and test disabling it during the next bump. That sound OK, sam?
(In reply to Esteve Varela Colominas from comment #10) > I don't have time to fix and test this right now. I'm inclined to just > re-enable PCH since it worked thus far, and test disabling it during the > next bump. That sound OK, sam? wfm
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5fbc9c24fe8b0629083f09a6d21b3f45d4c04026 commit 5fbc9c24fe8b0629083f09a6d21b3f45d4c04026 Author: Esteve Varela Colominas <esteve.varela@gmail.com> AuthorDate: 2024-01-14 20:33:57 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2024-01-14 20:42:52 +0000 net-im/telegram-desktop: Re-enable precompiled headers Closes: https://bugs.gentoo.org/921939 Thanks-to: bratzmeister@proton.me Signed-off-by: Esteve Varela Colominas <esteve.varela@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/34809 Signed-off-by: Sam James <sam@gentoo.org> net-im/telegram-desktop/telegram-desktop-4.12.2.ebuild | 3 +++ net-im/telegram-desktop/telegram-desktop-4.13.1.ebuild | 3 +++ 2 files changed, 6 insertions(+)
Postmortem: After spending the *worst* part of an hour trying to fix missing includes, and only getting 13% completion, I've concluded that PCH-less telegram builds are not an option I wish to support. This codebase is *never* tested without PCH, and it's gonna become a running maintenance burden.
(In reply to Esteve Varela Colominas from comment #13) > Postmortem: After spending the *worst* part of an hour trying to fix missing > includes, and only getting 13% completion, I've concluded that PCH-less > telegram builds are not an option I wish to support. This codebase is > *never* tested without PCH, and it's gonna become a running maintenance > burden. Were you doing clean builds instead of just running ninja repeatedly after fixing things?
A mix of ccache and running ninja manually. It's just a lot, and there's a distinct lack of central headers that everything includes to add some definitions to. I reckon one could leverage cmake instead to add -include flags to the compiler command line, to always include the _pch.h files for each used library, but I'm not well versed enough in cmake to do this. Contributions are welcome.
(In reply to Esteve Varela Colominas from comment #15) > I reckon one could leverage cmake instead to add -include flags to the > compiler command line, to always include the _pch.h files for each used > library, but I'm not well versed enough in cmake to do this. Contributions > are welcome. You can see what Audacity is doing for an example.
*** Bug 922222 has been marked as a duplicate of this bug. ***
