Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 921939 - net-im/telegram-desktop-4.13.1::gentoo failed (compile phase): ‘int64’ does not name a type; did you mean ‘int64_t’?
Summary: net-im/telegram-desktop-4.13.1::gentoo failed (compile phase): ‘int64’ does n...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Esteve Varela Colominas
URL:
Whiteboard:
Keywords: PullRequest
: 922222 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-01-12 15:30 UTC by bratzmeister
Modified: 2024-01-20 02:00 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge--info,18.82 KB, text/plain)
2024-01-12 15:30 UTC, bratzmeister
Details
emerge build log (build.log.tar.xz,29.98 KB, application/x-xz)
2024-01-12 15:32 UTC, bratzmeister
Details

Note You need to log in before you can comment on or make changes to this bug.
Description bratzmeister 2024-01-12 15:30:05 UTC
Created attachment 882105 [details]
emerge --info

similar to https://bugs.gentoo.org/921938, experienced at the same time and on same system
Comment 1 bratzmeister 2024-01-12 15:32:14 UTC
Created attachment 882106 [details]
emerge build log
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-01-12 15:34:03 UTC
Missing includes (exposed by PCH disabling).
Comment 3 bratzmeister 2024-01-12 17:50:58 UTC
MYCMAKEARGS="-DCMAKE_DISABLE_PRECOMPILE_HEADERS=OFF"
Comment 4 bratzmeister 2024-01-12 17:51:32 UTC
(In reply to bratzmeister from comment #3)
> MYCMAKEARGS="-DCMAKE_DISABLE_PRECOMPILE_HEADERS=OFF"

compilation succeeds with that variable
Comment 5 Esteve Varela Colominas 2024-01-12 20:01:50 UTC
I don't see where in the log the PCH headers are disabled?
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-01-12 20:02:20 UTC
(In reply to Esteve Varela Colominas from comment #5)
> I don't see where in the log the PCH headers are disabled?

Look at the See Also bug.
Comment 7 Esteve Varela Colominas 2024-01-12 20:41:34 UTC
Ah... That's gonna be annoying going forward given upstream never tests without...
Comment 8 Dmitriy Baranov 2024-01-13 21:34:20 UTC
So, the net-im/telegram-desktop::gentoo is still broken...
Comment 9 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-01-13 21:36:01 UTC
(In reply to Dmitry Baranov from comment #8)
> So, the net-im/telegram-desktop::gentoo is still broken...

Not a helpful comment, and it's only been a day too.
Comment 10 Esteve Varela Colominas 2024-01-13 22:35:19 UTC
I don't have time to fix and test this right now. I'm inclined to just re-enable PCH since it worked thus far, and test disabling it during the next bump. That sound OK, sam?
Comment 11 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-01-13 22:37:53 UTC
(In reply to Esteve Varela Colominas from comment #10)
> I don't have time to fix and test this right now. I'm inclined to just
> re-enable PCH since it worked thus far, and test disabling it during the
> next bump. That sound OK, sam?

wfm
Comment 12 Larry the Git Cow gentoo-dev 2024-01-14 20:43:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5fbc9c24fe8b0629083f09a6d21b3f45d4c04026

commit 5fbc9c24fe8b0629083f09a6d21b3f45d4c04026
Author:     Esteve Varela Colominas <esteve.varela@gmail.com>
AuthorDate: 2024-01-14 20:33:57 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-01-14 20:42:52 +0000

    net-im/telegram-desktop: Re-enable precompiled headers
    
    Closes: https://bugs.gentoo.org/921939
    Thanks-to: bratzmeister@proton.me
    Signed-off-by: Esteve Varela Colominas <esteve.varela@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/34809
    Signed-off-by: Sam James <sam@gentoo.org>

 net-im/telegram-desktop/telegram-desktop-4.12.2.ebuild | 3 +++
 net-im/telegram-desktop/telegram-desktop-4.13.1.ebuild | 3 +++
 2 files changed, 6 insertions(+)
Comment 13 Esteve Varela Colominas 2024-01-16 20:28:20 UTC
Postmortem: After spending the *worst* part of an hour trying to fix missing includes, and only getting 13% completion, I've concluded that PCH-less telegram builds are not an option I wish to support. This codebase is *never* tested without PCH, and it's gonna become a running maintenance burden.
Comment 14 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-01-17 03:29:19 UTC
(In reply to Esteve Varela Colominas from comment #13)
> Postmortem: After spending the *worst* part of an hour trying to fix missing
> includes, and only getting 13% completion, I've concluded that PCH-less
> telegram builds are not an option I wish to support. This codebase is
> *never* tested without PCH, and it's gonna become a running maintenance
> burden.

Were you doing clean builds instead of just running ninja repeatedly after fixing things?
Comment 15 Esteve Varela Colominas 2024-01-17 06:48:53 UTC
A mix of ccache and running ninja manually. It's just a lot, and there's a distinct lack of central headers that everything includes to add some definitions to.
I reckon one could leverage cmake instead to add -include flags to the compiler command line, to always include the _pch.h files for each used library, but I'm not well versed enough in cmake to do this. Contributions are welcome.
Comment 16 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-01-17 06:49:58 UTC
(In reply to Esteve Varela Colominas from comment #15)
> I reckon one could leverage cmake instead to add -include flags to the
> compiler command line, to always include the _pch.h files for each used
> library, but I'm not well versed enough in cmake to do this. Contributions
> are welcome.

You can see what Audacity is doing for an example.
Comment 17 Esteve Varela Colominas 2024-01-20 02:00:17 UTC
*** Bug 922222 has been marked as a duplicate of this bug. ***