Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 910337 - media-gfx/digikam: bring back mediaplayer
Summary: media-gfx/digikam: bring back mediaplayer
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Andreas K. Hüttel
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-07-14 13:25 UTC by Robert G. Siebeck
Modified: 2024-05-07 21:33 UTC (History)
10 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to enable mediaplayer in digikam-8.1.0 (digikam-enable-mediaplayer.patch,544 bytes, patch)
2023-07-14 13:25 UTC, Robert G. Siebeck
Details | Diff
digikam-8.2.0-r1.ebuild (digikam-8.2.0-r1.ebuild,4.75 KB, application/vnd.gentoo.ebuild)
2024-03-06 13:49 UTC, Robert G. Siebeck
Details
digikam-8.3.0-r1.ebuild (digikam-8.3.0-r1.ebuild,4.24 KB, text/plain)
2024-03-31 07:49 UTC, Andrey Grozin
Details
qtmultimedia dep (digikam-8.3.0-r1.ebuild,4.28 KB, text/plain)
2024-04-30 13:54 UTC, A.J.
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert G. Siebeck 2023-07-14 13:25:14 UTC
The mediaplayer in Digikam depended on media-libs/qtav, which has been removed recently, see https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=506c569b5dd51f8a925b9492c2d96e81567b0abf

However, qtav has been added to Digikam's source tree a while back, see https://invent.kde.org/graphics/digikam/-/tree/master/core/libs/video/qtav

The mediaplayer can therefore simply be enabled using a cmake flag.

Patch attached.

Reproducible: Always
Comment 1 Robert G. Siebeck 2023-07-14 13:25:51 UTC
Created attachment 865489 [details, diff]
Patch to enable mediaplayer in digikam-8.1.0
Comment 2 Ionen Wolkens gentoo-dev 2023-07-14 13:55:21 UTC
ftr this is probably better than using the qtav package given its own upstream declared itself unmaintained[1], while this bundled version seems to be maintained by digikam (haven't tried but *seems* they fixed e.g. bug #834386 -- on that note, patch is likely missing dependencies like at least ffmpeg)

[1] https://github.com/wang-bin/QtAV/commit/8bb780215bcd4a16d098a2a913d01f83b16193d7
Comment 3 Robert G. Siebeck 2024-03-06 13:49:23 UTC
Created attachment 886807 [details]
digikam-8.2.0-r1.ebuild

I've attached an updated ebuild for digikam-8.2.0 which adds the mediaplayer via a use-flag and fixes its dependencies.
Comment 4 Andrey Grozin gentoo-dev 2024-03-31 07:49:26 UTC
Created attachment 889084 [details]
digikam-8.3.0-r1.ebuild

It's so convenient to have a possibility to view short mp4 videos in digikam. Why isn't it in the tree? I ported the ebuild which was attached to 8.3.0-r1 and built it. Works fine. Let's commit it to the tree.
Comment 5 A.J. 2024-04-30 13:54:49 UTC
Created attachment 892015 [details]
qtmultimedia dep
Comment 6 A.J. 2024-04-30 13:56:31 UTC
Agreed that the official ebuild should be updated.  This was difficult to figure out.  I had to add a dependency to qtmultimedia[widgets] because I don't have a full QT/KDE install (awesomewm).  Attached updated ebuild.
Comment 7 Larry the Git Cow gentoo-dev 2024-05-01 11:22:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7e020a5c0eda48da9cbadf8ee4a1b098c3607f23

commit 7e020a5c0eda48da9cbadf8ee4a1b098c3607f23
Author:     Andreas K. Hüttel <dilfridge@gentoo.org>
AuthorDate: 2024-05-01 11:21:45 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2024-05-01 11:22:22 +0000

    media-gfx/digikam: Re-add internal video player
    
    Closes: https://bugs.gentoo.org/910337
    Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>

 media-gfx/digikam/digikam-8.3.0-r1.ebuild | 156 ++++++++++++++++++++++++++++++
 media-gfx/digikam/metadata.xml            |   1 +
 2 files changed, 157 insertions(+)
Comment 8 Andreas Sturmlechner gentoo-dev 2024-05-07 21:33:58 UTC
Unfortunately this is by far not complete.

Where do you pass portaudio or pulseaudio option to cmake args? No linking to either? If it is just RDEPEND swappable, then it would only be in RDEPEND? Where do you handle conflict with opengl IUSE cmake arg?