Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 910337 - media-gfx/digikam: bring back mediaplayer
Summary: media-gfx/digikam: bring back mediaplayer
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Andreas K. Hüttel
URL:
Whiteboard: fixed in >=8.5.0
Keywords: InOverlay
Depends on: 936794
Blocks:
  Show dependency tree
 
Reported: 2023-07-14 13:25 UTC by Robert G. Siebeck
Modified: 2024-08-06 23:04 UTC (History)
12 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to enable mediaplayer in digikam-8.1.0 (digikam-enable-mediaplayer.patch,544 bytes, patch)
2023-07-14 13:25 UTC, Robert G. Siebeck
Details | Diff
digikam-8.2.0-r1.ebuild (digikam-8.2.0-r1.ebuild,4.75 KB, application/vnd.gentoo.ebuild)
2024-03-06 13:49 UTC, Robert G. Siebeck
Details
digikam-8.3.0-r1.ebuild (digikam-8.3.0-r1.ebuild,4.24 KB, text/plain)
2024-03-31 07:49 UTC, Andrey Grozin
Details
qtmultimedia dep (digikam-8.3.0-r1.ebuild,4.28 KB, text/plain)
2024-04-30 13:54 UTC, A.J.
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert G. Siebeck 2023-07-14 13:25:14 UTC
The mediaplayer in Digikam depended on media-libs/qtav, which has been removed recently, see https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=506c569b5dd51f8a925b9492c2d96e81567b0abf

However, qtav has been added to Digikam's source tree a while back, see https://invent.kde.org/graphics/digikam/-/tree/master/core/libs/video/qtav

The mediaplayer can therefore simply be enabled using a cmake flag.

Patch attached.

Reproducible: Always
Comment 1 Robert G. Siebeck 2023-07-14 13:25:51 UTC
Created attachment 865489 [details, diff]
Patch to enable mediaplayer in digikam-8.1.0
Comment 2 Ionen Wolkens gentoo-dev 2023-07-14 13:55:21 UTC
ftr this is probably better than using the qtav package given its own upstream declared itself unmaintained[1], while this bundled version seems to be maintained by digikam (haven't tried but *seems* they fixed e.g. bug #834386 -- on that note, patch is likely missing dependencies like at least ffmpeg)

[1] https://github.com/wang-bin/QtAV/commit/8bb780215bcd4a16d098a2a913d01f83b16193d7
Comment 3 Robert G. Siebeck 2024-03-06 13:49:23 UTC
Created attachment 886807 [details]
digikam-8.2.0-r1.ebuild

I've attached an updated ebuild for digikam-8.2.0 which adds the mediaplayer via a use-flag and fixes its dependencies.
Comment 4 Andrey Grozin gentoo-dev 2024-03-31 07:49:26 UTC
Created attachment 889084 [details]
digikam-8.3.0-r1.ebuild

It's so convenient to have a possibility to view short mp4 videos in digikam. Why isn't it in the tree? I ported the ebuild which was attached to 8.3.0-r1 and built it. Works fine. Let's commit it to the tree.
Comment 5 A.J. 2024-04-30 13:54:49 UTC
Created attachment 892015 [details]
qtmultimedia dep
Comment 6 A.J. 2024-04-30 13:56:31 UTC
Agreed that the official ebuild should be updated.  This was difficult to figure out.  I had to add a dependency to qtmultimedia[widgets] because I don't have a full QT/KDE install (awesomewm).  Attached updated ebuild.
Comment 7 Larry the Git Cow gentoo-dev 2024-05-01 11:22:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7e020a5c0eda48da9cbadf8ee4a1b098c3607f23

commit 7e020a5c0eda48da9cbadf8ee4a1b098c3607f23
Author:     Andreas K. Hüttel <dilfridge@gentoo.org>
AuthorDate: 2024-05-01 11:21:45 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2024-05-01 11:22:22 +0000

    media-gfx/digikam: Re-add internal video player
    
    Closes: https://bugs.gentoo.org/910337
    Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>

 media-gfx/digikam/digikam-8.3.0-r1.ebuild | 156 ++++++++++++++++++++++++++++++
 media-gfx/digikam/metadata.xml            |   1 +
 2 files changed, 157 insertions(+)
Comment 8 Andreas Sturmlechner gentoo-dev 2024-05-07 21:33:58 UTC
Unfortunately this is by far not complete.

Where do you pass portaudio or pulseaudio option to cmake args? No linking to either? If it is just RDEPEND swappable, then it would only be in RDEPEND? Where do you handle conflict with opengl IUSE cmake arg?
Comment 9 Larry the Git Cow gentoo-dev 2024-05-13 20:26:05 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b368e8ce04e6ba0633d83ff7db535fcdd35ca852

commit b368e8ce04e6ba0633d83ff7db535fcdd35ca852
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-05-07 21:21:07 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-05-13 20:25:30 +0000

    media-gfx/digikam: Drop 8.3.0-r1, IUSE=mediaplayer needs more work
    
    Conflicting IUSE opengl vs. mediaplayer (with dev-qt/qtopengl)
    Dependencies unhandled in cmake
    Deprecated dependency reintroduced (media-sound/pulseaudio)
    
    Bug: https://bugs.gentoo.org/910337
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 media-gfx/digikam/digikam-8.3.0-r1.ebuild | 156 ------------------------------
 1 file changed, 156 deletions(-)
Comment 10 Andrey Grozin gentoo-dev 2024-05-14 05:35:40 UTC
But it works!
I think my case is typical: I have a huge tree of photos with a relatively small admixture of videos. I want to view the materials from some travel, for example. digikam with USE=-mediaplayer will show me all jpegs. But it will not show me videos, not even thumbnails, will not show info on video files. To view them, I have to switch to a term window, cd to the relevant directory, find videos in a large pile of photos, and view them using some external tool.
Many years ago I used some other program, probably, kphotoalbum (I'm not 100% sure). And when I clicked of a video file in a photo collection, it started some video viewer (maybe, kaffeine, not sure). This was convenient. But then I switched to digikam. I liked that it writes extra info (what people are on this photo, etc.) directly in the jpeg, not in some external database file (which is easily lost, e.g., when an old notebook breaks, and I switch to a new one). But digikam does not show videos :-(
Comment 11 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-05-14 05:54:37 UTC
It needs more attention and the issues were explained in the commit message, the bug is not WONTFIX'd.

Feel free to give a patch addressing the concerns raised.
Comment 12 Larry the Git Cow gentoo-dev 2024-08-01 17:06:02 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=0eef4717f48d901122c4ca274de223dda2a8f023

commit 0eef4717f48d901122c4ca274de223dda2a8f023
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-08-01 17:02:56 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-08-01 17:05:26 +0000

    media-gfx/digikam: Add IUSE video
    
    Bug: https://bugs.gentoo.org/910337
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 media-gfx/digikam/digikam-9999.ebuild | 5 +++--
 media-gfx/digikam/metadata.xml        | 1 +
 2 files changed, 4 insertions(+), 2 deletions(-)
Comment 13 Larry the Git Cow gentoo-dev 2024-08-06 23:04:38 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=25fda5730b0477ccec49a84c46f8d3686723e3cd

commit 25fda5730b0477ccec49a84c46f8d3686723e3cd
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-08-06 22:39:33 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-08-06 23:03:56 +0000

    media-gfx/digikam: Port to KF6, add IUSE video
    
    Patchset content:
    
    Gilles Caulier (2):
          clazy++
          To prevent a race condition at init when sidebar state is restored,
             use a Qtimer singleShot with a lambda
    
    Maik Qualmann (18):
          disable ExifTool tab with a empty URL
          fix use filename instead of path for Exif and Makernote tab
          fix time-consuming index functions in the timeline widget
          show last database error message also in the database settings dialog
          fix missing tags when changing database at runtime
          fix the grid display with 16 bit images in the Lensfun tool
          fix possible sidecar file in the Local Export Tool
          enable the QuickTimeUTC flag in ExifTool
          fix the problem with the QFileSystemWatcher
          same error handling as in query batch mode for a single query
          escape the input from REGEX MATCHALL
          fix BQM workflow context menu
          fix QImage 32 bit (8 bit color) from 16 bit DImg for thumbnails
          fix prepare a copied query and handle bind values correctly
          fix right sidebar view state
          activate the popup in the menu of a KToolBarPopupAction
          fix possible loss of database metadata in the Image Editor
          enable update to unique hash V3
    
    Closes: https://bugs.gentoo.org/936794
    Closes: https://bugs.gentoo.org/910337
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 media-gfx/digikam/Manifest                 |   1 +
 media-gfx/digikam/digikam-8.4.0-r10.ebuild | 136 +++++++++++++++++++++++++++++
 media-gfx/digikam/metadata.xml             |   1 +
 3 files changed, 138 insertions(+)