This package still uses the legacy eclass code paths. These paths are deprecated and pose a significant maintenance cost. Please update the package to use PEP517 build mode. For more information, please see the Python Guide, particularly; https://projects.gentoo.org/python/guide/migration.html#migrating-to-pep-517-builds
[Adding this comment en-masse, sorry for the noise, but it's important.) 1. Please take particular care to check file diffs before/after, possibly using `iwdevtools`. Keep a particular eye out for e.g. config files now missing from /etc and instead being in /usr/lib/python*/site-packages, etc. 2. Please make sure to do the migration in a new revision in ~arch, partly because of 1.
The issue I see here while migrating is that it stops honoring the install option --pymol-path and, instead of installing the things in /usr/share/pymol, it ends up placing the stuff at /usr/lib/python3.11/site-packages/pymol/pymol_path/ I have tried with DISTUTILS_USE_PEP517="setuptools"
I see in distros like Fedora they are simply moving the files to the desired location :/ Not elegant but...
Created attachment 865792 [details] pymol-2.5.0-r4.ebuild
Created attachment 865793 [details, diff] pymol-2.5.0-format-security.patch As I was looking in other distributions I find this fix (unrelated with this bug but still useful when we finally revbump)
The attached ebuild seems to work (I am not now at work for running more complex tests... but simpler ones look to not break)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e7319a218c29e15bae4b0dd617db10d286adfef6 commit e7319a218c29e15bae4b0dd617db10d286adfef6 Author: Pacho Ramos <pacho@gentoo.org> AuthorDate: 2023-07-20 08:01:11 +0000 Commit: Pacho Ramos <pacho@gentoo.org> CommitDate: 2023-07-20 08:01:11 +0000 sci-chemistry/pymol: Use PEP517 build Closes: https://bugs.gentoo.org/910021 Signed-off-by: Pacho Ramos <pacho@gentoo.org> .../pymol/files/pymol-2.5.0-format-security.patch | 15 +++ sci-chemistry/pymol/pymol-2.5.0-r4.ebuild | 108 +++++++++++++++++++++ 2 files changed, 123 insertions(+)
on prefix, compile seems to work, but install fails second arg of the added mv in python_install_all() must be ${ED}/.... (in the first arg to mv, python_get_sitedir has the prefix, hence ${D}) mv "${D}/$(python_get_sitedir)"/pymol/pymol_path/* "${ED}"/usr/share/pymol || die anyway, thanks for the more standardized ebuild
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7c1155b0a87a8388154a392f173e0399394cd681 commit 7c1155b0a87a8388154a392f173e0399394cd681 Author: Pacho Ramos <pacho@gentoo.org> AuthorDate: 2023-07-20 11:30:51 +0000 Commit: Pacho Ramos <pacho@gentoo.org> CommitDate: 2023-07-20 11:31:44 +0000 sci-chemistry/pymol: Fix install on prefix Thanks-to: hsk17 Bug: https://bugs.gentoo.org/910021 Signed-off-by: Pacho Ramos <pacho@gentoo.org> sci-chemistry/pymol/pymol-2.5.0-r4.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
